Fix binary operation +, - or * on string

steef · fabpot · commit 7bb0444bf0d8 · 2019-06-13T17:39:17.000+02:00
By type casting to integer.
diff --git a/Constraints/IssnValidator.php b/Constraints/IssnValidator.php
@@ -120,7 +120,7 @@ public function validate($value, Constraint $constraint)
 
         for ($i = 0; $i < 7; ++$i) {
             // Multiply the first digit by 8, the second by 7, etc.
-            $checkSum += (8 - $i) * $canonical[$i];
+            $checkSum += (8 - $i) * (int) $canonical[$i];
         }
 
         if (0 !== $checkSum % 11) {
diff --git a/Constraints/LuhnValidator.php b/Constraints/LuhnValidator.php
@@ -83,7 +83,7 @@ public function validate($value, Constraint $constraint)
         //         ^     ^     ^     ^     ^
         //    =    1+8 + 4  +  6  +  1+6 + 2
         for ($i = $length - 2; $i >= 0; $i -= 2) {
-            $checkSum += array_sum(str_split($value[$i] * 2));
+            $checkSum += array_sum(str_split((int) $value[$i] * 2));
         }
 
         if (0 === $checkSum || 0 !== $checkSum % 10) {

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ public function validate($value, Constraint $constraint)`
`120`	`120`
`121`	`121`	`for ($i = 0; $i < 7; ++$i) {`
`122`	`122`	`// Multiply the first digit by 8, the second by 7, etc.`
`123`		`- $checkSum += (8 - $i) * $canonical[$i];`
	`123`	`+ $checkSum += (8 - $i) * (int) $canonical[$i];`
`124`	`124`	`}`
`125`	`125`
`126`	`126`	`if (0 !== $checkSum % 11) {`
Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ public function validate($value, Constraint $constraint)`
`83`	`83`	`// ^ ^ ^ ^ ^`
`84`	`84`	`// = 1+8 + 4 + 6 + 1+6 + 2`
`85`	`85`	`for ($i = $length - 2; $i >= 0; $i -= 2) {`
`86`		`- $checkSum += array_sum(str_split($value[$i] * 2));`
	`86`	`+ $checkSum += array_sum(str_split((int) $value[$i] * 2));`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`if (0 === $checkSum \|\| 0 !== $checkSum % 10) {`