Skip to content

Commit 00e8683

Browse files
committed
do not enable validator auto mapping by default
1 parent f30b084 commit 00e8683

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

DependencyInjection/AddAutoMappingConfigurationPass.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,12 @@ public function process(ContainerBuilder $container)
7070
/**
7171
* Builds a regexp to check if a class is auto-mapped.
7272
*/
73-
private function getRegexp(array $patterns): string
73+
private function getRegexp(array $patterns): ?string
7474
{
75+
if (!$patterns) {
76+
return null;
77+
}
78+
7579
$regexps = [];
7680
foreach ($patterns as $pattern) {
7781
// Escape namespace

Tests/DependencyInjection/AddAutoMappingConfigurationPassTest.php

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,4 +70,17 @@ public function mappingProvider(): array
7070
['Symfony\Component\Validator\Tests\Fixtures\\**', ['trailing_double_star'], '{^App\\\\|^Symfony\\\\Component\\\\Validator\\\\Tests\\\\Fixtures\\\\.*?$}'],
7171
];
7272
}
73+
74+
public function testDoNotMapAllClassesWhenConfigIsEmpty()
75+
{
76+
$container = new ContainerBuilder();
77+
$container->setParameter('validator.auto_mapping', []);
78+
79+
$container->register('validator.builder', ValidatorBuilder::class);
80+
$container->register('loader')->addTag('validator.auto_mapper');
81+
82+
(new AddAutoMappingConfigurationPass())->process($container);
83+
84+
$this->assertNull($container->getDefinition('loader')->getArgument('$classValidatorRegexp'));
85+
}
7386
}

0 commit comments

Comments
 (0)