Skip to content

Commit af7f611

Browse files
committed
Refactoring tests.
1 parent 2dad34e commit af7f611

10 files changed

+10
-13
lines changed

Tests/Dumper/CsvFileDumperTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public function testDump()
2727
$dumper = new CsvFileDumper();
2828
$dumper->dump($catalogue, array('path' => $tempDir));
2929

30-
$this->assertEquals(file_get_contents(__DIR__.'/../fixtures/valid.csv'), file_get_contents($tempDir.'/messages.en.csv'));
30+
$this->assertFileEquals(__DIR__.'/../fixtures/valid.csv', $tempDir.'/messages.en.csv');
3131

3232
unlink($tempDir.'/messages.en.csv');
3333
}

Tests/Dumper/IcuResFileDumperTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public function testDump()
2929
$dumper = new IcuResFileDumper();
3030
$dumper->dump($catalogue, array('path' => $tempDir));
3131

32-
$this->assertEquals(file_get_contents(__DIR__.'/../fixtures/resourcebundle/res/en.res'), file_get_contents($tempDir.'/messages/en.res'));
32+
$this->assertFileEquals(__DIR__.'/../fixtures/resourcebundle/res/en.res', $tempDir.'/messages/en.res');
3333

3434
@unlink($tempDir.'/messages/en.res');
3535
@rmdir($tempDir.'/messages');

Tests/Dumper/IniFileDumperTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public function testDump()
2626
$dumper = new IniFileDumper();
2727
$dumper->dump($catalogue, array('path' => $tempDir));
2828

29-
$this->assertEquals(file_get_contents(__DIR__.'/../fixtures/resources.ini'), file_get_contents($tempDir.'/messages.en.ini'));
29+
$this->assertFileEquals(__DIR__.'/../fixtures/resources.ini', $tempDir.'/messages.en.ini');
3030

3131
unlink($tempDir.'/messages.en.ini');
3232
}

Tests/Dumper/JsonFileDumperTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public function testDump()
3030
$dumper = new JsonFileDumper();
3131
$dumper->dump($catalogue, array('path' => $tempDir));
3232

33-
$this->assertEquals(file_get_contents(__DIR__.'/../fixtures/resources.json'), file_get_contents($tempDir.'/messages.en.json'));
33+
$this->assertFileEquals(__DIR__.'/../fixtures/resources.json', $tempDir.'/messages.en.json');
3434

3535
unlink($tempDir.'/messages.en.json');
3636
}

Tests/Dumper/MoFileDumperTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public function testDump()
2525
$tempDir = sys_get_temp_dir();
2626
$dumper = new MoFileDumper();
2727
$dumper->dump($catalogue, array('path' => $tempDir));
28-
$this->assertEquals(file_get_contents(__DIR__.'/../fixtures/resources.mo'), file_get_contents($tempDir.'/messages.en.mo'));
28+
$this->assertFileEquals(__DIR__.'/../fixtures/resources.mo', $tempDir.'/messages.en.mo');
2929

3030
unlink($tempDir.'/messages.en.mo');
3131
}

Tests/Dumper/PhpFileDumperTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public function testDump()
2626
$dumper = new PhpFileDumper();
2727
$dumper->dump($catalogue, array('path' => $tempDir));
2828

29-
$this->assertEquals(file_get_contents(__DIR__.'/../fixtures/resources.php'), file_get_contents($tempDir.'/messages.en.php'));
29+
$this->assertFileEquals(__DIR__.'/../fixtures/resources.php', $tempDir.'/messages.en.php');
3030

3131
unlink($tempDir.'/messages.en.php');
3232
}

Tests/Dumper/PoFileDumperTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public function testDump()
2525
$tempDir = sys_get_temp_dir();
2626
$dumper = new PoFileDumper();
2727
$dumper->dump($catalogue, array('path' => $tempDir));
28-
$this->assertEquals(file_get_contents(__DIR__.'/../fixtures/resources.po'), file_get_contents($tempDir.'/messages.en.po'));
28+
$this->assertFileEquals(__DIR__.'/../fixtures/resources.po', $tempDir.'/messages.en.po');
2929

3030
unlink($tempDir.'/messages.en.po');
3131
}

Tests/Dumper/QtFileDumperTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public function testDump()
2626
$dumper = new QtFileDumper();
2727
$dumper->dump($catalogue, array('path' => $tempDir));
2828

29-
$this->assertEquals(file_get_contents(__DIR__.'/../fixtures/resources.ts'), file_get_contents($tempDir.'/resources.en.ts'));
29+
$this->assertFileEquals(__DIR__.'/../fixtures/resources.ts', $tempDir.'/resources.en.ts');
3030

3131
unlink($tempDir.'/resources.en.ts');
3232
}

Tests/Dumper/XliffFileDumperTest.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,7 @@ public function testDump()
3232
$dumper = new XliffFileDumper();
3333
$dumper->dump($catalogue, array('path' => $tempDir, 'default_locale' => 'fr_FR'));
3434

35-
$this->assertEquals(
36-
file_get_contents(__DIR__.'/../fixtures/resources-clean.xlf'),
37-
file_get_contents($tempDir.'/messages.en_US.xlf')
38-
);
35+
$this->assertFileEquals(__DIR__.'/../fixtures/resources-clean.xlf', $tempDir.'/messages.en_US.xlf');
3936

4037
unlink($tempDir.'/messages.en_US.xlf');
4138
}

Tests/Dumper/YamlFileDumperTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public function testDump()
2626
$dumper = new YamlFileDumper();
2727
$dumper->dump($catalogue, array('path' => $tempDir));
2828

29-
$this->assertEquals(file_get_contents(__DIR__.'/../fixtures/resources.yml'), file_get_contents($tempDir.'/messages.en.yml'));
29+
$this->assertFileEquals(__DIR__.'/../fixtures/resources.yml', $tempDir.'/messages.en.yml');
3030

3131
unlink($tempDir.'/messages.en.yml');
3232
}

0 commit comments

Comments
 (0)