Enable the fixer enforcing fully-qualified calls for compiler-optimized functions

stof · stof · commit 44383e4b7b6b · 2018-07-24T12:05:38.000+02:00
diff --git a/Catalogue/AbstractOperation.php b/Catalogue/AbstractOperation.php
@@ -89,7 +89,7 @@ public function getDomains()
      */
     public function getMessages($domain)
     {
-        if (!in_array($domain, $this->getDomains())) {
+        if (!\in_array($domain, $this->getDomains())) {
             throw new \InvalidArgumentException(sprintf('Invalid domain: %s.', $domain));
         }
 
@@ -105,7 +105,7 @@ public function getMessages($domain)
      */
     public function getNewMessages($domain)
     {
-        if (!in_array($domain, $this->getDomains())) {
+        if (!\in_array($domain, $this->getDomains())) {
             throw new \InvalidArgumentException(sprintf('Invalid domain: %s.', $domain));
         }
 
@@ -121,7 +121,7 @@ public function getNewMessages($domain)
      */
     public function getObsoleteMessages($domain)
     {
-        if (!in_array($domain, $this->getDomains())) {
+        if (!\in_array($domain, $this->getDomains())) {
             throw new \InvalidArgumentException(sprintf('Invalid domain: %s.', $domain));
         }
 
diff --git a/DataCollector/TranslationDataCollector.php b/DataCollector/TranslationDataCollector.php
@@ -135,7 +135,7 @@ private function sanitizeString($string, $length = 80)
             if (mb_strlen($string, $encoding) > $length) {
                 return mb_substr($string, 0, $length - 3, $encoding).'...';
             }
-        } elseif (strlen($string) > $length) {
+        } elseif (\strlen($string) > $length) {
             return substr($string, 0, $length - 3).'...';
         }
 
diff --git a/DataCollectorTranslator.php b/DataCollectorTranslator.php
@@ -33,7 +33,7 @@ class DataCollectorTranslator implements TranslatorInterface, TranslatorBagInter
     public function __construct(TranslatorInterface $translator)
     {
         if (!$translator instanceof TranslatorBagInterface) {
-            throw new \InvalidArgumentException(sprintf('The Translator "%s" must implement TranslatorInterface and TranslatorBagInterface.', get_class($translator)));
+            throw new \InvalidArgumentException(sprintf('The Translator "%s" must implement TranslatorInterface and TranslatorBagInterface.', \get_class($translator)));
         }
 
         $this->translator = $translator;
@@ -104,7 +104,7 @@ public function getFallbackLocales()
      */
     public function __call($method, $args)
     {
-        return call_user_func_array(array($this->translator, $method), $args);
+        return \call_user_func_array(array($this->translator, $method), $args);
     }
 
     /**
diff --git a/Dumper/FileDumper.php b/Dumper/FileDumper.php
@@ -76,7 +76,7 @@ public function dump(MessageCatalogue $messages, $options = array())
                     copy($fullpath, $fullpath.'~');
                 }
             } else {
-                $directory = dirname($fullpath);
+                $directory = \dirname($fullpath);
                 if (!file_exists($directory) && !@mkdir($directory, 0777, true)) {
                     throw new \RuntimeException(sprintf('Unable to create directory "%s".', $directory));
                 }
diff --git a/Dumper/IcuResFileDumper.php b/Dumper/IcuResFileDumper.php
@@ -43,7 +43,7 @@ public function formatCatalogue(MessageCatalogue $messages, $domain, array $opti
         $data = $indexes = $resources = '';
 
         foreach ($messages->all($domain) as $source => $target) {
-            $indexes .= pack('v', strlen($data) + 28);
+            $indexes .= pack('v', \strlen($data) + 28);
             $data .= $source."\0";
         }
 
@@ -54,15 +54,15 @@ public function formatCatalogue(MessageCatalogue $messages, $domain, array $opti
         foreach ($messages->all($domain) as $source => $target) {
             $resources .= pack('V', $this->getPosition($data));
 
-            $data .= pack('V', strlen($target))
+            $data .= pack('V', \strlen($target))
                 .mb_convert_encoding($target."\0", 'UTF-16LE', 'UTF-8')
                 .$this->writePadding($data)
                   ;
         }
 
         $resOffset = $this->getPosition($data);
 
-        $data .= pack('v', count($messages->all($domain)))
+        $data .= pack('v', \count($messages->all($domain)))
             .$indexes
             .$this->writePadding($data)
             .$resources
@@ -76,7 +76,7 @@ public function formatCatalogue(MessageCatalogue $messages, $domain, array $opti
             $keyTop,                        // Index keys top
             $bundleTop,                     // Index resources top
             $bundleTop,                     // Index bundle top
-            count($messages->all($domain)), // Index max table length
+            \count($messages->all($domain)), // Index max table length
             0                               // Index attributes
         );
 
@@ -94,7 +94,7 @@ public function formatCatalogue(MessageCatalogue $messages, $domain, array $opti
 
     private function writePadding($data)
     {
-        $padding = strlen($data) % 4;
+        $padding = \strlen($data) % 4;
 
         if ($padding) {
             return str_repeat("\xAA", 4 - $padding);
@@ -103,7 +103,7 @@ private function writePadding($data)
 
     private function getPosition($data)
     {
-        return (strlen($data) + 28) / 4;
+        return (\strlen($data) + 28) / 4;
     }
 
     /**
diff --git a/Dumper/JsonFileDumper.php b/Dumper/JsonFileDumper.php
@@ -38,7 +38,7 @@ public function formatCatalogue(MessageCatalogue $messages, $domain, array $opti
         if (isset($options['json_encoding'])) {
             $flags = $options['json_encoding'];
         } else {
-            $flags = defined('JSON_PRETTY_PRINT') ? JSON_PRETTY_PRINT : 0;
+            $flags = \defined('JSON_PRETTY_PRINT') ? JSON_PRETTY_PRINT : 0;
         }
 
         return json_encode($messages->all($domain), $flags);
diff --git a/Dumper/MoFileDumper.php b/Dumper/MoFileDumper.php
@@ -57,7 +57,7 @@ public function formatCatalogue(MessageCatalogue $messages, $domain, array $opti
             'offsetHashes' => MoFileLoader::MO_HEADER_SIZE + (16 * $size),
         );
 
-        $sourcesSize = strlen($sources);
+        $sourcesSize = \strlen($sources);
         $sourcesStart = $header['offsetHashes'] + 1;
 
         foreach ($offsets as $offset) {
diff --git a/Dumper/XliffFileDumper.php b/Dumper/XliffFileDumper.php
@@ -188,6 +188,6 @@ private function dumpXliff2($defaultLocale, MessageCatalogue $messages, $domain,
      */
     private function hasMetadataArrayInfo($key, $metadata = null)
     {
-        return null !== $metadata && array_key_exists($key, $metadata) && ($metadata[$key] instanceof \Traversable || is_array($metadata[$key]));
+        return null !== $metadata && array_key_exists($key, $metadata) && ($metadata[$key] instanceof \Traversable || \is_array($metadata[$key]));
     }
 }
diff --git a/Extractor/AbstractFileExtractor.php b/Extractor/AbstractFileExtractor.php
@@ -25,7 +25,7 @@ abstract class AbstractFileExtractor
      */
     protected function extractFiles($resource)
     {
-        if (is_array($resource) || $resource instanceof \Traversable) {
+        if (\is_array($resource) || $resource instanceof \Traversable) {
             $files = array();
             foreach ($resource as $file) {
                 if ($this->canBeExtracted($file)) {
diff --git a/Loader/ArrayLoader.php b/Loader/ArrayLoader.php
@@ -52,7 +52,7 @@ private function flatten(array &$messages, array $subnode = null, $path = null)
             $subnode = &$messages;
         }
         foreach ($subnode as $key => $value) {
-            if (is_array($value)) {
+            if (\is_array($value)) {
                 $nodePath = $path ? $path.'.'.$key : $key;
                 $this->flatten($messages, $value, $nodePath);
                 if (null === $path) {
diff --git a/Loader/CsvFileLoader.php b/Loader/CsvFileLoader.php
@@ -41,7 +41,7 @@ protected function loadResource($resource)
         $file->setCsvControl($this->delimiter, $this->enclosure, $this->escape);
 
         foreach ($file as $data) {
-            if ('#' !== substr($data[0], 0, 1) && isset($data[1]) && 2 === count($data)) {
+            if ('#' !== substr($data[0], 0, 1) && isset($data[1]) && 2 === \count($data)) {
                 $messages[$data[0]] = $data[1];
             }
         }
diff --git a/Loader/FileLoader.php b/Loader/FileLoader.php
@@ -41,7 +41,7 @@ public function load($resource, $locale, $domain = 'messages')
         }
 
         // not an array
-        if (!is_array($messages)) {
+        if (!\is_array($messages)) {
             throw new InvalidResourceException(sprintf('Unable to load file "%s".', $resource));
         }
 
diff --git a/Loader/MoFileLoader.php b/Loader/MoFileLoader.php
@@ -111,7 +111,7 @@ protected function loadResource($resource)
             $ids = array('singular' => $singularId, 'plural' => $pluralId);
             $item = compact('ids', 'translated');
 
-            if (is_array($item['translated'])) {
+            if (\is_array($item['translated'])) {
                 $messages[$item['ids']['singular']] = stripcslashes($item['translated'][0]);
                 if (isset($item['ids']['plural'])) {
                     $plurals = array();
diff --git a/Loader/PoFileLoader.php b/Loader/PoFileLoader.php
@@ -78,7 +78,7 @@ protected function loadResource($resource)
 
             if ('' === $line) {
                 // Whitespace indicated current item is done
-                if (!in_array('fuzzy', $flags)) {
+                if (!\in_array('fuzzy', $flags)) {
                     $this->addMessage($messages, $item);
                 }
                 $item = $defaults;
@@ -96,7 +96,7 @@ protected function loadResource($resource)
             } elseif ('"' === $line[0]) {
                 $continues = isset($item['translated']) ? 'translated' : 'ids';
 
-                if (is_array($item[$continues])) {
+                if (\is_array($item[$continues])) {
                     end($item[$continues]);
                     $item[$continues][key($item[$continues])] .= substr($line, 1, -1);
                 } else {
@@ -110,7 +110,7 @@ protected function loadResource($resource)
             }
         }
         // save last item
-        if (!in_array('fuzzy', $flags)) {
+        if (!\in_array('fuzzy', $flags)) {
             $this->addMessage($messages, $item);
         }
         fclose($stream);
@@ -126,7 +126,7 @@ protected function loadResource($resource)
      */
     private function addMessage(array &$messages, array $item)
     {
-        if (is_array($item['translated'])) {
+        if (\is_array($item['translated'])) {
             $messages[stripcslashes($item['ids']['singular'])] = stripcslashes($item['translated'][0]);
             if (isset($item['ids']['plural'])) {
                 $plurals = $item['translated'];
diff --git a/LoggingTranslator.php b/LoggingTranslator.php
@@ -32,7 +32,7 @@ class LoggingTranslator implements TranslatorInterface, TranslatorBagInterface
     public function __construct(TranslatorInterface $translator, LoggerInterface $logger)
     {
         if (!$translator instanceof TranslatorBagInterface) {
-            throw new \InvalidArgumentException(sprintf('The Translator "%s" must implement TranslatorInterface and TranslatorBagInterface.', get_class($translator)));
+            throw new \InvalidArgumentException(sprintf('The Translator "%s" must implement TranslatorInterface and TranslatorBagInterface.', \get_class($translator)));
         }
 
         $this->translator = $translator;
@@ -104,7 +104,7 @@ public function getFallbackLocales()
      */
     public function __call($method, $args)
     {
-        return call_user_func_array(array($this->translator, $method), $args);
+        return \call_user_func_array(array($this->translator, $method), $args);
     }
 
     /**
diff --git a/MessageSelector.php b/MessageSelector.php
@@ -74,7 +74,7 @@ public function choose($message, $number, $locale)
         if (!isset($standardRules[$position])) {
             // when there's exactly one rule given, and that rule is a standard
             // rule, use this rule
-            if (1 === count($parts) && isset($standardRules[0])) {
+            if (1 === \count($parts) && isset($standardRules[0])) {
                 return $standardRules[0];
             }
 
diff --git a/PluralizationRules.php b/PluralizationRules.php
@@ -35,14 +35,14 @@ public static function get($number, $locale)
             $locale = 'xbr';
         }
 
-        if (strlen($locale) > 3) {
-            $locale = substr($locale, 0, -strlen(strrchr($locale, '_')));
+        if (\strlen($locale) > 3) {
+            $locale = substr($locale, 0, -\strlen(strrchr($locale, '_')));
         }
 
         if (isset(self::$rules[$locale])) {
-            $return = call_user_func(self::$rules[$locale], $number);
+            $return = \call_user_func(self::$rules[$locale], $number);
 
-            if (!is_int($return) || $return < 0) {
+            if (!\is_int($return) || $return < 0) {
                 return 0;
             }
 
@@ -203,11 +203,11 @@ public static function set($rule, $locale)
             $locale = 'xbr';
         }
 
-        if (strlen($locale) > 3) {
-            $locale = substr($locale, 0, -strlen(strrchr($locale, '_')));
+        if (\strlen($locale) > 3) {
+            $locale = substr($locale, 0, -\strlen(strrchr($locale, '_')));
         }
 
-        if (!is_callable($rule)) {
+        if (!\is_callable($rule)) {
             throw new \LogicException('The given rule can not be called');
         }
 
diff --git a/Tests/Loader/LocalizedTestCase.php b/Tests/Loader/LocalizedTestCase.php
@@ -17,7 +17,7 @@ abstract class LocalizedTestCase extends TestCase
 {
     protected function setUp()
     {
-        if (!extension_loaded('intl')) {
+        if (!\extension_loaded('intl')) {
             $this->markTestSkipped('Extension intl is required.');
         }
     }
diff --git a/Tests/PluralizationRulesTest.php b/Tests/PluralizationRulesTest.php
@@ -100,9 +100,9 @@ protected function validateMatrix($nplural, $matrix, $expectSuccess = true)
         foreach ($matrix as $langCode => $data) {
             $indexes = array_flip($data);
             if ($expectSuccess) {
-                $this->assertEquals($nplural, count($indexes), "Langcode '$langCode' has '$nplural' plural forms.");
+                $this->assertEquals($nplural, \count($indexes), "Langcode '$langCode' has '$nplural' plural forms.");
             } else {
-                $this->assertNotEquals((int) $nplural, count($indexes), "Langcode '$langCode' has '$nplural' plural forms.");
+                $this->assertNotEquals((int) $nplural, \count($indexes), "Langcode '$langCode' has '$nplural' plural forms.");
             }
         }
     }
diff --git a/Tests/TranslatorTest.php b/Tests/TranslatorTest.php
@@ -538,7 +538,7 @@ public function testLegacyGetMessages($resources, $locale, $expected)
     {
         $locales = array_keys($resources);
         $_locale = null !== $locale ? $locale : reset($locales);
-        $locales = array_slice($locales, 0, array_search($_locale, $locales));
+        $locales = \array_slice($locales, 0, array_search($_locale, $locales));
 
         $translator = new Translator($_locale, new MessageSelector());
         $translator->setFallbackLocales(array_reverse($locales));
diff --git a/Translator.php b/Translator.php
@@ -119,7 +119,7 @@ public function addResource($format, $resource, $locale, $domain = null)
 
         $this->resources[$locale][] = array($format, $resource, $domain);
 
-        if (in_array($locale, $this->fallbackLocales)) {
+        if (\in_array($locale, $this->fallbackLocales)) {
             $this->catalogues = array();
         } else {
             unset($this->catalogues[$locale]);
@@ -156,7 +156,7 @@ public function setFallbackLocale($locales)
     {
         @trigger_error('The '.__METHOD__.' method is deprecated since Symfony 2.3 and will be removed in 3.0. Use the setFallbackLocales() method instead.', E_USER_DEPRECATED);
 
-        $this->setFallbackLocales(is_array($locales) ? $locales : array($locales));
+        $this->setFallbackLocales(\is_array($locales) ? $locales : array($locales));
     }
 
     /**
@@ -439,7 +439,7 @@ protected function computeFallbackLocales($locale)
         }
 
         if (false !== strrchr($locale, '_')) {
-            array_unshift($locales, substr($locale, 0, -strlen(strrchr($locale, '_'))));
+            array_unshift($locales, substr($locale, 0, -\strlen(strrchr($locale, '_'))));
         }
 
         return array_unique($locales);
diff --git a/Util/ArrayConverter.php b/Util/ArrayConverter.php
@@ -54,22 +54,22 @@ private static function &getElementByPath(array &$tree, array $parts)
         $parentOfElem = null;
 
         foreach ($parts as $i => $part) {
-            if (isset($elem[$part]) && is_string($elem[$part])) {
+            if (isset($elem[$part]) && \is_string($elem[$part])) {
                 /* Process next case:
                  *    'foo': 'test1',
                  *    'foo.bar': 'test2'
                  *
                  * $tree['foo'] was string before we found array {bar: test2}.
                  *  Treat new element as string too, e.g. add $tree['foo.bar'] = 'test2';
                  */
-                $elem = &$elem[implode('.', array_slice($parts, $i))];
+                $elem = &$elem[implode('.', \array_slice($parts, $i))];
                 break;
             }
             $parentOfElem = &$elem;
             $elem = &$elem[$part];
         }
 
-        if (is_array($elem) && count($elem) > 0 && $parentOfElem) {
+        if (\is_array($elem) && \count($elem) > 0 && $parentOfElem) {
             /* Process next case:
              *    'foo.bar': 'test1'
              *    'foo': 'test2'
@@ -89,7 +89,7 @@ private static function cancelExpand(array &$tree, $prefix, array $node)
         $prefix .= '.';
 
         foreach ($node as $id => $value) {
-            if (is_string($value)) {
+            if (\is_string($value)) {
                 $tree[$prefix.$id] = $value;
             } else {
                 self::cancelExpand($tree, $prefix.$id, $value);

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ public function getDomains()`
`89`	`89`	`*/`
`90`	`90`	`public function getMessages($domain)`
`91`	`91`	`{`
`92`		`- if (!in_array($domain, $this->getDomains())) {`
	`92`	`+ if (!\in_array($domain, $this->getDomains())) {`
`93`	`93`	`throw new \InvalidArgumentException(sprintf('Invalid domain: %s.', $domain));`
`94`	`94`	`}`
`95`	`95`
`@@ -105,7 +105,7 @@ public function getMessages($domain)`
`105`	`105`	`*/`
`106`	`106`	`public function getNewMessages($domain)`
`107`	`107`	`{`
`108`		`- if (!in_array($domain, $this->getDomains())) {`
	`108`	`+ if (!\in_array($domain, $this->getDomains())) {`
`109`	`109`	`throw new \InvalidArgumentException(sprintf('Invalid domain: %s.', $domain));`
`110`	`110`	`}`
`111`	`111`
`@@ -121,7 +121,7 @@ public function getNewMessages($domain)`
`121`	`121`	`*/`
`122`	`122`	`public function getObsoleteMessages($domain)`
`123`	`123`	`{`
`124`		`- if (!in_array($domain, $this->getDomains())) {`
	`124`	`+ if (!\in_array($domain, $this->getDomains())) {`
`125`	`125`	`throw new \InvalidArgumentException(sprintf('Invalid domain: %s.', $domain));`
`126`	`126`	`}`
`127`	`127`
Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ private function sanitizeString($string, $length = 80)`
`135`	`135`	`if (mb_strlen($string, $encoding) > $length) {`
`136`	`136`	`return mb_substr($string, 0, $length - 3, $encoding).'...';`
`137`	`137`	`}`
`138`		`- } elseif (strlen($string) > $length) {`
	`138`	`+ } elseif (\strlen($string) > $length) {`
`139`	`139`	`return substr($string, 0, $length - 3).'...';`
`140`	`140`	`}`
`141`	`141`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ class DataCollectorTranslator implements TranslatorInterface, TranslatorBagInter`
`33`	`33`	`public function __construct(TranslatorInterface $translator)`
`34`	`34`	`{`
`35`	`35`	`if (!$translator instanceof TranslatorBagInterface) {`
`36`		`- throw new \InvalidArgumentException(sprintf('The Translator "%s" must implement TranslatorInterface and TranslatorBagInterface.', get_class($translator)));`
	`36`	`+ throw new \InvalidArgumentException(sprintf('The Translator "%s" must implement TranslatorInterface and TranslatorBagInterface.', \get_class($translator)));`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`$this->translator = $translator;`
`@@ -104,7 +104,7 @@ public function getFallbackLocales()`
`104`	`104`	`*/`
`105`	`105`	`public function __call($method, $args)`
`106`	`106`	`{`
`107`		`- return call_user_func_array(array($this->translator, $method), $args);`
	`107`	`+ return \call_user_func_array(array($this->translator, $method), $args);`
`108`	`108`	`}`
`109`	`109`
`110`	`110`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ public function dump(MessageCatalogue $messages, $options = array())`
`76`	`76`	`copy($fullpath, $fullpath.'~');`
`77`	`77`	`}`
`78`	`78`	`} else {`
`79`		`- $directory = dirname($fullpath);`
	`79`	`+ $directory = \dirname($fullpath);`
`80`	`80`	`if (!file_exists($directory) && !@mkdir($directory, 0777, true)) {`
`81`	`81`	`throw new \RuntimeException(sprintf('Unable to create directory "%s".', $directory));`
`82`	`82`	`}`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ public function formatCatalogue(MessageCatalogue $messages, $domain, array $opti`
`38`	`38`	`if (isset($options['json_encoding'])) {`
`39`	`39`	`$flags = $options['json_encoding'];`
`40`	`40`	`} else {`
`41`		`- $flags = defined('JSON_PRETTY_PRINT') ? JSON_PRETTY_PRINT : 0;`
	`41`	`+ $flags = \defined('JSON_PRETTY_PRINT') ? JSON_PRETTY_PRINT : 0;`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`return json_encode($messages->all($domain), $flags);`
Original file line number	Diff line number	Diff line change
`@@ -188,6 +188,6 @@ private function dumpXliff2($defaultLocale, MessageCatalogue $messages, $domain,`
`188`	`188`	`*/`
`189`	`189`	`private function hasMetadataArrayInfo($key, $metadata = null)`
`190`	`190`	`{`
`191`		`- return null !== $metadata && array_key_exists($key, $metadata) && ($metadata[$key] instanceof \Traversable \|\| is_array($metadata[$key]));`
	`191`	`+ return null !== $metadata && array_key_exists($key, $metadata) && ($metadata[$key] instanceof \Traversable \|\| \is_array($metadata[$key]));`
`192`	`192`	`}`
`193`	`193`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ abstract class AbstractFileExtractor`
`25`	`25`	`*/`
`26`	`26`	`protected function extractFiles($resource)`
`27`	`27`	`{`
`28`		`- if (is_array($resource) \|\| $resource instanceof \Traversable) {`
	`28`	`+ if (\is_array($resource) \|\| $resource instanceof \Traversable) {`
`29`	`29`	`$files = array();`
`30`	`30`	`foreach ($resource as $file) {`
`31`	`31`	`if ($this->canBeExtracted($file)) {`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ private function flatten(array &$messages, array $subnode = null, $path = null)`
`52`	`52`	`$subnode = &$messages;`
`53`	`53`	`}`
`54`	`54`	`foreach ($subnode as $key => $value) {`
`55`		`- if (is_array($value)) {`
	`55`	`+ if (\is_array($value)) {`
`56`	`56`	`$nodePath = $path ? $path.'.'.$key : $key;`
`57`	`57`	`$this->flatten($messages, $value, $nodePath);`
`58`	`58`	`if (null === $path) {`