Skip to content

Commit ddf9aa5

Browse files
committed
Merge branch '2.5' into 2.6
* 2.5: (24 commits) Fixing typo thanks to xabbuh Add missing comma in array Removed unneeded spaces Updated as per discussion Updated according to comment and changed to AppBundle Added configuration of the your_api_key_user_provider as user provider fixed typo (acme -> app) Fix typo: missing of Fix typo: missing space Fix typo: Fabien => World Adding reference link Quick proofread of the email cookbook Remove horizontal scrollbar Fix typos Fix typo, remove horizontal scrollbar Set twig service as private added Kévin as a merger for the Serializer component Fix typo: looks => look Align methods in YAML example Move annotations example to front ...
2 parents d1103a8 + 585644b commit ddf9aa5

File tree

18 files changed

+177
-106
lines changed

18 files changed

+177
-106
lines changed

best_practices/business-logic.rst

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,9 +140,12 @@ the class namespace as a parameter:
140140
# app/config/services.yml
141141
142142
# service definition with class namespace as parameter
143+
parameters:
144+
slugger.class: AppBundle\Utils\Slugger
145+
143146
services:
144147
app.slugger:
145-
class: AppBundle\Utils\Slugger
148+
class: "%slugger.class%"
146149
147150
This practice is cumbersome and completely unnecessary for your own services:
148151

best_practices/configuration.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ and security credentials) and different environments (development, production).
66
That's why Symfony recommends that you split the application configuration into
77
three parts.
88

9+
.. _config-parameters.yml:
10+
911
Infrastructure-Related Configuration
1012
------------------------------------
1113

components/class_loader/class_map_generator.rst

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ Generating a Class Map
4545
----------------------
4646

4747
To generate the class map, simply pass the root directory of your class files
48-
to the :method:`Symfony\\Component\\ClassLoader\\ClassMapGenerator::createMap``
48+
to the :method:`Symfony\\Component\\ClassLoader\\ClassMapGenerator::createMap`
4949
method::
5050

5151
use Symfony\Component\ClassLoader\ClassMapGenerator;
@@ -115,7 +115,10 @@ the same as in the example above)::
115115

116116
use Symfony\Component\ClassLoader\ClassMapGenerator;
117117

118-
ClassMapGenerator::dump(array(__DIR__.'/library/bar', __DIR__.'/library/foo'), __DIR__.'/class_map.php');
118+
ClassMapGenerator::dump(
119+
array(__DIR__.'/library/bar', __DIR__.'/library/foo'),
120+
__DIR__.'/class_map.php'
121+
);
119122

120123
.. _`PSR-0`: http://www.php-fig.org/psr/psr-0
121124
.. _`PSR-4`: http://www.php-fig.org/psr/psr-4

components/config/definition.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -500,7 +500,7 @@ By changing a string value into an associative array with ``name`` as the key::
500500
->arrayNode('connection')
501501
->beforeNormalization()
502502
->ifString()
503-
->then(function($v) { return array('name'=> $v); })
503+
->then(function ($v) { return array('name' => $v); })
504504
->end()
505505
->children()
506506
->scalarNode('name')->isRequired()

components/console/changing_default_command.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ This will print the following to the command line:
5555

5656
.. code-block:: text
5757
58-
Hello Fabien
58+
Hello World
5959
6060
.. tip::
6161

components/console/helpers/dialoghelper.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ this set the seventh argument to ``true``::
230230
true // enable multiselect
231231
);
232232

233-
$selectedColors = array_map(function($c) use ($colors) {
233+
$selectedColors = array_map(function ($c) use ($colors) {
234234
return $colors[$c];
235235
}, $selected);
236236

components/console/helpers/questionhelper.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ option is the default one.
9393
If the user enters an invalid string, an error message is shown and the user
9494
is asked to provide the answer another time, until they enter a valid string
9595
or reach the maximum number of attempts. The default value for the maximum number
96-
of attempts is ``null``, which means infinite number attempts. You can define
96+
of attempts is ``null``, which means infinite number of attempts. You can define
9797
your own error message using
9898
:method:`Symfony\\Component\\Console\\Question\\ChoiceQuestion::setErrorMessage`.
9999

components/console/introduction.rst

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -459,9 +459,11 @@ method::
459459

460460
$command = $application->find('demo:greet');
461461
$commandTester = new CommandTester($command);
462-
$commandTester->execute(
463-
array('command' => $command->getName(), 'name' => 'Fabien', '--iterations' => 5)
464-
);
462+
$commandTester->execute(array(
463+
'command' => $command->getName(),
464+
'name' => 'Fabien',
465+
'--iterations' => 5,
466+
));
465467

466468
$this->assertRegExp('/Fabien/', $commandTester->getDisplay());
467469
}

components/expression_language/syntax.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ For example::
259259
$inGroup = $language->evaluate(
260260
'user.group in ["human_resources", "marketing"]',
261261
array(
262-
'user' => $user
262+
'user' => $user,
263263
)
264264
);
265265

contributing/code/core_team.rst

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,10 @@ Active Core Members
5757
* **Christophe Coevoet** (:merger:`stof`) can merge into the BrowserKit_,
5858
Config_, Console_, DependencyInjection_, DomCrawler_, EventDispatcher_,
5959
HttpFoundation_, HttpKernel_, Serializer_, Stopwatch_, DoctrineBridge_,
60-
MonologBridge_, and TwigBridge_ components.
60+
MonologBridge_, and TwigBridge_ components;
61+
62+
* **Kévin Dunglas** (:merger:`dunglas`) can merge into the Serializer_
63+
component.
6164

6265
* **Deciders** (``@symfony/deciders`` on GitHub):
6366

0 commit comments

Comments
 (0)