Merge branch '4.0' into 4.1

* 4.0:
  Remove useless $request
  Improve the docs about custom form theme config
  Use callable classes for custom Monolog processors
  Mentioned the audit_trail workflow option
  Problem with transactions
  Update custom_password_authenticator.rst
  Updated one screencast URL for Symfony 4
  Update dependency_injection.rst
  Update http_kernel_httpkernel_class.rst
  Remove example of register a service where its id match to its class

Author: javiereguiluz

create_framework/dependency_injection.rst

@@ -121,7 +121,7 @@ Create a new file to host the dependency injection container configuration::
         ->setArguments(array('UTF-8'))
     ;
     $containerBuilder->register('listener.exception', HttpKernel\EventListener\ExceptionListener::class)
-        ->setArguments(array('Calendar\Controller\ErrorController::exceptionAction'))
+        ->setArguments(array('Calendar\Controller\ErrorController::exception'))
     ;
     $containerBuilder->register('dispatcher', EventDispatcher\EventDispatcher::class)
         ->addMethodCall('addSubscriber', array(new Reference('listener.router')))

create_framework/http_kernel_httpkernel_class.rst

@@ -82,7 +82,7 @@ display. It can take any valid controller as an exception handler, so you can
 create an ErrorController class instead of using a Closure::
 
     $listener = new HttpKernel\EventListener\ExceptionListener(
-        'Calendar\Controller\ErrorController::exceptionAction'
+        'Calendar\Controller\ErrorController::exception'
     );
     $dispatcher->addSubscriber($listener);
 

doctrine.rst

@@ -402,7 +402,7 @@ Take a look at the previous example in more detail:
     is thrown. See `Transactions and Concurrency`_.
 
 Whether you're creating or updating objects, the workflow is always the same: Doctrine
-is smart enough to know if it should INSERT of UPDATE your entity.
+is smart enough to know if it should INSERT or UPDATE your entity.
 
 Fetching Objects from the Database
 ----------------------------------

doctrine/pdo_session_storage.rst

@@ -29,6 +29,8 @@ To use it, first register a new handler service:
                     # If you're using Doctrine & want to re-use that connection, then:
                     # comment-out the above 2 lines and uncomment the line below
                     # - !service { class: PDO, factory: 'database_connection:getWrappedConnection' }
+                    # If you get transaction issues (e.g. after login) uncomment the line below
+                    # - { lock_mode: 1 }
 
     .. code-block:: xml
 

form/form_themes.rst

@@ -182,6 +182,7 @@ file:
         # config/packages/twig.yaml
         twig:
             form_themes:
+                - '...'
                 - 'form/fields.html.twig'
             # ...
 
@@ -197,6 +198,7 @@ file:
                 http://symfony.com/schema/dic/twig http://symfony.com/schema/dic/twig/twig-1.0.xsd">
 
             <twig:config>
+                <twig:theme>...</twig:theme>
                 <twig:theme>form/fields.html.twig</twig:theme>
                 <!-- ... -->
             </twig:config>
@@ -207,11 +209,17 @@ file:
         // config/packages/twig.php
         $container->loadFromExtension('twig', array(
             'form_themes' => array(
+                '...',
                 'form/fields.html.twig',
             ),
             // ...
         ));
 
+.. note::
+
+    Add your custom theme at the end of the ``form_themes`` list because each
+    theme overrides all the previous themes.
+
 Any blocks inside the ``fields.html.twig`` template are now used globally
 to define form output.
 

logging/processors.rst

@@ -30,7 +30,7 @@ using a processor::
             $this->session = $session;
         }
 
-        public function processRecord(array $record)
+        public function __invoke(array $record)
         {
             if (!$this->session->isStarted()) {
                 return $record;
@@ -62,7 +62,7 @@ information:
 
             App\Logger\SessionRequestProcessor:
                 tags:
-                    - { name: monolog.processor, method: processRecord }
+                    - { name: monolog.processor }
 
     .. code-block:: xml
 
@@ -84,7 +84,7 @@ information:
                 </service>
 
                 <service id="App\Logger\SessionRequestProcessor">
-                    <tag name="monolog.processor" method="processRecord" />
+                    <tag name="monolog.processor" />
                 </service>
             </services>
         </container>
@@ -173,7 +173,7 @@ the ``monolog.processor`` tag:
         services:
             App\Logger\SessionRequestProcessor:
                 tags:
-                    - { name: monolog.processor, method: processRecord, handler: main }
+                    - { name: monolog.processor, handler: main }
 
     .. code-block:: xml
 
@@ -189,7 +189,7 @@ the ``monolog.processor`` tag:
 
             <services>
                 <service id="App\Logger\SessionRequestProcessor">
-                    <tag name="monolog.processor" method="processRecord" handler="main" />
+                    <tag name="monolog.processor" handler="main" />
                 </service>
             </services>
         </container>
@@ -201,7 +201,7 @@ the ``monolog.processor`` tag:
         // ...
         $container
             ->register(SessionRequestProcessor::class)
-            ->addTag('monolog.processor', array('method' => 'processRecord', 'handler' => 'main'));
+            ->addTag('monolog.processor', array('handler' => 'main'));
 
 Registering Processors per Channel
 ----------------------------------
@@ -217,7 +217,7 @@ the ``monolog.processor`` tag:
         services:
             App\Logger\SessionRequestProcessor:
                 tags:
-                    - { name: monolog.processor, method: processRecord, channel: main }
+                    - { name: monolog.processor, channel: main }
 
     .. code-block:: xml
 
@@ -233,7 +233,7 @@ the ``monolog.processor`` tag:
 
             <services>
                 <service id="App\Logger\SessionRequestProcessor">
-                    <tag name="monolog.processor" method="processRecord" channel="main" />
+                    <tag name="monolog.processor" channel="main" />
                 </service>
             </services>
         </container>
@@ -245,4 +245,4 @@ the ``monolog.processor`` tag:
         // ...
         $container
             ->register(SessionRequestProcessor::class)
-            ->addTag('monolog.processor', array('method' => 'processRecord', 'channel' => 'main'));
+            ->addTag('monolog.processor', array('channel' => 'main'));

security.rst

@@ -1348,4 +1348,4 @@ Other Security Related Topics
 .. _`frameworkextrabundle documentation`: https://symfony.com/doc/current/bundles/SensioFrameworkExtraBundle/index.html
 .. _`HWIOAuthBundle`: https://github.com/hwi/HWIOAuthBundle
 .. _`Symfony ACL bundle`: https://github.com/symfony/acl-bundle
-.. _`Symfony Security screencast series`: https://knpuniversity.com/screencast/symfony-security
+.. _`Symfony Security screencast series`: https://knpuniversity.com/screencast/symfony4-security

security/custom_password_authenticator.rst

@@ -63,7 +63,7 @@ the user::
                 if ('' === ($givenPassword = $token->getCredentials())) {
                     throw new BadCredentialsException('The given password cannot be empty.');
                 }
-                if (!$this->encoderFactory->getEncoder($user)->isPasswordValid($user->getPassword(), $givenPassword, $user->getSalt())) {
+                if (!$this->encoder->isPasswordValid($user->getPassword(), $givenPassword, $user->getSalt())) {
                     throw new BadCredentialsException('The given password is invalid.');
                 }
             }

security/form_login_setup.rst

@@ -91,15 +91,14 @@ configuration (``login``):
         // src/Controller/SecurityController.php
 
         // ...
-        use Symfony\Component\HttpFoundation\Request;
         use Symfony\Component\Routing\Annotation\Route;
 
         class SecurityController extends Controller
         {
             /**
              * @Route("/login", name="login")
              */
-            public function login(Request $request)
+            public function login()
             {
             }
         }
@@ -144,7 +143,7 @@ Great! Next, add the logic to ``login()`` that displays the login form::
     // src/Controller/SecurityController.php
     use Symfony\Component\Security\Http\Authentication\AuthenticationUtils;
 
-    public function login(Request $request, AuthenticationUtils $authenticationUtils)
+    public function login(AuthenticationUtils $authenticationUtils)
     {
         // get the login error if there is one
         $error = $authenticationUtils->getLastAuthenticationError();

service_container/definitions.rst

@@ -38,9 +38,6 @@ There are some helpful methods for working with the service definitions::
     // shortcut for the previous method
     $container->register('app.number_generator', \App\NumberGenerator::class);
 
-    // or create a service whose id matches its class
-    $container->register(\App\NumberGenerator::class);
-
 Working with a Definition
 -------------------------