Skip to content

Commit 8ce6323

Browse files
committed
minor #9972 Use the ReadTheDocs theme as the default Sphinx theme (javiereguiluz)
This PR was merged into the 2.8 branch. Discussion ---------- Use the ReadTheDocs theme as the default Sphinx theme I can't make our Sphinx theme work and I can't fix any of the issues reported about it. So let's stop wasting time on this and let's use the default Sphinx theme provided by ReadTheDocs (https://github.com/rtfd/sphinx_rtd_theme). It doesn't look like symfony.com, but it's beautiful, responsive and it works. In the future we can use it as the base to create our own theme. This is how it looks after running `cd _build && make html`: ![index](https://user-images.githubusercontent.com/73419/41984189-5b998672-7a30-11e8-83f5-f6fdeb437a44.png) ![page](https://user-images.githubusercontent.com/73419/41984192-5d43f606-7a30-11e8-9db4-366ac6fdafec.png) Commits ------- a5a2171 Use the ReadTheDocs theme as the default Sphinx theme
2 parents 6911173 + a5a2171 commit 8ce6323

30 files changed

+3176
-164
lines changed

_build/_theme/_templates/globaltoc.html

Lines changed: 0 additions & 19 deletions
This file was deleted.

_build/_theme/_templates/layout.html

Lines changed: 0 additions & 100 deletions
This file was deleted.

_build/_theme/_templates/localtoc.html

Lines changed: 0 additions & 6 deletions
This file was deleted.

_build/_theme/assets/css/app.css

Lines changed: 0 additions & 3 deletions
This file was deleted.

_build/_theme/assets/css/doc.css

Lines changed: 0 additions & 1 deletion
This file was deleted.

_build/_theme/assets/js/app.js

Lines changed: 0 additions & 24 deletions
This file was deleted.

_build/_theme/assets/js/doc.js

Lines changed: 0 additions & 1 deletion
This file was deleted.

_build/_theme/assets/js/manifest.js

Lines changed: 0 additions & 1 deletion
This file was deleted.

_build/_theme/_exts/symfonycom/sphinx/__init__.py renamed to _build/_themes/_exts/symfonycom/sphinx/__init__.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,17 +26,14 @@ def __init__(self, builder, *args, **kwds):
2626
self.highlightlinenothreshold = 0
2727

2828
def visit_literal(self, node):
29-
self.body.append(self.starttag(node, 'tt', '', CLASS='docutils literal'))
30-
self.body.append('<code>')
29+
self.body.append(self.starttag(node, 'code', '', CLASS='docutils literal notranslate'))
3130

3231
def depart_literal(self, node):
3332
self.body.append('</code>')
34-
self.body.append('</tt>')
3533

3634
def visit_admonition(self, node, name=''):
3735
self.body.append(self.starttag(node, 'div', CLASS=('admonition-wrapper')))
38-
self.body.append('<div class="' + name + '"></div>')
39-
self.body.append('<div class="admonition admonition-' + name + '">')
36+
self.body.append('<div class="admonition ' + name + '">')
4037
if name and name != 'seealso':
4138
node.insert(0, nodes.title(name, customadmonitionlabels[name]))
4239
self.set_first_last(node)
@@ -46,7 +43,6 @@ def depart_admonition(self, node=None):
4643

4744
def visit_sidebar(self, node):
4845
self.body.append(self.starttag(node, 'div', CLASS=('admonition-wrapper')))
49-
self.body.append('<div class="sidebar"></div>')
5046
self.body.append('<div class="admonition admonition-sidebar">')
5147
self.set_first_last(node)
5248
self.in_sidebar = 1

0 commit comments

Comments
 (0)