Skip to content

Commit 21b8d85

Browse files
committed
Merge branch '2.3' into 2.7
* 2.3: fix list items use valid XML in code block added Javier as a merger for the WebProfiler bundle use single quotes for YAML strings Typo in When Things Get More Advanced Remove phrase "in order" Remove excessive pluses replace EOL with EOM
2 parents 8966d40 + cdd858e commit 21b8d85

File tree

22 files changed

+56
-47
lines changed

22 files changed

+56
-47
lines changed

best_practices/controllers.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ also show a 404 page if no ``Post`` can be found.
157157
When Things Get More Advanced
158158
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
159159

160-
This works without any configuration because the wildcard name ``{id}`` matches
160+
The above example works without any configuration because the wildcard name ``{id}`` matches
161161
the name of the property on the entity. If this isn't true, or if you have
162162
even more complex logic, the easiest thing to do is just query for the entity
163163
manually. In our application, we have this situation in ``CommentController``:

book/service_container.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ parameter and uses it in the service definition.
235235

236236
.. code-block:: xml
237237
238-
<argument type="string">http://symfony.com/?foo=%%s&bar=%%d</argument>
238+
<argument type="string">http://symfony.com/?foo=%%s&amp;bar=%%d</argument>
239239
240240
The purpose of parameters is to feed information into services. Of course
241241
there was nothing wrong with defining the service without using any parameters.

components/dependency_injection/configurators.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ The service config for the above classes would look something like this:
145145
newsletter_manager:
146146
class: NewsletterManager
147147
calls:
148-
- [setMailer, ["@my_mailer"]]
148+
- [setMailer, ['@my_mailer']]
149149
configurator: ['@email_configurator', configure]
150150
151151
greeting_card_manager:

components/dependency_injection/factories.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ method in the previous example takes the ``templating`` service as an argument:
143143
class: NewsletterManager
144144
factory: ["@newsletter_manager.factory", createNewsletterManager]
145145
arguments:
146-
- "@templating"
146+
- '@templating'
147147
148148
.. code-block:: xml
149149

components/dependency_injection/introduction.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ config files:
243243
newsletter_manager:
244244
class: NewsletterManager
245245
calls:
246-
- [setMailer, ["@mailer"]]
246+
- [setMailer, ['@mailer']]
247247
248248
.. code-block:: xml
249249

components/dependency_injection/parameters.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ the parameter value in one place if needed.
155155
156156
.. code-block:: xml
157157
158-
<argument>http://symfony.com/?foo=%%s&bar=%%d</argument>
158+
<argument>http://symfony.com/?foo=%%s&amp;bar=%%d</argument>
159159
160160
.. code-block:: php
161161

components/dependency_injection/parentservices.rst

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -192,8 +192,8 @@ a parent for a service.
192192
mail_manager:
193193
abstract: true
194194
calls:
195-
- [setMailer, ["@my_mailer"]]
196-
- [setEmailFormatter, ["@my_email_formatter"]]
195+
- [setMailer, ['@my_mailer']]
196+
- [setEmailFormatter, ['@my_email_formatter']]
197197
198198
newsletter_manager:
199199
class: "NewsletterManager"
@@ -320,17 +320,17 @@ to the ``NewsletterManager`` class, the config would look like this:
320320
mail_manager:
321321
abstract: true
322322
calls:
323-
- [setMailer, ["@my_mailer"]]
324-
- [setEmailFormatter, ["@my_email_formatter"]]
323+
- [setMailer, ['@my_mailer']]
324+
- [setEmailFormatter, ['@my_email_formatter']]
325325
326326
newsletter_manager:
327-
class: "NewsletterManager"
327+
class: 'NewsletterManager'
328328
parent: mail_manager
329329
calls:
330-
- [setMailer, ["@my_alternative_mailer"]]
330+
- [setMailer, ['@my_alternative_mailer']]
331331
332332
greeting_card_manager:
333-
class: "GreetingCardManager"
333+
class: 'GreetingCardManager'
334334
parent: mail_manager
335335
336336
.. code-block:: xml

components/dependency_injection/types.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ that accepts the dependency::
126126
newsletter_manager:
127127
class: NewsletterManager
128128
calls:
129-
- [setMailer, ["@my_mailer"]]
129+
- [setMailer, ['@my_mailer']]
130130
131131
.. code-block:: xml
132132

contributing/code/core_team.rst

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,12 @@ Active Core Members
6565
* **Abdellatif AitBoudad** (`aitboudad`_) can merge into the Translation_
6666
component;
6767

68-
* **Jakub Zalas** (`jakzal`_) can merge into the DomCrawler_ component.
68+
* **Jakub Zalas** (`jakzal`_) can merge into the DomCrawler_ component;
6969

70-
* **Christian Flothmann** (`xabbuh`_) can merge into the Yaml_ component.
70+
* **Christian Flothmann** (`xabbuh`_) can merge into the Yaml_ component;
71+
72+
* **Javier Eguiluz** (`javiereguiluz`_) can merge into the WebProfilerBundle_
73+
bundle.
7174

7275
* **Deciders** (``@symfony/deciders`` on GitHub):
7376

@@ -177,6 +180,7 @@ discretion of the **Project Leader**.
177180
.. _Validator: https://github.com/symfony/validator
178181
.. _VarDumper: https://github.com/symfony/var-dumper
179182
.. _Yaml: https://github.com/symfony/yaml
183+
.. _WebProfilerBundle: https://github.com/symfony/web-profiler-bundle
180184
.. _`fabpot`: https://github.com/fabpot/
181185
.. _`webmozart`: https://github.com/webmozart/
182186
.. _`Tobion`: https://github.com/Tobion/
@@ -190,3 +194,4 @@ discretion of the **Project Leader**.
190194
.. _`weaverryan`: https://github.com/weaverryan/
191195
.. _`aitboudad`: https://github.com/aitboudad/
192196
.. _`xabbuh`: https://github.com/xabbuh/
197+
.. _`javiereguiluz`: https://github.com/javiereguiluz/

contributing/documentation/format.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,8 +194,8 @@ how the behavior has changed:
194194
Whenever a new minor version of Symfony is released (e.g. 2.4, 2.5, etc),
195195
a new branch of the documentation is created from the ``master`` branch.
196196
At this point, all the ``versionadded`` tags for Symfony versions that have
197-
reached end-of-life will be removed. For example, if Symfony 2.5 were released
198-
today, and 2.2 had recently reached its end-of-life, the 2.2 ``versionadded``
197+
reached end-of-maintenance will be removed. For example, if Symfony 2.5 were
198+
released today, and 2.2 had recently reached its end-of-life, the 2.2 ``versionadded``
199199
tags would be removed from the new ``2.5`` branch.
200200

201201
Testing Documentation

0 commit comments

Comments
 (0)