Skip to content

Commit d1180b6

Browse files
minor #16186 [2.7][tests] Use @requires annotation when possible (nicolas-grekas)
This PR was merged into the 2.7 branch. Discussion ---------- [2.7][tests] Use @requires annotation when possible | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- b028aea [tests] Use @requires annotation when possible
2 parents 8111add + 4da2a2e commit d1180b6

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

Tests/Normalizer/GetSetMethodNormalizerTest.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -207,11 +207,13 @@ public function testConstructorDenormalizeWithMissingOptionalArgument()
207207
$this->assertEquals(array(1, 2, 3), $obj->getBaz());
208208
}
209209

210+
/**
211+
* @see https://bugs.php.net/62715
212+
*
213+
* @requires PHP 5.3.17
214+
*/
210215
public function testConstructorDenormalizeWithOptionalDefaultArgument()
211216
{
212-
if (PHP_VERSION_ID <= 50316) {
213-
$this->markTestSkipped('See https://bugs.php.net/62715');
214-
}
215217
$obj = $this->normalizer->denormalize(
216218
array('bar' => 'test'),
217219
__NAMESPACE__.'\GetConstructorArgsWithDefaultValueDummy', 'any');

Tests/Normalizer/ObjectNormalizerTest.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -155,11 +155,13 @@ public function testConstructorDenormalizeWithMissingOptionalArgument()
155155
$this->assertEquals(array(1, 2, 3), $obj->getBaz());
156156
}
157157

158+
/**
159+
* @see https://bugs.php.net/62715
160+
*
161+
* @requires PHP 5.3.17
162+
*/
158163
public function testConstructorDenormalizeWithOptionalDefaultArgument()
159164
{
160-
if (PHP_VERSION_ID <= 50316) {
161-
$this->markTestSkipped('See https://bugs.php.net/62715');
162-
}
163165
$obj = $this->normalizer->denormalize(
164166
array('bar' => 'test'),
165167
__NAMESPACE__.'\ObjectConstructorArgsWithDefaultValueDummy', 'any');

0 commit comments

Comments
 (0)