Merge branch '5.4' into 6.0

* 5.4:
  [String] Add tests for AsciiSlugger
  [Serializer] Fix get accessor regex in AnnotationLoader
  [HttpKernel] Fix passing `null` to `\trim()` method in LoggerDataCollector
  [Translation] Crowdin provider throw Exception when status is 50x
  Always attempt to listen for notifications
  add missing changelog entry for the AtLeastOneOf constraint
  validate nested constraints only if they are in the same group

Author: fabpot

Mapping/Loader/AnnotationLoader.php

@@ -100,8 +100,7 @@ public function loadClassMetadata(ClassMetadataInterface $classMetadata): bool
                 continue;
             }
 
-            $getAccessor = preg_match('/^(get|)(.+)$/i', $method->name);
-            if ($getAccessor && 0 !== $method->getNumberOfRequiredParameters()) {
+            if (0 === stripos($method->name, 'get') && $method->getNumberOfRequiredParameters()) {
                 continue; /*  matches the BC behavior in `Symfony\Component\Serializer\Normalizer\ObjectNormalizer::extractAttributes` */
             }
 

Tests/Fixtures/Annotations/IgnoreDummyAdditionalGetter.php

@@ -20,4 +20,8 @@ public function getExtraValue(string $parameter)
     {
         return $parameter;
     }
+
+    public function setExtraValue2(string $parameter)
+    {
+    }
 }

Tests/Fixtures/Annotations/IgnoreDummyAdditionalGetterWithoutIgnoreAnnotations.php

@@ -15,4 +15,8 @@ public function getExtraValue(string $parameter)
     {
         return $parameter;
     }
+
+    public function setExtraValue2(string $parameter)
+    {
+    }
 }

Tests/Fixtures/Attributes/IgnoreDummyAdditionalGetter.php

@@ -18,4 +18,8 @@ public function getExtraValue(string $parameter)
     {
         return $parameter;
     }
+
+    public function setExtraValue2(string $parameter)
+    {
+    }
 }

Tests/Fixtures/Attributes/IgnoreDummyAdditionalGetterWithoutIgnoreAnnotations.php

@@ -15,4 +15,8 @@ public function getExtraValue(string $parameter)
     {
         return $parameter;
     }
+
+    public function setExtraValue2(string $parameter)
+    {
+    }
 }

Tests/Mapping/Loader/AnnotationLoaderTest.php

@@ -157,6 +157,7 @@ public function testIgnoreGetterWirhRequiredParameterIfIgnoreAnnotationIsUsed()
 
         $attributes = $classMetadata->getAttributesMetadata();
         self::assertArrayNotHasKey('extraValue', $attributes);
+        self::assertArrayHasKey('extraValue2', $attributes);
     }
 
     public function testIgnoreGetterWirhRequiredParameterIfIgnoreAnnotationIsNotUsed()
@@ -166,6 +167,7 @@ public function testIgnoreGetterWirhRequiredParameterIfIgnoreAnnotationIsNotUsed
 
         $attributes = $classMetadata->getAttributesMetadata();
         self::assertArrayNotHasKey('extraValue', $attributes);
+        self::assertArrayHasKey('extraValue2', $attributes);
     }
 
     abstract protected function createLoader(): AnnotationLoader;