Merge branch '2.8' into 3.0

* 2.8:
  [WebProfilerBundle] Don't inherit CSS text-transform property for the toolbar.
  Remove duplicate cursor property
  Increase the inlining YAML level for config:debug
  [Serializer] Minor: fix CS and PHPDoc
  [Form] fix tests
  [Serializer] Ensure that groups are strings
  [Debug] Tell that the extension is for PHP 5 only
  Static code analysis
  Update AnnotationDirectoryLoader.php
  added a test
  Escape the delimiter in Glob::toRegex
  [FrameworkBundle] Fix template location for PHP templates
  [FrameworkBundle] Add path verification to the template parsing test cases

Author: fabpot

Mapping/Factory/ClassMetadataFactory.php

@@ -27,10 +27,12 @@ class ClassMetadataFactory implements ClassMetadataFactoryInterface
      * @var LoaderInterface
      */
     private $loader;
+
     /**
      * @var Cache
      */
     private $cache;
+
     /**
      * @var array
      */

Mapping/Loader/YamlFileLoader.php

@@ -65,6 +65,7 @@ public function loadClassMetadata(ClassMetadataInterface $classMetadata)
 
             if (isset($yaml['attributes']) && is_array($yaml['attributes'])) {
                 $attributesMetadata = $classMetadata->getAttributesMetadata();
+
                 foreach ($yaml['attributes'] as $attribute => $data) {
                     if (isset($attributesMetadata[$attribute])) {
                         $attributeMetadata = $attributesMetadata[$attribute];
@@ -74,7 +75,15 @@ public function loadClassMetadata(ClassMetadataInterface $classMetadata)
                     }
 
                     if (isset($data['groups'])) {
+                        if (!is_array($data['groups'])) {
+                            throw new MappingException('The "groups" key must be an array of strings in "%s" for the attribute "%s" of the class "%s".', $this->file, $attribute, $classMetadata->getName());
+                        }
+
                         foreach ($data['groups'] as $group) {
+                            if (!is_string($group)) {
+                                throw new MappingException('Group names must be strings in "%s" for the attribute "%s" of the class "%s".', $this->file, $attribute, $classMetadata->getName());
+                            }
+
                             $attributeMetadata->addGroup($group);
                         }
                     }

NameConverter/CamelCaseToSnakeCaseNameConverter.php

@@ -22,6 +22,7 @@ class CamelCaseToSnakeCaseNameConverter implements NameConverterInterface
      * @var array|null
      */
     private $attributes;
+
     /**
      * @var bool
      */

Normalizer/AbstractNormalizer.php

@@ -33,26 +33,32 @@ abstract class AbstractNormalizer extends SerializerAwareNormalizer implements N
      * @var int
      */
     protected $circularReferenceLimit = 1;
+
     /**
      * @var callable
      */
     protected $circularReferenceHandler;
+
     /**
      * @var ClassMetadataFactoryInterface|null
      */
     protected $classMetadataFactory;
+
     /**
      * @var NameConverterInterface|null
      */
     protected $nameConverter;
+
     /**
      * @var array
      */
     protected $callbacks = array();
+
     /**
      * @var array
      */
     protected $ignoredAttributes = array();
+
     /**
      * @var array
      */

Serializer.php

@@ -41,18 +41,22 @@ class Serializer implements SerializerInterface, NormalizerInterface, Denormaliz
      * @var Encoder\ChainEncoder
      */
     protected $encoder;
+
     /**
      * @var Encoder\ChainDecoder
      */
     protected $decoder;
+
     /**
      * @var array
      */
     protected $normalizers = array();
+
     /**
      * @var array
      */
     protected $normalizerCache = array();
+
     /**
      * @var array
      */
@@ -247,8 +251,10 @@ private function denormalizeObject($data, $class, $format, array $context = arra
         }
 
         foreach ($this->normalizers as $normalizer) {
-            if ($normalizer instanceof DenormalizerInterface
-                && $normalizer->supportsDenormalization($data, $class, $format)) {
+            if (
+                $normalizer instanceof DenormalizerInterface &&
+                $normalizer->supportsDenormalization($data, $class, $format)
+            ) {
                 return $normalizer->denormalize($data, $class, $format, $context);
             }
         }

Tests/Normalizer/GetSetMethodNormalizerTest.php

@@ -343,7 +343,6 @@ public function provideCallbacks()
             array(
                 array(
                     'bar' => function ($bar) {
-                        return;
                     },
                 ),
                 'baz',