Merge branch '3.4' into 4.3

* 3.4:
  #30432 fix an error message
  fix paths to detect code owners
  [Validator] Ensure numeric subpaths do not cause errors on PHP 7.4
  Remove unused local variables in tests
  Make sure to collect child forms created on *_SET_DATA events
  do not render errors for checkboxes twice

Author: nicolas-grekas

Core/Tests/Encoder/EncoderFactoryTest.php

@@ -117,7 +117,7 @@ public function testGetInvalidNamedEncoderForEncoderAware()
 
         $user = new EncAwareUser('user', 'pass');
         $user->encoderName = 'invalid_encoder_name';
-        $encoder = $factory->getEncoder($user);
+        $factory->getEncoder($user);
     }
 
     public function testGetEncoderForEncoderAwareWithClassName()

Guard/Tests/Provider/GuardAuthenticationProviderTest.php

@@ -162,7 +162,7 @@ public function testGuardWithNoLongerAuthenticatedTriggersLogout()
         $token->setAuthenticated(false);
 
         $provider = new GuardAuthenticationProvider([], $this->userProvider, $providerKey, $this->userChecker);
-        $actualToken = $provider->authenticate($token);
+        $provider->authenticate($token);
     }
 
     public function testSupportsChecksGuardAuthenticatorsTokenOrigin()

Http/Tests/Firewall/LogoutListenerTest.php

@@ -21,7 +21,7 @@ class LogoutListenerTest extends TestCase
 {
     public function testHandleUnmatchedPath()
     {
-        list($listener, $tokenStorage, $httpUtils, $options) = $this->getListener();
+        list($listener, , $httpUtils, $options) = $this->getListener();
 
         list($event, $request) = $this->getGetResponseEvent();
 
@@ -131,7 +131,7 @@ public function testSuccessHandlerReturnsNonResponse()
         $this->expectException('RuntimeException');
         $successHandler = $this->getSuccessHandler();
 
-        list($listener, $tokenStorage, $httpUtils, $options) = $this->getListener($successHandler);
+        list($listener, , $httpUtils, $options) = $this->getListener($successHandler);
 
         list($event, $request) = $this->getGetResponseEvent();
 
@@ -153,7 +153,7 @@ public function testCsrfValidationFails()
         $this->expectException('Symfony\Component\Security\Core\Exception\LogoutException');
         $tokenManager = $this->getTokenManager();
 
-        list($listener, $tokenStorage, $httpUtils, $options) = $this->getListener(null, $tokenManager);
+        list($listener, , $httpUtils, $options) = $this->getListener(null, $tokenManager);
 
         list($event, $request) = $this->getGetResponseEvent();
 

Http/Tests/Firewall/RememberMeListenerTest.php

@@ -224,7 +224,7 @@ public function testOnCoreSecurity()
 
     public function testSessionStrategy()
     {
-        list($listener, $tokenStorage, $service, $manager, , $dispatcher, $sessionStrategy) = $this->getListener(false, true, true);
+        list($listener, $tokenStorage, $service, $manager, , , $sessionStrategy) = $this->getListener(false, true, true);
 
         $tokenStorage
             ->expects($this->once())
@@ -289,7 +289,7 @@ public function testSessionStrategy()
 
     public function testSessionIsMigratedByDefault()
     {
-        list($listener, $tokenStorage, $service, $manager, , $dispatcher, $sessionStrategy) = $this->getListener(false, true, false);
+        list($listener, $tokenStorage, $service, $manager) = $this->getListener(false, true, false);
 
         $tokenStorage
             ->expects($this->once())

Http/Tests/Firewall/RemoteUserAuthenticationListenerTest.php

@@ -60,7 +60,7 @@ public function testGetPreAuthenticatedDataNoUser()
         $method = new \ReflectionMethod($listener, 'getPreAuthenticatedData');
         $method->setAccessible(true);
 
-        $result = $method->invokeArgs($listener, [$request]);
+        $method->invokeArgs($listener, [$request]);
     }
 
     public function testGetPreAuthenticatedDataWithDifferentKeys()

Http/Tests/Firewall/X509AuthenticationListenerTest.php

@@ -98,7 +98,7 @@ public function testGetPreAuthenticatedDataNoData()
         $method = new \ReflectionMethod($listener, 'getPreAuthenticatedData');
         $method->setAccessible(true);
 
-        $result = $method->invokeArgs($listener, [$request]);
+        $method->invokeArgs($listener, [$request]);
     }
 
     public function testGetPreAuthenticatedDataWithDifferentKeys()

Http/Tests/RememberMe/ResponseListenerTest.php

@@ -66,8 +66,6 @@ public function testRememberMeCookieIsNotSendWithResponse()
 
     public function testItSubscribesToTheOnKernelResponseEvent()
     {
-        $listener = new ResponseListener();
-
         $this->assertSame([KernelEvents::RESPONSE => 'onKernelResponse'], ResponseListener::getSubscribedEvents());
     }