[2.3] Static Code Analysis for Components

kalessil · fabpot · commit 708edd6eb185 · 2015-03-12T18:51:57.000+01:00
diff --git a/Acl/Dbal/MutableAclProvider.php b/Acl/Dbal/MutableAclProvider.php
@@ -785,7 +785,6 @@ private function updateNewFieldAceProperty($name, array $changes)
     {
         $sids = new \SplObjectStorage();
         $classIds = new \SplObjectStorage();
-        $currentIds = array();
         foreach ($changes[1] as $field => $new) {
             for ($i = 0, $c = count($new); $i<$c; $i++) {
                 $ace = $new[$i];
@@ -813,8 +812,6 @@ private function updateNewFieldAceProperty($name, array $changes)
                     $aceIdProperty = new \ReflectionProperty('Symfony\Component\Security\Acl\Domain\Entry', 'id');
                     $aceIdProperty->setAccessible(true);
                     $aceIdProperty->setValue($ace, (int) $aceId);
-                } else {
-                    $currentIds[$ace->getId()] = true;
                 }
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -785,7 +785,6 @@ private function updateNewFieldAceProperty($name, array $changes)`
`785`	`785`	`{`
`786`	`786`	`$sids = new \SplObjectStorage();`
`787`	`787`	`$classIds = new \SplObjectStorage();`
`788`		`- $currentIds = array();`
`789`	`788`	`foreach ($changes[1] as $field => $new) {`
`790`	`789`	`for ($i = 0, $c = count($new); $i<$c; $i++) {`
`791`	`790`	`$ace = $new[$i];`
`@@ -813,8 +812,6 @@ private function updateNewFieldAceProperty($name, array $changes)`
`813`	`812`	`$aceIdProperty = new \ReflectionProperty('Symfony\Component\Security\Acl\Domain\Entry', 'id');`
`814`	`813`	`$aceIdProperty->setAccessible(true);`
`815`	`814`	`$aceIdProperty->setValue($ace, (int) $aceId);`
`816`		`- } else {`
`817`		`- $currentIds[$ace->getId()] = true;`
`818`	`815`	`}`
`819`	`816`	`}`
`820`	`817`	`}`