minor #14121 CS: Pre incrementation/decrementation should be used if possible (gharlan)

fabpot · fabpot · commit e9069702d390 · 2015-05-15T15:28:34.000+02:00
This PR was merged into the 2.3 branch. Discussion ---------- CS: Pre incrementation/decrementation should be used if possible | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Fixes provided by new fixer: PHP-CS-Fixer/PHP-CS-Fixer#1113 If this pr is merged I would change the level of the fixer to `symfony`. Commits ------- c5123d6 CS: Pre incrementation/decrementation should be used if possible
diff --git a/RememberMe/TokenBasedRememberMeServices.php b/RememberMe/TokenBasedRememberMeServices.php
@@ -82,7 +82,7 @@ private function compareHashes($hash1, $hash2)
         }
 
         $result = 0;
-        for ($i = 0; $i < $c; $i++) {
+        for ($i = 0; $i < $c; ++$i) {
             $result |= ord($hash1[$i]) ^ ord($hash2[$i]);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ private function compareHashes($hash1, $hash2)`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`$result = 0;`
`85`		`- for ($i = 0; $i < $c; $i++) {`
	`85`	`+ for ($i = 0; $i < $c; ++$i) {`
`86`	`86`	`$result \|= ord($hash1[$i]) ^ ord($hash2[$i]);`
`87`	`87`	`}`
`88`	`88`