[2.3] Static Code Analysis for Components

kalessil · fabpot · commit b46aa11d9d1a · 2016-01-12T12:31:34.000+01:00
diff --git a/Firewall/DigestAuthenticationListener.php b/Firewall/DigestAuthenticationListener.php
@@ -172,10 +172,8 @@ public function validateAndDecode($entryPointKey, $expectedRealm)
             throw new BadCredentialsException(sprintf('Missing mandatory digest value; received header "%s" (%s)', $this->header, implode(', ', $keys)));
         }
 
-        if ('auth' === $this->elements['qop']) {
-            if (!isset($this->elements['nc']) || !isset($this->elements['cnonce'])) {
-                throw new BadCredentialsException(sprintf('Missing mandatory digest value; received header "%s"', $this->header));
-            }
+        if ('auth' === $this->elements['qop'] && !isset($this->elements['nc'], $this->elements['cnonce'])) {
+            throw new BadCredentialsException(sprintf('Missing mandatory digest value; received header "%s"', $this->header));
         }
 
         if ($expectedRealm !== $this->elements['realm']) {

Original file line number	Diff line number	Diff line change
`@@ -172,10 +172,8 @@ public function validateAndDecode($entryPointKey, $expectedRealm)`
`172`	`172`	`throw new BadCredentialsException(sprintf('Missing mandatory digest value; received header "%s" (%s)', $this->header, implode(', ', $keys)));`
`173`	`173`	`}`
`174`	`174`
`175`		`- if ('auth' === $this->elements['qop']) {`
`176`		`- if (!isset($this->elements['nc']) \|\| !isset($this->elements['cnonce'])) {`
`177`		`- throw new BadCredentialsException(sprintf('Missing mandatory digest value; received header "%s"', $this->header));`
`178`		`- }`
	`175`	`+ if ('auth' === $this->elements['qop'] && !isset($this->elements['nc'], $this->elements['cnonce'])) {`
	`176`	`+ throw new BadCredentialsException(sprintf('Missing mandatory digest value; received header "%s"', $this->header));`
`179`	`177`	`}`
`180`	`178`
`181`	`179`	`if ($expectedRealm !== $this->elements['realm']) {`