Skip to content

Commit 98e979b

Browse files
Merge branch '6.1' into 6.2
* 6.1: [HttpClient] Fix computing retry delay when using RetryableHttpClient [Uid] Fix validating UUID variant bits [Validator][UID] Stop to first ULID format violation [Bridge] Fix mkdir() race condition in ProxyCacheWarmer [Cache] update readme Bug #42343 [Security] Fix valid remember-me token exposure to the second consequent request Prevent exception if request stack is empty Psr18Client ignore invalid HTTP headers skip a transient test on AppVeyor
2 parents a906a4f + dbbc216 commit 98e979b

File tree

2 files changed

+3
-15
lines changed

2 files changed

+3
-15
lines changed

RememberMe/PersistentRememberMeHandler.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ public function processRememberMe(RememberMeDetails $rememberMeDetails, UserInte
6969

7070
if ($this->tokenVerifier) {
7171
$isTokenValid = $this->tokenVerifier->verifyToken($persistentToken, $tokenValue);
72-
$tokenValue = $persistentToken->getTokenValue();
7372
} else {
7473
$isTokenValid = hash_equals($persistentToken->getTokenValue(), $tokenValue);
7574
}
@@ -88,9 +87,9 @@ public function processRememberMe(RememberMeDetails $rememberMeDetails, UserInte
8887
$tokenLastUsed = new \DateTime();
8988
$this->tokenVerifier?->updateExistingToken($persistentToken, $tokenValue, $tokenLastUsed);
9089
$this->tokenProvider->updateToken($series, $tokenValue, $tokenLastUsed);
91-
}
9290

93-
$this->createCookie($rememberMeDetails->withValue($series.':'.$tokenValue));
91+
$this->createCookie($rememberMeDetails->withValue($series.':'.$tokenValue));
92+
}
9493
}
9594

9695
public function clearRememberMeCookie(): void

Tests/RememberMe/PersistentRememberMeHandlerTest.php

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -125,18 +125,7 @@ public function testConsumeRememberMeCookieValidByValidatorWithoutUpdate()
125125
$rememberMeDetails = new RememberMeDetails(InMemoryUser::class, 'wouter', 360, 'series1:oldTokenValue');
126126
$handler->consumeRememberMeCookie($rememberMeDetails);
127127

128-
// assert that the cookie has been updated with a new base64 encoded token value
129-
$this->assertTrue($this->request->attributes->has(ResponseListener::COOKIE_ATTR_NAME));
130-
131-
/** @var Cookie $cookie */
132-
$cookie = $this->request->attributes->get(ResponseListener::COOKIE_ATTR_NAME);
133-
134-
$cookieParts = explode(':', base64_decode($cookie->getValue()), 4);
135-
136-
$this->assertSame(InMemoryUser::class, $cookieParts[0]); // class
137-
$this->assertSame(base64_encode('wouter'), $cookieParts[1]); // identifier
138-
$this->assertSame('360', $cookieParts[2]); // expire
139-
$this->assertSame('series1:tokenvalue', $cookieParts[3]); // value
128+
$this->assertFalse($this->request->attributes->has(ResponseListener::COOKIE_ATTR_NAME));
140129
}
141130

142131
public function testConsumeRememberMeCookieInvalidToken()

0 commit comments

Comments
 (0)