Remove experimental flag from the authenticator system 🚀

chalasr · chalasr · commit 5fe15e93828e · 2021-04-14T10:47:21.000+02:00
diff --git a/Authentication/AuthenticatorManager.php b/Authentication/AuthenticatorManager.php
@@ -39,8 +39,6 @@
  * @author Wouter de Jong <wouter@wouterj.nl>
  * @author Ryan Weaver <ryan@symfonycasts.com>
  * @author Amaury Leroux de Lens <amaury@lerouxdelens.com>
- *
- * @experimental in 5.3
  */
 class AuthenticatorManager implements AuthenticatorManagerInterface, UserAuthenticatorInterface
 {
diff --git a/Authentication/AuthenticatorManagerInterface.php b/Authentication/AuthenticatorManagerInterface.php
@@ -18,8 +18,6 @@
 /**
  * @author Wouter de Jong <wouter@wouterj.nl>
  * @author Ryan Weaver <ryan@symfonycasts.com>
- *
- * @experimental in 5.3
  */
 interface AuthenticatorManagerInterface
 {
diff --git a/Authentication/UserAuthenticatorInterface.php b/Authentication/UserAuthenticatorInterface.php
@@ -19,8 +19,6 @@
 
 /**
  * @author Wouter de Jong <wouter@wouterj.nl>
- *
- * @experimental in 5.3
  */
 interface UserAuthenticatorInterface
 {
diff --git a/Authenticator/AbstractAuthenticator.php b/Authenticator/AbstractAuthenticator.php
@@ -21,8 +21,6 @@
  * An optional base class that creates the necessary tokens for you.
  *
  * @author Ryan Weaver <ryan@symfonycasts.com>
- *
- * @experimental in 5.3
  */
 abstract class AbstractAuthenticator implements AuthenticatorInterface
 {
diff --git a/Authenticator/AbstractLoginFormAuthenticator.php b/Authenticator/AbstractLoginFormAuthenticator.php
@@ -22,8 +22,6 @@
  * A base class to make form login authentication easier!
  *
  * @author Ryan Weaver <ryan@symfonycasts.com>
- *
- * @experimental in 5.3
  */
 abstract class AbstractLoginFormAuthenticator extends AbstractAuthenticator implements AuthenticationEntryPointInterface, InteractiveAuthenticatorInterface
 {
diff --git a/Authenticator/AbstractPreAuthenticatedAuthenticator.php b/Authenticator/AbstractPreAuthenticatedAuthenticator.php
@@ -33,7 +33,6 @@
  * @author Fabien Potencier <fabien@symfony.com>
  *
  * @internal
- * @experimental in 5.3
  */
 abstract class AbstractPreAuthenticatedAuthenticator implements InteractiveAuthenticatorInterface
 {
diff --git a/Authenticator/AuthenticatorInterface.php b/Authenticator/AuthenticatorInterface.php
@@ -23,8 +23,6 @@
  * @author Ryan Weaver <ryan@symfonycasts.com>
  * @author Amaury Leroux de Lens <amaury@lerouxdelens.com>
  * @author Wouter de Jong <wouter@wouterj.nl>
- *
- * @experimental in 5.3
  */
 interface AuthenticatorInterface
 {
diff --git a/Authenticator/FormLoginAuthenticator.php b/Authenticator/FormLoginAuthenticator.php
@@ -18,11 +18,9 @@
 use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
 use Symfony\Component\Security\Core\Authentication\Token\UsernamePasswordToken;
 use Symfony\Component\Security\Core\Exception\AuthenticationException;
-use Symfony\Component\Security\Core\Exception\AuthenticationServiceException;
 use Symfony\Component\Security\Core\Exception\BadCredentialsException;
 use Symfony\Component\Security\Core\Security;
 use Symfony\Component\Security\Core\User\PasswordUpgraderInterface;
-use Symfony\Component\Security\Core\User\UserInterface;
 use Symfony\Component\Security\Core\User\UserProviderInterface;
 use Symfony\Component\Security\Http\Authentication\AuthenticationFailureHandlerInterface;
 use Symfony\Component\Security\Http\Authentication\AuthenticationSuccessHandlerInterface;
@@ -41,7 +39,6 @@
  * @author Fabien Potencier <fabien@symfony.com>
  *
  * @final
- * @experimental in 5.3
  */
 class FormLoginAuthenticator extends AbstractLoginFormAuthenticator
 {
diff --git a/Authenticator/HttpBasicAuthenticator.php b/Authenticator/HttpBasicAuthenticator.php
@@ -17,9 +17,7 @@
 use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
 use Symfony\Component\Security\Core\Authentication\Token\UsernamePasswordToken;
 use Symfony\Component\Security\Core\Exception\AuthenticationException;
-use Symfony\Component\Security\Core\Exception\AuthenticationServiceException;
 use Symfony\Component\Security\Core\User\PasswordUpgraderInterface;
-use Symfony\Component\Security\Core\User\UserInterface;
 use Symfony\Component\Security\Core\User\UserProviderInterface;
 use Symfony\Component\Security\Http\Authenticator\Passport\Badge\PasswordUpgradeBadge;
 use Symfony\Component\Security\Http\Authenticator\Passport\Badge\UserBadge;
@@ -33,7 +31,6 @@
  * @author Fabien Potencier <fabien@symfony.com>
  *
  * @final
- * @experimental in 5.3
  */
 class HttpBasicAuthenticator implements AuthenticatorInterface, AuthenticationEntryPointInterface
 {
diff --git a/Authenticator/JsonLoginAuthenticator.php b/Authenticator/JsonLoginAuthenticator.php
@@ -21,11 +21,9 @@
 use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
 use Symfony\Component\Security\Core\Authentication\Token\UsernamePasswordToken;
 use Symfony\Component\Security\Core\Exception\AuthenticationException;
-use Symfony\Component\Security\Core\Exception\AuthenticationServiceException;
 use Symfony\Component\Security\Core\Exception\BadCredentialsException;
 use Symfony\Component\Security\Core\Security;
 use Symfony\Component\Security\Core\User\PasswordUpgraderInterface;
-use Symfony\Component\Security\Core\User\UserInterface;
 use Symfony\Component\Security\Core\User\UserProviderInterface;
 use Symfony\Component\Security\Http\Authentication\AuthenticationFailureHandlerInterface;
 use Symfony\Component\Security\Http\Authentication\AuthenticationSuccessHandlerInterface;
@@ -45,7 +43,6 @@
  * @author Wouter de Jong <wouter@wouterj.nl>
  *
  * @final
- * @experimental in 5.3
  */
 class JsonLoginAuthenticator implements InteractiveAuthenticatorInterface
 {
diff --git a/Authenticator/Passport/Badge/BadgeInterface.php b/Authenticator/Passport/Badge/BadgeInterface.php
@@ -15,8 +15,6 @@
  * Passport badges allow to add more information to a passport (e.g. a CSRF token).
  *
  * @author Wouter de Jong <wouter@wouterj.nl>
- *
- * @experimental in 5.3
  */
 interface BadgeInterface
 {
diff --git a/Authenticator/Passport/Badge/CsrfTokenBadge.php b/Authenticator/Passport/Badge/CsrfTokenBadge.php
@@ -21,7 +21,6 @@
  * @author Wouter de Jong <wouter@wouterj.nl>
  *
  * @final
- * @experimental in 5.3
  */
 class CsrfTokenBadge implements BadgeInterface
 {
diff --git a/Authenticator/Passport/Badge/PasswordUpgradeBadge.php b/Authenticator/Passport/Badge/PasswordUpgradeBadge.php
@@ -22,7 +22,6 @@
  * @author Wouter de Jong <wouter@wouterj.nl>
  *
  * @final
- * @experimental in 5.3
  */
 class PasswordUpgradeBadge implements BadgeInterface
 {
diff --git a/Authenticator/Passport/Badge/PreAuthenticatedUserBadge.php b/Authenticator/Passport/Badge/PreAuthenticatedUserBadge.php
@@ -23,7 +23,6 @@
  * @author Wouter de Jong <wouter@wouterj.nl>
  *
  * @final
- * @experimental in 5.3
  */
 class PreAuthenticatedUserBadge implements BadgeInterface
 {
diff --git a/Authenticator/Passport/Badge/RememberMeBadge.php b/Authenticator/Passport/Badge/RememberMeBadge.php
@@ -21,7 +21,6 @@
  * @author Wouter de Jong <wouter@wouterj.nl>
  *
  * @final
- * @experimental in 5.3
  */
 class RememberMeBadge implements BadgeInterface
 {
diff --git a/Authenticator/Passport/Badge/UserBadge.php b/Authenticator/Passport/Badge/UserBadge.php
@@ -22,8 +22,6 @@
  * "user loader" to load the related User object.
  *
  * @author Wouter de Jong <wouter@wouterj.nl>
- *
- * @experimental in 5.3
  */
 class UserBadge implements BadgeInterface
 {
@@ -67,7 +65,7 @@ public function getUser(): UserInterface
 
             $this->user = ($this->userLoader)($this->userIdentifier);
             if (!$this->user instanceof UserInterface) {
-                throw new AuthenticationServiceException(sprintf('The user provider must return a UserInterface object, "%s" given.', \get_debug_type($this->user)));
+                throw new AuthenticationServiceException(sprintf('The user provider must return a UserInterface object, "%s" given.', get_debug_type($this->user)));
             }
         }
 
diff --git a/Authenticator/Passport/Credentials/CredentialsInterface.php b/Authenticator/Passport/Credentials/CredentialsInterface.php
@@ -18,8 +18,6 @@
  * credential check of an authenticator.
  *
  * @author Wouter de Jong <wouter@wouterj.nl>
- *
- * @experimental in 5.3
  */
 interface CredentialsInterface extends BadgeInterface
 {
diff --git a/Authenticator/Passport/Credentials/CustomCredentials.php b/Authenticator/Passport/Credentials/CustomCredentials.php
@@ -20,7 +20,6 @@
  * @author Wouter de Jong <wouter@wouterj.nl>
  *
  * @final
- * @experimental in 5.3
  */
 class CustomCredentials implements CredentialsInterface
 {
diff --git a/Authenticator/Passport/Credentials/PasswordCredentials.php b/Authenticator/Passport/Credentials/PasswordCredentials.php
@@ -22,7 +22,6 @@
  * @author Wouter de Jong <wouter@wouterj.nl>
  *
  * @final
- * @experimental in 5.3
  */
 class PasswordCredentials implements CredentialsInterface
 {
diff --git a/Authenticator/Passport/Passport.php b/Authenticator/Passport/Passport.php
@@ -20,8 +20,6 @@
  * The default implementation for passports.
  *
  * @author Wouter de Jong <wouter@wouterj.nl>
- *
- * @experimental in 5.3
  */
 class Passport implements UserPassportInterface
 {
diff --git a/Authenticator/Passport/PassportInterface.php b/Authenticator/Passport/PassportInterface.php
@@ -21,8 +21,6 @@
  * passport.
  *
  * @author Wouter de Jong <wouter@wouterj.nl>
- *
- * @experimental in 5.3
  */
 interface PassportInterface
 {
diff --git a/Authenticator/Passport/PassportTrait.php b/Authenticator/Passport/PassportTrait.php
@@ -15,8 +15,6 @@
 
 /**
  * @author Wouter de Jong <wouter@wouterj.nl>
- *
- * @experimental in 5.3
  */
 trait PassportTrait
 {
diff --git a/Authenticator/Passport/SelfValidatingPassport.php b/Authenticator/Passport/SelfValidatingPassport.php
@@ -19,8 +19,6 @@
  * API token authentication).
  *
  * @author Wouter de Jong <wouter@wouterj.nl>
- *
- * @experimental in 5.3
  */
 class SelfValidatingPassport extends Passport
 {
diff --git a/Authenticator/Passport/UserPassportInterface.php b/Authenticator/Passport/UserPassportInterface.php
@@ -18,8 +18,6 @@
  * Represents a passport for a Security User.
  *
  * @author Wouter de Jong <wouter@wouterj.nl>
- *
- * @experimental in 5.3
  */
 interface UserPassportInterface extends PassportInterface
 {
diff --git a/Authenticator/X509Authenticator.php b/Authenticator/X509Authenticator.php
@@ -25,7 +25,6 @@
  * @author Fabien Potencier <fabien@symfony.com>
  *
  * @final
- * @experimental in 5.3
  */
 class X509Authenticator extends AbstractPreAuthenticatedAuthenticator
 {
diff --git a/EventListener/CheckCredentialsListener.php b/EventListener/CheckCredentialsListener.php
@@ -30,7 +30,6 @@
  * @author Wouter de Jong <wouter@driveamber.com>
  *
  * @final
- * @experimental in 5.3
  */
 class CheckCredentialsListener implements EventSubscriberInterface
 {
diff --git a/EventListener/CheckRememberMeConditionsListener.php b/EventListener/CheckRememberMeConditionsListener.php
@@ -36,7 +36,6 @@
  * @author Wouter de Jong <wouter@wouterj.nl>
  *
  * @final
- * @experimental in 5.3
  */
 class CheckRememberMeConditionsListener implements EventSubscriberInterface
 {
diff --git a/EventListener/CsrfProtectionListener.php b/EventListener/CsrfProtectionListener.php
@@ -22,7 +22,6 @@
  * @author Wouter de Jong <wouter@wouterj.nl>
  *
  * @final
- * @experimental in 5.3
  */
 class CsrfProtectionListener implements EventSubscriberInterface
 {
diff --git a/EventListener/LoginThrottlingListener.php b/EventListener/LoginThrottlingListener.php
@@ -21,8 +21,6 @@
 
 /**
  * @author Wouter de Jong <wouter@wouterj.nl>
- *
- * @experimental in 5.3
  */
 final class LoginThrottlingListener implements EventSubscriberInterface
 {
diff --git a/EventListener/PasswordMigratingListener.php b/EventListener/PasswordMigratingListener.php
@@ -25,7 +25,6 @@
  * @author Wouter de Jong <wouter@wouterj.nl>
  *
  * @final
- * @experimental in 5.3
  */
 class PasswordMigratingListener implements EventSubscriberInterface
 {
diff --git a/EventListener/RememberMeListener.php b/EventListener/RememberMeListener.php
@@ -32,7 +32,6 @@
  * @author Wouter de Jong <wouter@wouterj.nl>
  *
  * @final
- * @experimental in 5.3
  */
 class RememberMeListener implements EventSubscriberInterface
 {
diff --git a/EventListener/UserCheckerListener.php b/EventListener/UserCheckerListener.php
@@ -23,7 +23,6 @@
  * @author Wouter de Jong <wouter@wouterj.nl>
  *
  * @final
- * @experimental in 5.3
  */
 class UserCheckerListener implements EventSubscriberInterface
 {
diff --git a/EventListener/UserProviderListener.php b/EventListener/UserProviderListener.php
@@ -22,7 +22,6 @@
  * @author Wouter de Jong <wouter@wouterj.nl>
  *
  * @final
- * @experimental in 5.3
  */
 class UserProviderListener
 {
diff --git a/Firewall/AuthenticatorManagerListener.php b/Firewall/AuthenticatorManagerListener.php
@@ -19,8 +19,6 @@
  * Firewall authentication listener that delegates to the authenticator system.
  *
  * @author Wouter de Jong <wouter@wouterj.nl>
- *
- * @experimental in 5.3
  */
 class AuthenticatorManagerListener extends AbstractListener
 {
diff --git a/RateLimiter/DefaultLoginRateLimiter.php b/RateLimiter/DefaultLoginRateLimiter.php
@@ -23,8 +23,6 @@
  * a limit on username+IP and a (higher) limit on IP.
  *
  * @author Wouter de Jong <wouter@wouterj.nl>
- *
- * @experimental in 5.3
  */
 final class DefaultLoginRateLimiter extends AbstractRequestRateLimiter
 {
diff --git a/RememberMe/AbstractRememberMeHandler.php b/RememberMe/AbstractRememberMeHandler.php
@@ -20,8 +20,6 @@
 
 /**
  * @author Wouter de Jong <wouter@wouterj.nl>
- *
- * @experimental in 5.3
  */
 abstract class AbstractRememberMeHandler implements RememberMeHandlerInterface
 {
diff --git a/RememberMe/PersistentRememberMeHandler.php b/RememberMe/PersistentRememberMeHandler.php
@@ -28,8 +28,6 @@
  * {@see SignatureRememberMeHandler} if you don't want to use a database.
  *
  * @author Wouter de Jong <wouter@wouterj.nl>
- *
- * @experimental in 5.3
  */
 final class PersistentRememberMeHandler extends AbstractRememberMeHandler
 {
diff --git a/RememberMe/RememberMeDetails.php b/RememberMe/RememberMeDetails.php
@@ -16,8 +16,6 @@
 
 /**
  * @author Wouter de Jong <wouter@wouterj.nl>
- *
- * @experimental in 5.3
  */
 class RememberMeDetails
 {
diff --git a/RememberMe/RememberMeHandlerInterface.php b/RememberMe/RememberMeHandlerInterface.php
@@ -21,8 +21,6 @@
  * {@see AbstractRememberMeHandler} instead.
  *
  * @author Wouter de Jong <wouter@wouterj.nl>
- *
- * @experimental in 5.3
  */
 interface RememberMeHandlerInterface
 {
diff --git a/RememberMe/SignatureRememberMeHandler.php b/RememberMe/SignatureRememberMeHandler.php
@@ -29,8 +29,6 @@
  * if you need this.
  *
  * @author Wouter de Jong <wouter@wouterj.nl>
- *
- * @experimental in 5.3
  */
 final class SignatureRememberMeHandler extends AbstractRememberMeHandler
 {

Original file line number	Diff line number	Diff line change
`@@ -39,8 +39,6 @@`
`39`	`39`	`* @author Wouter de Jong <wouter@wouterj.nl>`
`40`	`40`	`* @author Ryan Weaver <ryan@symfonycasts.com>`
`41`	`41`	`* @author Amaury Leroux de Lens <amaury@lerouxdelens.com>`
`42`		`- *`
`43`		`- * @experimental in 5.3`
`44`	`42`	`*/`
`45`	`43`	`class AuthenticatorManager implements AuthenticatorManagerInterface, UserAuthenticatorInterface`
`46`	`44`	`{`
Original file line number	Diff line number	Diff line change
`@@ -18,8 +18,6 @@`
`18`	`18`	`/**`
`19`	`19`	`* @author Wouter de Jong <wouter@wouterj.nl>`
`20`	`20`	`* @author Ryan Weaver <ryan@symfonycasts.com>`
`21`		`- *`
`22`		`- * @experimental in 5.3`
`23`	`21`	`*/`
`24`	`22`	`interface AuthenticatorManagerInterface`
`25`	`23`	`{`
Original file line number	Diff line number	Diff line change
`@@ -19,8 +19,6 @@`
`19`	`19`
`20`	`20`	`/**`
`21`	`21`	`* @author Wouter de Jong <wouter@wouterj.nl>`
`22`		`- *`
`23`		`- * @experimental in 5.3`
`24`	`22`	`*/`
`25`	`23`	`interface UserAuthenticatorInterface`
`26`	`24`	`{`
Original file line number	Diff line number	Diff line change
`@@ -21,8 +21,6 @@`
`21`	`21`	`* An optional base class that creates the necessary tokens for you.`
`22`	`22`	`*`
`23`	`23`	`* @author Ryan Weaver <ryan@symfonycasts.com>`
`24`		`- *`
`25`		`- * @experimental in 5.3`
`26`	`24`	`*/`
`27`	`25`	`abstract class AbstractAuthenticator implements AuthenticatorInterface`
`28`	`26`	`{`
Original file line number	Diff line number	Diff line change
`@@ -22,8 +22,6 @@`
`22`	`22`	`* A base class to make form login authentication easier!`
`23`	`23`	`*`
`24`	`24`	`* @author Ryan Weaver <ryan@symfonycasts.com>`
`25`		`- *`
`26`		`- * @experimental in 5.3`
`27`	`25`	`*/`
`28`	`26`	`abstract class AbstractLoginFormAuthenticator extends AbstractAuthenticator implements AuthenticationEntryPointInterface, InteractiveAuthenticatorInterface`
`29`	`27`	`{`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,6 @@`
`33`	`33`	`* @author Fabien Potencier <fabien@symfony.com>`
`34`	`34`	`*`
`35`	`35`	`* @internal`
`36`		`- * @experimental in 5.3`
`37`	`36`	`*/`
`38`	`37`	`abstract class AbstractPreAuthenticatedAuthenticator implements InteractiveAuthenticatorInterface`
`39`	`38`	`{`
Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,6 @@`
`23`	`23`	`* @author Ryan Weaver <ryan@symfonycasts.com>`
`24`	`24`	`* @author Amaury Leroux de Lens <amaury@lerouxdelens.com>`
`25`	`25`	`* @author Wouter de Jong <wouter@wouterj.nl>`
`26`		`- *`
`27`		`- * @experimental in 5.3`
`28`	`26`	`*/`
`29`	`27`	`interface AuthenticatorInterface`
`30`	`28`	`{`