[Security] Fix SwitchUser is broken when the User Provider always returns a valid user

tucksaun · tucksaun · commit 4fb691354798 · 2019-11-23T15:44:33.000+01:00
diff --git a/Firewall/SwitchUserListener.php b/Firewall/SwitchUserListener.php
@@ -153,7 +153,6 @@ private function attemptSwitchUser(Request $request, $username)
 
             try {
                 $this->provider->loadUserByUsername($nonExistentUsername);
-                throw new \LogicException('AuthenticationException expected');
             } catch (AuthenticationException $e) {
             }
         } catch (AuthenticationException $e) {

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,6 @@ private function attemptSwitchUser(Request $request, $username)`
`153`	`153`
`154`	`154`	`try {`
`155`	`155`	`$this->provider->loadUserByUsername($nonExistentUsername);`
`156`		`- throw new \LogicException('AuthenticationException expected');`
`157`	`156`	`} catch (AuthenticationException $e) {`
`158`	`157`	`}`
`159`	`158`	`} catch (AuthenticationException $e) {`