[Security] Add types to private properties

Signed-off-by: Alexander M. Turek <me@derrabus.de>

Author: derrabus

AccessMap.php

@@ -22,7 +22,7 @@
  */
 class AccessMap implements AccessMapInterface
 {
-    private $map = [];
+    private array $map = [];
 
     /**
      * @param array       $attributes An array of attributes to pass to the access decision manager (like roles)

Authentication/AuthenticationUtils.php

@@ -23,7 +23,7 @@
  */
 class AuthenticationUtils
 {
-    private $requestStack;
+    private RequestStack $requestStack;
 
     public function __construct(RequestStack $requestStack)
     {

Authentication/AuthenticatorManager.php

@@ -45,17 +45,17 @@
  */
 class AuthenticatorManager implements AuthenticatorManagerInterface, UserAuthenticatorInterface
 {
-    private $authenticators;
-    private $tokenStorage;
-    private $eventDispatcher;
-    private $eraseCredentials;
-    private $logger;
-    private $firewallName;
-    private $hideUserNotFoundExceptions;
-    private $requiredBadges;
+    private iterable $authenticators;
+    private TokenStorageInterface $tokenStorage;
+    private EventDispatcherInterface $eventDispatcher;
+    private bool $eraseCredentials;
+    private ?LoggerInterface $logger;
+    private string $firewallName;
+    private bool $hideUserNotFoundExceptions;
+    private array $requiredBadges;
 
     /**
-     * @param AuthenticatorInterface[] $authenticators
+     * @param iterable<mixed, AuthenticatorInterface> $authenticators
      */
     public function __construct(iterable $authenticators, TokenStorageInterface $tokenStorage, EventDispatcherInterface $eventDispatcher, string $firewallName, LoggerInterface $logger = null, bool $eraseCredentials = true, bool $hideUserNotFoundExceptions = true, array $requiredBadges = [])
     {

Authentication/CustomAuthenticationFailureHandler.php

@@ -20,7 +20,7 @@
  */
 class CustomAuthenticationFailureHandler implements AuthenticationFailureHandlerInterface
 {
-    private $handler;
+    private AuthenticationFailureHandlerInterface $handler;
 
     /**
      * @param array $options Options for processing a successful authentication attempt

Authentication/CustomAuthenticationSuccessHandler.php

@@ -20,7 +20,7 @@
  */
 class CustomAuthenticationSuccessHandler implements AuthenticationSuccessHandlerInterface
 {
-    private $handler;
+    private AuthenticationSuccessHandlerInterface $handler;
 
     /**
      * @param array $options Options for processing a successful authentication attempt

Authenticator/AbstractPreAuthenticatedAuthenticator.php

@@ -36,10 +36,10 @@
  */
 abstract class AbstractPreAuthenticatedAuthenticator implements InteractiveAuthenticatorInterface
 {
-    private $userProvider;
-    private $tokenStorage;
-    private $firewallName;
-    private $logger;
+    private UserProviderInterface $userProvider;
+    private TokenStorageInterface $tokenStorage;
+    private string $firewallName;
+    private ?LoggerInterface $logger;
 
     public function __construct(UserProviderInterface $userProvider, TokenStorageInterface $tokenStorage, string $firewallName, LoggerInterface $logger = null)
     {

Authenticator/Debug/TraceableAuthenticator.php

@@ -29,10 +29,10 @@
  */
 final class TraceableAuthenticator implements AuthenticatorInterface, InteractiveAuthenticatorInterface, AuthenticationEntryPointInterface
 {
-    private $authenticator;
-    private $passport;
-    private $duration;
-    private $stub;
+    private AuthenticatorInterface $authenticator;
+    private ?Passport $passport = null;
+    private ?float $duration = null;
+    private ClassStub|string $stub;
 
     public function __construct(AuthenticatorInterface $authenticator)
     {

Authenticator/Debug/TraceableAuthenticatorManagerListener.php

@@ -24,9 +24,9 @@
  */
 final class TraceableAuthenticatorManagerListener extends AbstractListener
 {
-    private $authenticationManagerListener;
-    private $authenticatorsInfo = [];
-    private $hasVardumper;
+    private AuthenticatorManagerListener $authenticationManagerListener;
+    private array $authenticatorsInfo = [];
+    private bool $hasVardumper;
 
     public function __construct(AuthenticatorManagerListener $authenticationManagerListener)
     {

Authenticator/FormLoginAuthenticator.php

@@ -41,12 +41,12 @@
  */
 class FormLoginAuthenticator extends AbstractLoginFormAuthenticator
 {
-    private $httpUtils;
-    private $userProvider;
-    private $successHandler;
-    private $failureHandler;
-    private $options;
-    private $httpKernel;
+    private HttpUtils $httpUtils;
+    private UserProviderInterface $userProvider;
+    private AuthenticationSuccessHandlerInterface $successHandler;
+    private AuthenticationFailureHandlerInterface $failureHandler;
+    private array $options;
+    private HttpKernelInterface $httpKernel;
 
     public function __construct(HttpUtils $httpUtils, UserProviderInterface $userProvider, AuthenticationSuccessHandlerInterface $successHandler, AuthenticationFailureHandlerInterface $failureHandler, array $options)
     {

Authenticator/HttpBasicAuthenticator.php

@@ -33,9 +33,9 @@
  */
 class HttpBasicAuthenticator implements AuthenticatorInterface, AuthenticationEntryPointInterface
 {
-    private $realmName;
-    private $userProvider;
-    private $logger;
+    private string $realmName;
+    private UserProviderInterface $userProvider;
+    private ?LoggerInterface $logger;
 
     public function __construct(string $realmName, UserProviderInterface $userProvider, LoggerInterface $logger = null)
     {