Migrate to static data providers using rector/rector

OskarStark · nicolas-grekas · commit 42ae624fc518 · 2023-02-14T09:03:56.000+01:00
diff --git a/Tests/Authentication/AuthenticatorManagerTest.php b/Tests/Authentication/AuthenticatorManagerTest.php
@@ -119,7 +119,7 @@ public function testAuthenticateRequest($matchingAuthenticatorIndex)
         $this->assertTrue($listenerCalled, 'The CheckPassportEvent listener is not called');
     }
 
-    public function provideMatchingAuthenticatorIndex()
+    public static function provideMatchingAuthenticatorIndex()
     {
         yield [0];
         yield [1];
@@ -189,7 +189,7 @@ public function testEraseCredentials($eraseCredentials)
         $manager->authenticateRequest($this->request);
     }
 
-    public function provideEraseCredentialsData()
+    public static function provideEraseCredentialsData()
     {
         yield [true];
         yield [false];
diff --git a/Tests/Authenticator/AbstractLoginFormAuthenticatorTest.php b/Tests/Authenticator/AbstractLoginFormAuthenticatorTest.php
@@ -30,7 +30,7 @@ public function testSupports(string $loginUrl, Request $request, bool $expected)
         $this->assertSame($expected, $authenticator->supports($request));
     }
 
-    public function provideSupportsData(): iterable
+    public static function provideSupportsData(): iterable
     {
         yield [
             '/login',
diff --git a/Tests/Authenticator/FormLoginAuthenticatorTest.php b/Tests/Authenticator/FormLoginAuthenticatorTest.php
@@ -60,7 +60,7 @@ public function testHandleWhenUsernameLength($username, $ok)
         $this->authenticator->authenticate($request);
     }
 
-    public function provideUsernamesForLength()
+    public static function provideUsernamesForLength()
     {
         yield [str_repeat('x', Security::MAX_USERNAME_LENGTH + 1), false];
         yield [str_repeat('x', Security::MAX_USERNAME_LENGTH - 1), true];
@@ -126,7 +126,7 @@ public function testHandleNonStringUsernameWithToString($postOnly)
         $this->authenticator->authenticate($request);
     }
 
-    public function postOnlyDataProvider()
+    public static function postOnlyDataProvider()
     {
         yield [true];
         yield [false];
@@ -171,7 +171,7 @@ public function testSupportsFormOnly(string $contentType, bool $shouldSupport)
         $this->assertSame($shouldSupport, $this->authenticator->supports($request));
     }
 
-    public function provideContentTypes()
+    public static function provideContentTypes()
     {
         yield ['application/json', false];
         yield ['application/x-www-form-urlencoded', true];
diff --git a/Tests/Authenticator/HttpBasicAuthenticatorTest.php b/Tests/Authenticator/HttpBasicAuthenticatorTest.php
@@ -67,7 +67,7 @@ public function testHttpBasicServerParametersMissing(array $serverParameters)
         $this->assertFalse($this->authenticator->supports($request));
     }
 
-    public function provideMissingHttpBasicServerParameters()
+    public static function provideMissingHttpBasicServerParameters()
     {
         return [
             [[]],
diff --git a/Tests/Authenticator/JsonLoginAuthenticatorTest.php b/Tests/Authenticator/JsonLoginAuthenticatorTest.php
@@ -45,7 +45,7 @@ public function testSupport($request)
         $this->assertTrue($this->authenticator->supports($request));
     }
 
-    public function provideSupportData()
+    public static function provideSupportData()
     {
         yield [new Request([], [], [], [], [], ['HTTP_CONTENT_TYPE' => 'application/json'], '{"username": "dunglas", "password": "foo"}')];
 
@@ -64,7 +64,7 @@ public function testSupportsWithCheckPath($request, $result)
         $this->assertSame($result, $this->authenticator->supports($request));
     }
 
-    public function provideSupportsWithCheckPathData()
+    public static function provideSupportsWithCheckPathData()
     {
         yield [Request::create('/api/login', 'GET', [], [], [], ['HTTP_CONTENT_TYPE' => 'application/json']), true];
         yield [Request::create('/login', 'GET', [], [], [], ['HTTP_CONTENT_TYPE' => 'application/json']), false];
@@ -104,7 +104,7 @@ public function testAuthenticateInvalid($request, $errorMessage, $exceptionType
         $this->authenticator->authenticate($request);
     }
 
-    public function provideInvalidAuthenticateData()
+    public static function provideInvalidAuthenticateData()
     {
         $request = new Request([], [], [], [], [], ['HTTP_CONTENT_TYPE' => 'application/json']);
         yield [$request, 'Invalid JSON.'];
diff --git a/Tests/Authenticator/LoginLinkAuthenticatorTest.php b/Tests/Authenticator/LoginLinkAuthenticatorTest.php
@@ -50,7 +50,7 @@ public function testSupport(array $options, $request, bool $supported)
         $this->assertEquals($supported, $this->authenticator->supports($request));
     }
 
-    public function provideSupportData()
+    public static function provideSupportData()
     {
         yield [['check_route' => '/validate_link'], Request::create('/validate_link?hash=abc123'), true];
         yield [['check_route' => '/validate_link'], Request::create('/login?hash=abc123'), false];
diff --git a/Tests/Authenticator/RememberMeAuthenticatorTest.php b/Tests/Authenticator/RememberMeAuthenticatorTest.php
@@ -51,7 +51,7 @@ public function testSupports($request, $support)
         $this->assertSame($support, $this->authenticator->supports($request));
     }
 
-    public function provideSupportsData()
+    public static function provideSupportsData()
     {
         yield [Request::create('/'), false];
 
diff --git a/Tests/Authenticator/RemoteUserAuthenticatorTest.php b/Tests/Authenticator/RemoteUserAuthenticatorTest.php
@@ -64,7 +64,7 @@ public function testAuthenticate(InMemoryUserProvider $userProvider, RemoteUserA
         $this->assertTrue($user->isEqualTo($passport->getUser()));
     }
 
-    public function provideAuthenticators()
+    public static function provideAuthenticators()
     {
         $userProvider = new InMemoryUserProvider();
         yield [$userProvider, new RemoteUserAuthenticator($userProvider, new TokenStorage(), 'main'), 'REMOTE_USER'];
diff --git a/Tests/EntryPoint/RetryAuthenticationEntryPointTest.php b/Tests/EntryPoint/RetryAuthenticationEntryPointTest.php
@@ -33,7 +33,7 @@ public function testStart($httpPort, $httpsPort, $request, $expectedUrl)
         $this->assertEquals($expectedUrl, $response->headers->get('Location'));
     }
 
-    public function dataForStart()
+    public static function dataForStart()
     {
         if (!class_exists(Request::class)) {
             return [[]];
diff --git a/Tests/EventListener/CheckCredentialsListenerTest.php b/Tests/EventListener/CheckCredentialsListenerTest.php
@@ -62,7 +62,7 @@ public function testPasswordAuthenticated($password, $passwordValid, $result)
         }
     }
 
-    public function providePasswords()
+    public static function providePasswords()
     {
         yield ['ThePa$$word', true, true];
         yield ['Invalid', false, false];
@@ -100,7 +100,7 @@ public function testCustomAuthenticated($result)
         }
     }
 
-    public function provideCustomAuthenticatedResults()
+    public static function provideCustomAuthenticatedResults()
     {
         yield [true];
         yield [false];
diff --git a/Tests/EventListener/CheckRememberMeConditionsListenerTest.php b/Tests/EventListener/CheckRememberMeConditionsListenerTest.php
@@ -80,7 +80,7 @@ public function testSuccessfulLoginWithOptInRequestParameter($optInValue)
         $this->assertTrue($passport->getBadge(RememberMeBadge::class)->isEnabled());
     }
 
-    public function provideRememberMeOptInValues()
+    public static function provideRememberMeOptInValues()
     {
         yield ['true'];
         yield ['1'];
diff --git a/Tests/EventListener/UserProviderListenerTest.php b/Tests/EventListener/UserProviderListenerTest.php
@@ -59,7 +59,7 @@ public function testNotOverrideUserLoader($passport)
         $this->assertEquals($passport->hasBadge(UserBadge::class) ? $passport->getBadge(UserBadge::class) : null, $badgeBefore);
     }
 
-    public function provideCompletePassports()
+    public static function provideCompletePassports()
     {
         yield [new SelfValidatingPassport(new UserBadge('wouter', function () {}))];
     }
diff --git a/Tests/Firewall/ContextListenerTest.php b/Tests/Firewall/ContextListenerTest.php
@@ -169,7 +169,7 @@ public function testInvalidTokenInSession($token)
         $listener(new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MAIN_REQUEST));
     }
 
-    public function provideInvalidToken()
+    public static function provideInvalidToken()
     {
         return [
             ['foo'],
diff --git a/Tests/Firewall/ExceptionListenerTest.php b/Tests/Firewall/ExceptionListenerTest.php
@@ -64,7 +64,7 @@ public function testAuthenticationExceptionWithEntryPoint(\Exception $exception)
         $this->assertSame($exception, $event->getThrowable());
     }
 
-    public function getAuthenticationExceptionProvider()
+    public static function getAuthenticationExceptionProvider()
     {
         return [
             [$e = new AuthenticationException(), new HttpException(Response::HTTP_UNAUTHORIZED, '', $e, [], 0)],
@@ -183,7 +183,7 @@ public function testUnregister()
         $this->assertEmpty($dispatcher->getListeners());
     }
 
-    public function getAccessDeniedExceptionProvider()
+    public static function getAccessDeniedExceptionProvider()
     {
         return [
             [new AccessDeniedException()],
diff --git a/Tests/Firewall/LogoutListenerTest.php b/Tests/Firewall/LogoutListenerTest.php
@@ -204,7 +204,7 @@ public function testLegacyLogoutHandlers()
         $this->assertSame($response, $event->getResponse());
     }
 
-    public function provideInvalidCsrfTokens(): array
+    public static function provideInvalidCsrfTokens(): array
     {
         return [
             ['invalid'],
diff --git a/Tests/Firewall/UsernamePasswordFormAuthenticationListenerTest.php b/Tests/Firewall/UsernamePasswordFormAuthenticationListenerTest.php
@@ -267,23 +267,23 @@ public function testInvalidCsrfToken($invalidToken)
         $listener(new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MAIN_REQUEST));
     }
 
-    public function postOnlyDataProvider(): array
+    public static function postOnlyDataProvider(): array
     {
         return [
             [true],
             [false],
         ];
     }
 
-    public function getUsernameForLength(): array
+    public static function getUsernameForLength(): array
     {
         return [
             [str_repeat('x', Security::MAX_USERNAME_LENGTH + 1), false],
             [str_repeat('x', Security::MAX_USERNAME_LENGTH - 1), true],
         ];
     }
 
-    public function provideInvalidCsrfTokens(): array
+    public static function provideInvalidCsrfTokens(): array
     {
         return [
             ['invalid'],
diff --git a/Tests/HttpUtilsTest.php b/Tests/HttpUtilsTest.php
@@ -69,7 +69,7 @@ public function testCreateRedirectResponseWithBadRequestsDomain($url)
         $this->assertTrue($response->isRedirect('http://localhost/'));
     }
 
-    public function badRequestDomainUrls()
+    public static function badRequestDomainUrls()
     {
         return [
             ['http://pirate.net/foo'],
@@ -175,7 +175,7 @@ public function testCreateRequestPassesSecurityContextAttributesToTheNewRequest(
         $this->assertSame('foo', $subRequest->attributes->get($attribute));
     }
 
-    public function provideSecurityContextAttributes()
+    public static function provideSecurityContextAttributes()
     {
         return [
             [Security::AUTHENTICATION_ERROR],
diff --git a/Tests/LoginLink/LoginLinkHandlerTest.php b/Tests/LoginLink/LoginLinkHandlerTest.php
@@ -89,7 +89,7 @@ public function testCreateLoginLink($user, array $extraProperties, Request $requ
         $this->assertSame('https://example.com/login/verify?user=weaverryan&hash=abchash&expires=1601235000', $loginLink->getUrl());
     }
 
-    public function provideCreateLoginLinkData()
+    public static function provideCreateLoginLinkData()
     {
         yield [
             new TestLoginLinkHandlerUser('weaverryan', 'ryan@symfonycasts.com', 'pwhash'),
diff --git a/Tests/RememberMe/AbstractRememberMeServicesTest.php b/Tests/RememberMe/AbstractRememberMeServicesTest.php
@@ -119,7 +119,7 @@ public function testLogout(array $options)
         $this->assertSame($options['httponly'], $cookie->isHttpOnly());
     }
 
-    public function provideOptionsForLogout()
+    public static function provideOptionsForLogout()
     {
         return [
             [['name' => 'foo', 'path' => '/', 'domain' => null, 'secure' => false, 'httponly' => true]],
@@ -259,7 +259,7 @@ public function testLoginSuccessWhenRememberMeParameterIsPositive($value)
         $service->loginSuccess($request, $response, $token);
     }
 
-    public function getPositiveRememberMeParameterValues()
+    public static function getPositiveRememberMeParameterValues()
     {
         return [
             ['true'],
diff --git a/Tests/RememberMe/TokenBasedRememberMeServicesTest.php b/Tests/RememberMe/TokenBasedRememberMeServicesTest.php
@@ -107,7 +107,7 @@ public function testAutoLogin($username)
         $this->assertEquals('foosecret', $returnedToken->getSecret());
     }
 
-    public function provideUsernamesForAutoLogin()
+    public static function provideUsernamesForAutoLogin()
     {
         return [
             ['foouser', 'Simple username'],

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ public function testAuthenticateRequest($matchingAuthenticatorIndex)`
`119`	`119`	`$this->assertTrue($listenerCalled, 'The CheckPassportEvent listener is not called');`
`120`	`120`	`}`
`121`	`121`
`122`		`- public function provideMatchingAuthenticatorIndex()`
	`122`	`+ public static function provideMatchingAuthenticatorIndex()`
`123`	`123`	`{`
`124`	`124`	`yield [0];`
`125`	`125`	`yield [1];`
`@@ -189,7 +189,7 @@ public function testEraseCredentials($eraseCredentials)`
`189`	`189`	`$manager->authenticateRequest($this->request);`
`190`	`190`	`}`
`191`	`191`
`192`		`- public function provideEraseCredentialsData()`
	`192`	`+ public static function provideEraseCredentialsData()`
`193`	`193`	`{`
`194`	`194`	`yield [true];`
`195`	`195`	`yield [false];`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ public function testSupports(string $loginUrl, Request $request, bool $expected)`
`30`	`30`	`$this->assertSame($expected, $authenticator->supports($request));`
`31`	`31`	`}`
`32`	`32`
`33`		`- public function provideSupportsData(): iterable`
	`33`	`+ public static function provideSupportsData(): iterable`
`34`	`34`	`{`
`35`	`35`	`yield [`
`36`	`36`	`'/login',`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ public function testHandleWhenUsernameLength($username, $ok)`
`60`	`60`	`$this->authenticator->authenticate($request);`
`61`	`61`	`}`
`62`	`62`
`63`		`- public function provideUsernamesForLength()`
	`63`	`+ public static function provideUsernamesForLength()`
`64`	`64`	`{`
`65`	`65`	`yield [str_repeat('x', Security::MAX_USERNAME_LENGTH + 1), false];`
`66`	`66`	`yield [str_repeat('x', Security::MAX_USERNAME_LENGTH - 1), true];`
`@@ -126,7 +126,7 @@ public function testHandleNonStringUsernameWithToString($postOnly)`
`126`	`126`	`$this->authenticator->authenticate($request);`
`127`	`127`	`}`
`128`	`128`
`129`		`- public function postOnlyDataProvider()`
	`129`	`+ public static function postOnlyDataProvider()`
`130`	`130`	`{`
`131`	`131`	`yield [true];`
`132`	`132`	`yield [false];`
`@@ -171,7 +171,7 @@ public function testSupportsFormOnly(string $contentType, bool $shouldSupport)`
`171`	`171`	`$this->assertSame($shouldSupport, $this->authenticator->supports($request));`
`172`	`172`	`}`
`173`	`173`
`174`		`- public function provideContentTypes()`
	`174`	`+ public static function provideContentTypes()`
`175`	`175`	`{`
`176`	`176`	`yield ['application/json', false];`
`177`	`177`	`yield ['application/x-www-form-urlencoded', true];`
Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ public function testHttpBasicServerParametersMissing(array $serverParameters)`
`67`	`67`	`$this->assertFalse($this->authenticator->supports($request));`
`68`	`68`	`}`
`69`	`69`
`70`		`- public function provideMissingHttpBasicServerParameters()`
	`70`	`+ public static function provideMissingHttpBasicServerParameters()`
`71`	`71`	`{`
`72`	`72`	`return [`
`73`	`73`	`[[]],`
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ public function testSupport($request)`
`45`	`45`	`$this->assertTrue($this->authenticator->supports($request));`
`46`	`46`	`}`
`47`	`47`
`48`		`- public function provideSupportData()`
	`48`	`+ public static function provideSupportData()`
`49`	`49`	`{`
`50`	`50`	`yield [new Request([], [], [], [], [], ['HTTP_CONTENT_TYPE' => 'application/json'], '{"username": "dunglas", "password": "foo"}')];`
`51`	`51`
`@@ -64,7 +64,7 @@ public function testSupportsWithCheckPath($request, $result)`
`64`	`64`	`$this->assertSame($result, $this->authenticator->supports($request));`
`65`	`65`	`}`
`66`	`66`
`67`		`- public function provideSupportsWithCheckPathData()`
	`67`	`+ public static function provideSupportsWithCheckPathData()`
`68`	`68`	`{`
`69`	`69`	`yield [Request::create('/api/login', 'GET', [], [], [], ['HTTP_CONTENT_TYPE' => 'application/json']), true];`
`70`	`70`	`yield [Request::create('/login', 'GET', [], [], [], ['HTTP_CONTENT_TYPE' => 'application/json']), false];`
`@@ -104,7 +104,7 @@ public function testAuthenticateInvalid($request, $errorMessage, $exceptionType`
`104`	`104`	`$this->authenticator->authenticate($request);`
`105`	`105`	`}`
`106`	`106`
`107`		`- public function provideInvalidAuthenticateData()`
	`107`	`+ public static function provideInvalidAuthenticateData()`
`108`	`108`	`{`
`109`	`109`	`$request = new Request([], [], [], [], [], ['HTTP_CONTENT_TYPE' => 'application/json']);`
`110`	`110`	`yield [$request, 'Invalid JSON.'];`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public function testSupport(array $options, $request, bool $supported)`
`50`	`50`	`$this->assertEquals($supported, $this->authenticator->supports($request));`
`51`	`51`	`}`
`52`	`52`
`53`		`- public function provideSupportData()`
	`53`	`+ public static function provideSupportData()`
`54`	`54`	`{`
`55`	`55`	`yield [['check_route' => '/validate_link'], Request::create('/validate_link?hash=abc123'), true];`
`56`	`56`	`yield [['check_route' => '/validate_link'], Request::create('/login?hash=abc123'), false];`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ public function testSupports($request, $support)`
`51`	`51`	`$this->assertSame($support, $this->authenticator->supports($request));`
`52`	`52`	`}`
`53`	`53`
`54`		`- public function provideSupportsData()`
	`54`	`+ public static function provideSupportsData()`
`55`	`55`	`{`
`56`	`56`	`yield [Request::create('/'), false];`
`57`	`57`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ public function testAuthenticate(InMemoryUserProvider $userProvider, RemoteUserA`
`64`	`64`	`$this->assertTrue($user->isEqualTo($passport->getUser()));`
`65`	`65`	`}`
`66`	`66`
`67`		`- public function provideAuthenticators()`
	`67`	`+ public static function provideAuthenticators()`
`68`	`68`	`{`
`69`	`69`	`$userProvider = new InMemoryUserProvider();`
`70`	`70`	`yield [$userProvider, new RemoteUserAuthenticator($userProvider, new TokenStorage(), 'main'), 'REMOTE_USER'];`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ public function testStart($httpPort, $httpsPort, $request, $expectedUrl)`
`33`	`33`	`$this->assertEquals($expectedUrl, $response->headers->get('Location'));`
`34`	`34`	`}`
`35`	`35`
`36`		`- public function dataForStart()`
	`36`	`+ public static function dataForStart()`
`37`	`37`	`{`
`38`	`38`	`if (!class_exists(Request::class)) {`
`39`	`39`	`return [[]];`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ public function testPasswordAuthenticated($password, $passwordValid, $result)`
`62`	`62`	`}`
`63`	`63`	`}`
`64`	`64`
`65`		`- public function providePasswords()`
	`65`	`+ public static function providePasswords()`
`66`	`66`	`{`
`67`	`67`	`yield ['ThePa$$word', true, true];`
`68`	`68`	`yield ['Invalid', false, false];`
`@@ -100,7 +100,7 @@ public function testCustomAuthenticated($result)`
`100`	`100`	`}`
`101`	`101`	`}`
`102`	`102`
`103`		`- public function provideCustomAuthenticatedResults()`
	`103`	`+ public static function provideCustomAuthenticatedResults()`
`104`	`104`	`{`
`105`	`105`	`yield [true];`
`106`	`106`	`yield [false];`