[Security] Deprecate the old authentication mechanisms

Author: chalasr

Authentication/AuthenticationManagerInterface.php

@@ -19,6 +19,8 @@
  * which process Token authentication.
  *
  * @author Fabien Potencier <fabien@symfony.com>
+ *
+ * @internal since Symfony 5.3
  */
 interface AuthenticationManagerInterface
 {

Authentication/AuthenticationProviderManager.php

@@ -24,6 +24,8 @@
 use Symfony\Component\Security\Core\User\UserInterface;
 use Symfony\Contracts\EventDispatcher\EventDispatcherInterface;
 
+trigger_deprecation('symfony/security-core', '5.3', 'The "%s" class is deprecated, use the new authenticator system instead.', AuthenticationProviderManager::class);
+
 // Help opcache.preload discover always-needed symbols
 class_exists(AuthenticationEvents::class);
 class_exists(AuthenticationFailureEvent::class);
@@ -35,6 +37,8 @@ class_exists(AuthenticationSuccessEvent::class);
  *
  * @author Fabien Potencier <fabien@symfony.com>
  * @author Johannes M. Schmitt <schmittjoh@gmail.com>
+ *
+ * @deprecated since Symfony 5.3, use the new authenticator system instead
  */
 class AuthenticationProviderManager implements AuthenticationManagerInterface
 {

Authentication/Provider/AnonymousAuthenticationProvider.php

@@ -16,10 +16,14 @@
 use Symfony\Component\Security\Core\Exception\AuthenticationException;
 use Symfony\Component\Security\Core\Exception\BadCredentialsException;
 
+trigger_deprecation('symfony/security-core', '5.3', 'The "%s" class is deprecated, use the new authenticator system instead.', AnonymousAuthenticationProvider::class);
+
 /**
  * AnonymousAuthenticationProvider validates AnonymousToken instances.
  *
  * @author Fabien Potencier <fabien@symfony.com>
+ *
+ * @deprecated since Symfony 5.3, use the new authenticator system instead
  */
 class AnonymousAuthenticationProvider implements AuthenticationProviderInterface
 {

Authentication/Provider/AuthenticationProviderInterface.php

@@ -14,13 +14,17 @@
 use Symfony\Component\Security\Core\Authentication\AuthenticationManagerInterface;
 use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
 
+trigger_deprecation('symfony/security-core', '5.3', 'The "%s" interface is deprecated, use the new authenticator system instead.', AuthenticationProviderInterface::class);
+
 /**
  * AuthenticationProviderInterface is the interface for all authentication
  * providers.
  *
  * Concrete implementations processes specific Token instances.
  *
  * @author Fabien Potencier <fabien@symfony.com>
+ *
+ * @deprecated since Symfony 5.3, use the new authenticator system instead
  */
 interface AuthenticationProviderInterface extends AuthenticationManagerInterface
 {

Authentication/Provider/DaoAuthenticationProvider.php

@@ -24,11 +24,15 @@
 use Symfony\Component\Security\Core\User\UserInterface;
 use Symfony\Component\Security\Core\User\UserProviderInterface;
 
+trigger_deprecation('symfony/security-core', '5.3', 'The "%s" class is deprecated, use the new authenticator system instead.', DaoAuthenticationProvider::class);
+
 /**
  * DaoAuthenticationProvider uses a UserProviderInterface to retrieve the user
  * for a UsernamePasswordToken.
  *
  * @author Fabien Potencier <fabien@symfony.com>
+ *
+ * @deprecated since Symfony 5.3, use the new authenticator system instead
  */
 class DaoAuthenticationProvider extends UserAuthenticationProvider
 {

Authentication/Provider/LdapBindAuthenticationProvider.php

@@ -21,13 +21,17 @@
 use Symfony\Component\Security\Core\User\UserInterface;
 use Symfony\Component\Security\Core\User\UserProviderInterface;
 
+trigger_deprecation('symfony/security-core', '5.3', 'The "%s" class is deprecated, use the new authenticator system instead.', LdapBindAuthenticationProvider::class);
+
 /**
  * LdapBindAuthenticationProvider authenticates a user against an LDAP server.
  *
  * The only way to check user credentials is to try to connect the user with its
  * credentials to the ldap.
  *
  * @author Charles Sarrazin <charles@sarraz.in>
+ *
+ * @deprecated since Symfony 5.3, use the new authenticator system instead
  */
 class LdapBindAuthenticationProvider extends UserAuthenticationProvider
 {

Authentication/Provider/PreAuthenticatedAuthenticationProvider.php

@@ -18,6 +18,8 @@
 use Symfony\Component\Security\Core\User\UserCheckerInterface;
 use Symfony\Component\Security\Core\User\UserProviderInterface;
 
+trigger_deprecation('symfony/security-core', '5.3', 'The "%s" class is deprecated, use the new authenticator system instead.', PreAuthenticatedAuthenticationProvider::class);
+
 /**
  * Processes a pre-authenticated authentication request.
  *
@@ -27,6 +29,8 @@
  * UserNotFoundException, for example.
  *
  * @author Fabien Potencier <fabien@symfony.com>
+ *
+ * @deprecated since Symfony 5.3, use the new authenticator system instead
  */
 class PreAuthenticatedAuthenticationProvider implements AuthenticationProviderInterface
 {

Authentication/Provider/RememberMeAuthenticationProvider.php

@@ -19,6 +19,11 @@
 use Symfony\Component\Security\Core\User\UserCheckerInterface;
 use Symfony\Component\Security\Core\User\UserInterface;
 
+trigger_deprecation('symfony/security-core', '5.3', 'The "%s" class is deprecated, use the new authenticator system instead.', RememberMeAuthenticationProvider::class);
+
+/**
+ * @deprecated since Symfony 5.3, use the new authenticator system instead
+ */
 class RememberMeAuthenticationProvider implements AuthenticationProviderInterface
 {
     private $userChecker;

Authentication/Provider/UserAuthenticationProvider.php

@@ -22,10 +22,14 @@
 use Symfony\Component\Security\Core\User\UserCheckerInterface;
 use Symfony\Component\Security\Core\User\UserInterface;
 
+trigger_deprecation('symfony/security-core', '5.3', 'The "%s" class is deprecated, use the new authenticator system instead.', UserAuthenticationProvider::class);
+
 /**
  * UserProviderInterface retrieves users for UsernamePasswordToken tokens.
  *
  * @author Fabien Potencier <fabien@symfony.com>
+ *
+ * @deprecated since Symfony 5.3, use the new authenticator system instead
  */
 abstract class UserAuthenticationProvider implements AuthenticationProviderInterface
 {

Authentication/Token/AbstractToken.php

@@ -68,7 +68,7 @@ public function getUsername(/* $legacy = true */)
 
     public function getUserIdentifier(): string
     {
-        // method returns "null" in non-legacy mode if not overriden
+        // method returns "null" in non-legacy mode if not overridden
         $username = $this->getUsername(false);
         if (null !== $username) {
             trigger_deprecation('symfony/security-core', '5.3', 'Method "%s::getUsername()" is deprecated, override "getUserIdentifier()" instead.', get_debug_type($this));