Remove all "nullable-by-default-value" setters

Author: nicolas-grekas

Authentication/Token/Storage/TokenStorage.php

@@ -40,7 +40,7 @@ public function getToken(): ?TokenInterface
     public function setToken(TokenInterface $token = null)
     {
         if (1 > \func_num_args()) {
-            trigger_deprecation('symfony/security-core', '6.2', 'Calling "%s()" without any arguments is deprecated. Please explicitly pass null if you want to unset the token.', __METHOD__);
+            trigger_deprecation('symfony/security-core', '6.2', 'Calling "%s()" without any arguments is deprecated, pass null explicitly instead.', __METHOD__);
         }
 
         if ($token) {

Authentication/Token/Storage/UsageTrackingTokenStorage.php

@@ -46,10 +46,6 @@ public function getToken(): ?TokenInterface
 
     public function setToken(TokenInterface $token = null): void
     {
-        if (1 > \func_num_args()) {
-            trigger_deprecation('symfony/security-core', '6.2', 'Calling "%s()" without any arguments is deprecated. Please explicitly pass null if you want to unset the token.', __METHOD__);
-        }
-
         $this->storage->setToken($token);
 
         if ($token && $this->shouldTrackUsage()) {

CHANGELOG.md

@@ -6,7 +6,7 @@ CHANGELOG
 
  * Deprecate the `Security` class, use `Symfony\Bundle\SecurityBundle\Security\Security` instead
  * Change the signature of `TokenStorageInterface::setToken()` to `setToken(?TokenInterface $token)`
- * Deprecate calling `TokenStorage::setToken()` or `UsageTrackingTokenStorage::setToken()` without arguments
+ * Deprecate calling `TokenStorage::setToken()` without arguments
 
 6.0
 ---

Tests/Authentication/Token/Storage/TokenStorageTest.php

@@ -27,11 +27,11 @@ class TokenStorageTest extends TestCase
     public function testGetSetTokenLegacy()
     {
         $tokenStorage = new TokenStorage();
-        $token = new UsernamePasswordToken('username', 'password', 'provider');
+        $token = new UsernamePasswordToken(new InMemoryUser('username', 'password'), 'provider');
         $tokenStorage->setToken($token);
         $this->assertSame($token, $tokenStorage->getToken());
 
-        $this->expectDeprecation('Since symfony/security-core 6.2: Calling "Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorage::setToken()" without any arguments is deprecated. Please explicitly pass null if you want to unset the token.');
+        $this->expectDeprecation('Since symfony/security-core 6.2: Calling "Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorage::setToken()" without any arguments is deprecated, pass null explicitly instead.');
 
         $tokenStorage->setToken();
         $this->assertNull($tokenStorage->getToken());