Use short array deconstruction syntax.

Author: derrabus

DependencyInjection/SecurityExtension.php

@@ -239,7 +239,7 @@ private function createFirewalls(array $config, ContainerBuilder $container)
 
             $configId = 'security.firewall.map.config.'.$name;
 
-            list($matcher, $listeners, $exceptionListener, $logoutListener) = $this->createFirewall($container, $name, $firewall, $authenticationProviders, $providerIds, $configId);
+            [$matcher, $listeners, $exceptionListener, $logoutListener] = $this->createFirewall($container, $name, $firewall, $authenticationProviders, $providerIds, $configId);
 
             $contextId = 'security.firewall.map.context.'.$name;
             $context = new ChildDefinition($firewall['stateless'] || empty($firewall['anonymous']['lazy']) ? 'security.firewall.context' : 'security.firewall.lazy_context');
@@ -397,7 +397,7 @@ private function createFirewall(ContainerBuilder $container, string $id, array $
         $configuredEntryPoint = isset($firewall['entry_point']) ? $firewall['entry_point'] : null;
 
         // Authentication listeners
-        list($authListeners, $defaultEntryPoint) = $this->createAuthenticationListeners($container, $id, $firewall, $authenticationProviders, $defaultProvider, $providerIds, $configuredEntryPoint, $contextListenerId);
+        [$authListeners, $defaultEntryPoint] = $this->createAuthenticationListeners($container, $id, $firewall, $authenticationProviders, $defaultProvider, $providerIds, $configuredEntryPoint, $contextListenerId);
 
         $config->replaceArgument(7, $configuredEntryPoint ?: $defaultEntryPoint);
 
@@ -479,7 +479,7 @@ private function createAuthenticationListeners(ContainerBuilder $container, stri
                         throw new InvalidConfigurationException(sprintf('Not configuring explicitly the provider for the "%s" listener on "%s" firewall is ambiguous as there is more than one registered provider.', $key, $id));
                     }
 
-                    list($provider, $listenerId, $defaultEntryPoint) = $factory->create($container, $id, $firewall[$key], $userProvider, $defaultEntryPoint);
+                    [$provider, $listenerId, $defaultEntryPoint] = $factory->create($container, $id, $firewall[$key], $userProvider, $defaultEntryPoint);
 
                     $listeners[] = new Reference($listenerId);
                     $authenticationProviders[] = $provider;

Tests/DependencyInjection/CompleteConfigurationTest.php

@@ -236,7 +236,7 @@ public function testAccess()
         }
 
         $matcherIds = [];
-        foreach ($rules as list($matcherId, $attributes, $channel)) {
+        foreach ($rules as [$matcherId, $attributes, $channel]) {
             $requestMatcher = $container->getDefinition($matcherId);
 
             $this->assertArrayNotHasKey($matcherId, $matcherIds);

Tests/DependencyInjection/Security/Factory/AbstractFactoryTest.php

@@ -19,7 +19,7 @@ class AbstractFactoryTest extends TestCase
 {
     public function testCreate()
     {
-        list($container, $authProviderId, $listenerId, $entryPointId) = $this->callFactory('foo', [
+        [$container, $authProviderId, $listenerId, $entryPointId] = $this->callFactory('foo', [
             'use_forward' => true,
             'failure_path' => '/foo',
             'success_handler' => 'custom_success_handler',
@@ -61,7 +61,7 @@ public function testDefaultFailureHandler($serviceId, $defaultHandlerInjection)
             $options['failure_handler'] = $serviceId;
         }
 
-        list($container) = $this->callFactory('foo', $options, 'user_provider', 'entry_point');
+        [$container] = $this->callFactory('foo', $options, 'user_provider', 'entry_point');
 
         $definition = $container->getDefinition('abstract_listener.foo');
         $arguments = $definition->getArguments();
@@ -99,7 +99,7 @@ public function testDefaultSuccessHandler($serviceId, $defaultHandlerInjection)
             $options['success_handler'] = $serviceId;
         }
 
-        list($container) = $this->callFactory('foo', $options, 'user_provider', 'entry_point');
+        [$container] = $this->callFactory('foo', $options, 'user_provider', 'entry_point');
 
         $definition = $container->getDefinition('abstract_listener.foo');
         $arguments = $definition->getArguments();
@@ -150,7 +150,7 @@ protected function callFactory($id, $config, $userProviderId, $defaultEntryPoint
         $container->register('custom_success_handler');
         $container->register('custom_failure_handler');
 
-        list($authProviderId, $listenerId, $entryPointId) = $factory->create($container, $id, $config, $userProviderId, $defaultEntryPointId);
+        [$authProviderId, $listenerId, $entryPointId] = $factory->create($container, $id, $config, $userProviderId, $defaultEntryPointId);
 
         return [$container, $authProviderId, $listenerId, $entryPointId];
     }

Tests/DependencyInjection/Security/Factory/GuardAuthenticationFactoryTest.php

@@ -103,7 +103,7 @@ public function testBasicCreate()
             'authenticators' => ['authenticator123'],
             'entry_point' => null,
         ];
-        list($container, $entryPointId) = $this->executeCreate($config, null);
+        [$container, $entryPointId] = $this->executeCreate($config, null);
         $this->assertEquals('authenticator123', $entryPointId);
 
         $providerDefinition = $container->getDefinition('security.authentication.provider.guard.my_firewall');
@@ -126,7 +126,7 @@ public function testExistingDefaultEntryPointUsed()
             'authenticators' => ['authenticator123'],
             'entry_point' => null,
         ];
-        list(, $entryPointId) = $this->executeCreate($config, 'some_default_entry_point');
+        [, $entryPointId] = $this->executeCreate($config, 'some_default_entry_point');
         $this->assertEquals('some_default_entry_point', $entryPointId);
     }
 
@@ -159,7 +159,7 @@ public function testCreateWithEntryPoint()
             'authenticators' => ['authenticator123', 'authenticatorABC'],
             'entry_point' => 'authenticatorABC',
         ];
-        list(, $entryPointId) = $this->executeCreate($config, null);
+        [, $entryPointId] = $this->executeCreate($config, null);
         $this->assertEquals('authenticatorABC', $entryPointId);
     }
 
@@ -172,7 +172,7 @@ private function executeCreate(array $config, $defaultEntryPointId)
         $userProviderId = 'my_user_provider';
 
         $factory = new GuardAuthenticationFactory();
-        list(, , $entryPointId) = $factory->create($container, $id, $config, $userProviderId, $defaultEntryPointId);
+        [, , $entryPointId] = $factory->create($container, $id, $config, $userProviderId, $defaultEntryPointId);
 
         return [$container, $entryPointId];
     }