Add missing return types to tests/internal/final methods

nicolas-grekas · nicolas-grekas · commit db22e7d69658 · 2021-08-18T10:03:57.000+02:00
diff --git a/Tests/DependencyInjection/Compiler/RegisterEntryPointsPassTest.php b/Tests/DependencyInjection/Compiler/RegisterEntryPointsPassTest.php
@@ -93,7 +93,7 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio
         ], JsonResponse::HTTP_FORBIDDEN);
     }
 
-    public function start(Request $request, AuthenticationException $authException = null)
+    public function start(Request $request, AuthenticationException $authException = null): Response
     {
     }
 }
diff --git a/Tests/DependencyInjection/SecurityExtensionTest.php b/Tests/DependencyInjection/SecurityExtensionTest.php
@@ -36,6 +36,7 @@
 use Symfony\Component\Security\Core\User\UserInterface;
 use Symfony\Component\Security\Core\User\UserProviderInterface;
 use Symfony\Component\Security\Guard\AuthenticatorInterface as GuardAuthenticatorInterface;
+use Symfony\Component\Security\Guard\Token\GuardTokenInterface;
 use Symfony\Component\Security\Http\Authenticator\AuthenticatorInterface;
 use Symfony\Component\Security\Http\Authenticator\HttpBasicAuthenticator;
 use Symfony\Component\Security\Http\Authenticator\Passport\Passport;
@@ -865,39 +866,39 @@ public function createToken(Passport $passport, string $firewallName): TokenInte
 
 class NullAuthenticator implements GuardAuthenticatorInterface
 {
-    public function start(Request $request, AuthenticationException $authException = null)
+    public function start(Request $request, AuthenticationException $authException = null): Response
     {
     }
 
-    public function supports(Request $request)
+    public function supports(Request $request): bool
     {
     }
 
     public function getCredentials(Request $request)
     {
     }
 
-    public function getUser($credentials, UserProviderInterface $userProvider)
+    public function getUser($credentials, UserProviderInterface $userProvider): ?UserInterface
     {
     }
 
-    public function checkCredentials($credentials, UserInterface $user)
+    public function checkCredentials($credentials, UserInterface $user): bool
     {
     }
 
-    public function createAuthenticatedToken(UserInterface $user, string $providerKey)
+    public function createAuthenticatedToken(UserInterface $user, string $providerKey): GuardTokenInterface
     {
     }
 
-    public function onAuthenticationFailure(Request $request, AuthenticationException $exception)
+    public function onAuthenticationFailure(Request $request, AuthenticationException $exception): ?Response
     {
     }
 
-    public function onAuthenticationSuccess(Request $request, TokenInterface $token, string $providerKey)
+    public function onAuthenticationSuccess(Request $request, TokenInterface $token, string $providerKey): ?Response
     {
     }
 
-    public function supportsRememberMe()
+    public function supportsRememberMe(): bool
     {
     }
 }
@@ -922,20 +923,20 @@ public function createListeners(ContainerBuilder $container, string $firewallNam
         return ['custom_firewall_listener_id'];
     }
 
-    public function create(ContainerBuilder $container, string $id, array $config, string $userProvider, ?string $defaultEntryPoint)
+    public function create(ContainerBuilder $container, string $id, array $config, string $userProvider, ?string $defaultEntryPoint): array
     {
         $container->register('provider_id', \stdClass::class);
         $container->register('listener_id', \stdClass::class);
 
         return ['provider_id', 'listener_id', $defaultEntryPoint];
     }
 
-    public function getPosition()
+    public function getPosition(): string
     {
         return 'form';
     }
 
-    public function getKey()
+    public function getKey(): string
     {
         return 'custom_listener';
     }
diff --git a/Tests/Functional/Bundle/AnonymousBundle/AppCustomAuthenticator.php b/Tests/Functional/Bundle/AnonymousBundle/AppCustomAuthenticator.php
@@ -21,7 +21,7 @@
 
 class AppCustomAuthenticator extends AbstractGuardAuthenticator
 {
-    public function supports(Request $request)
+    public function supports(Request $request): bool
     {
         return false;
     }
@@ -30,28 +30,28 @@ public function getCredentials(Request $request)
     {
     }
 
-    public function getUser($credentials, UserProviderInterface $userProvider)
+    public function getUser($credentials, UserProviderInterface $userProvider): ?UserInterface
     {
     }
 
-    public function checkCredentials($credentials, UserInterface $user)
+    public function checkCredentials($credentials, UserInterface $user): bool
     {
     }
 
-    public function onAuthenticationFailure(Request $request, AuthenticationException $exception)
+    public function onAuthenticationFailure(Request $request, AuthenticationException $exception): ?Response
     {
     }
 
-    public function onAuthenticationSuccess(Request $request, TokenInterface $token, $providerKey)
+    public function onAuthenticationSuccess(Request $request, TokenInterface $token, $providerKey): ?Response
     {
     }
 
-    public function start(Request $request, AuthenticationException $authException = null)
+    public function start(Request $request, AuthenticationException $authException = null): Response
     {
         return new Response($authException->getMessage(), Response::HTTP_UNAUTHORIZED);
     }
 
-    public function supportsRememberMe()
+    public function supportsRememberMe(): bool
     {
     }
 }
diff --git a/Tests/Functional/Bundle/CsrfFormLoginBundle/Controller/LoginController.php b/Tests/Functional/Bundle/CsrfFormLoginBundle/Controller/LoginController.php
@@ -54,7 +54,7 @@ public function secureAction()
     /**
      * {@inheritdoc}
      */
-    public static function getSubscribedServices()
+    public static function getSubscribedServices(): array
     {
         return [
             'form.factory' => FormFactoryInterface::class,
diff --git a/Tests/Functional/Bundle/FormLoginBundle/Controller/LocalizedController.php b/Tests/Functional/Bundle/FormLoginBundle/Controller/LocalizedController.php
@@ -71,7 +71,7 @@ public function homepageAction()
     /**
      * {@inheritdoc}
      */
-    public static function getSubscribedServices()
+    public static function getSubscribedServices(): array
     {
         return [
             'twig' => Environment::class,
diff --git a/Tests/Functional/Bundle/FormLoginBundle/Controller/LoginController.php b/Tests/Functional/Bundle/FormLoginBundle/Controller/LoginController.php
@@ -63,7 +63,7 @@ public function secureAction()
     /**
      * {@inheritdoc}
      */
-    public static function getSubscribedServices()
+    public static function getSubscribedServices(): array
     {
         return [
             'twig' => Environment::class,
diff --git a/Tests/Functional/Bundle/GuardedBundle/AppCustomAuthenticator.php b/Tests/Functional/Bundle/GuardedBundle/AppCustomAuthenticator.php
@@ -21,7 +21,7 @@
 
 class AppCustomAuthenticator extends AbstractGuardAuthenticator
 {
-    public function supports(Request $request)
+    public function supports(Request $request): bool
     {
         return '/manual_login' !== $request->getPathInfo() && '/profile' !== $request->getPathInfo();
     }
@@ -31,29 +31,29 @@ public function getCredentials(Request $request)
         throw new AuthenticationException('This should be hit');
     }
 
-    public function getUser($credentials, UserProviderInterface $userProvider)
+    public function getUser($credentials, UserProviderInterface $userProvider): ?UserInterface
     {
     }
 
-    public function checkCredentials($credentials, UserInterface $user)
+    public function checkCredentials($credentials, UserInterface $user): bool
     {
     }
 
-    public function onAuthenticationFailure(Request $request, AuthenticationException $exception)
+    public function onAuthenticationFailure(Request $request, AuthenticationException $exception): ?Response
     {
         return new Response('', 418);
     }
 
-    public function onAuthenticationSuccess(Request $request, TokenInterface $token, $providerKey)
+    public function onAuthenticationSuccess(Request $request, TokenInterface $token, $providerKey): ?Response
     {
     }
 
-    public function start(Request $request, AuthenticationException $authException = null)
+    public function start(Request $request, AuthenticationException $authException = null): Response
     {
         return new Response($authException->getMessage(), Response::HTTP_UNAUTHORIZED);
     }
 
-    public function supportsRememberMe()
+    public function supportsRememberMe(): bool
     {
     }
 }
diff --git a/Tests/Functional/Bundle/LoginLink/TestCustomLoginLinkSuccessHandler.php b/Tests/Functional/Bundle/LoginLink/TestCustomLoginLinkSuccessHandler.php
@@ -4,12 +4,13 @@
 
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
 use Symfony\Component\Security\Http\Authentication\AuthenticationSuccessHandlerInterface;
 
 class TestCustomLoginLinkSuccessHandler implements AuthenticationSuccessHandlerInterface
 {
-    public function onAuthenticationSuccess(Request $request, TokenInterface $token)
+    public function onAuthenticationSuccess(Request $request, TokenInterface $token): Response
     {
         return new JsonResponse(['message' => sprintf('Welcome %s!', $token->getUserIdentifier())]);
     }
diff --git a/Tests/Functional/Bundle/RememberMeBundle/Security/StaticTokenProvider.php b/Tests/Functional/Bundle/RememberMeBundle/Security/StaticTokenProvider.php
@@ -29,7 +29,7 @@ public function __construct($kernel)
         }
     }
 
-    public function loadTokenBySeries(string $series)
+    public function loadTokenBySeries(string $series): PersistentTokenInterface
     {
         $token = self::$db[$series] ?? false;
         if (!$token) {
diff --git a/Tests/Functional/Bundle/RememberMeBundle/Security/UserChangingUserProvider.php b/Tests/Functional/Bundle/RememberMeBundle/Security/UserChangingUserProvider.php
@@ -26,7 +26,7 @@ public function __construct(InMemoryUserProvider $inner)
         $this->inner = $inner;
     }
 
-    public function loadUserByUsername($username)
+    public function loadUserByUsername($username): UserInterface
     {
         return $this->inner->loadUserByUsername($username);
     }
@@ -36,7 +36,7 @@ public function loadUserByIdentifier(string $userIdentifier): UserInterface
         return $this->inner->loadUserByIdentifier($userIdentifier);
     }
 
-    public function refreshUser(UserInterface $user)
+    public function refreshUser(UserInterface $user): UserInterface
     {
         $user = $this->inner->refreshUser($user);
 
@@ -46,7 +46,7 @@ public function refreshUser(UserInterface $user)
         return $user;
     }
 
-    public function supportsClass($class)
+    public function supportsClass($class): bool
     {
         return $this->inner->supportsClass($class);
     }
diff --git a/Tests/Functional/Bundle/SecuredPageBundle/Security/Core/User/ArrayUserProvider.php b/Tests/Functional/Bundle/SecuredPageBundle/Security/Core/User/ArrayUserProvider.php
@@ -29,7 +29,7 @@ public function getUser($username)
         return $this->users[$username];
     }
 
-    public function loadUserByUsername($username)
+    public function loadUserByUsername($username): UserInterface
     {
         return $this->loadUserByIdentifier($username);
     }
@@ -48,7 +48,7 @@ public function loadUserByIdentifier(string $identifier): UserInterface
         return $user;
     }
 
-    public function refreshUser(UserInterface $user)
+    public function refreshUser(UserInterface $user): UserInterface
     {
         if (!$user instanceof UserInterface) {
             throw new UnsupportedUserException(sprintf('Instances of "%s" are not supported.', get_debug_type($user)));
@@ -60,7 +60,7 @@ public function refreshUser(UserInterface $user)
         return new $class($storedUser->getUserIdentifier(), $storedUser->getPassword(), $storedUser->getRoles(), $storedUser->isEnabled());
     }
 
-    public function supportsClass($class)
+    public function supportsClass($class): bool
     {
         return InMemoryUser::class === $class || UserWithoutEquatable::class === $class;
     }
diff --git a/Tests/Functional/SecurityTest.php b/Tests/Functional/SecurityTest.php
@@ -161,7 +161,7 @@ public function __toString()
     /**
      * {@inheritdoc}
      */
-    public function getRoles()
+    public function getRoles(): array
     {
         return $this->roles;
     }

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio`
`93`	`93`	`], JsonResponse::HTTP_FORBIDDEN);`
`94`	`94`	`}`
`95`	`95`
`96`		`- public function start(Request $request, AuthenticationException $authException = null)`
	`96`	`+ public function start(Request $request, AuthenticationException $authException = null): Response`
`97`	`97`	`{`
`98`	`98`	`}`
`99`	`99`	`}`
Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,7 @@`
`36`	`36`	`use Symfony\Component\Security\Core\User\UserInterface;`
`37`	`37`	`use Symfony\Component\Security\Core\User\UserProviderInterface;`
`38`	`38`	`use Symfony\Component\Security\Guard\AuthenticatorInterface as GuardAuthenticatorInterface;`
	`39`	`+use Symfony\Component\Security\Guard\Token\GuardTokenInterface;`
`39`	`40`	`use Symfony\Component\Security\Http\Authenticator\AuthenticatorInterface;`
`40`	`41`	`use Symfony\Component\Security\Http\Authenticator\HttpBasicAuthenticator;`
`41`	`42`	`use Symfony\Component\Security\Http\Authenticator\Passport\Passport;`
`@@ -865,39 +866,39 @@ public function createToken(Passport $passport, string $firewallName): TokenInte`
`865`	`866`
`866`	`867`	`class NullAuthenticator implements GuardAuthenticatorInterface`
`867`	`868`	`{`
`868`		`- public function start(Request $request, AuthenticationException $authException = null)`
	`869`	`+ public function start(Request $request, AuthenticationException $authException = null): Response`
`869`	`870`	`{`
`870`	`871`	`}`
`871`	`872`
`872`		`- public function supports(Request $request)`
	`873`	`+ public function supports(Request $request): bool`
`873`	`874`	`{`
`874`	`875`	`}`
`875`	`876`
`876`	`877`	`public function getCredentials(Request $request)`
`877`	`878`	`{`
`878`	`879`	`}`
`879`	`880`
`880`		`- public function getUser($credentials, UserProviderInterface $userProvider)`
	`881`	`+ public function getUser($credentials, UserProviderInterface $userProvider): ?UserInterface`
`881`	`882`	`{`
`882`	`883`	`}`
`883`	`884`
`884`		`- public function checkCredentials($credentials, UserInterface $user)`
	`885`	`+ public function checkCredentials($credentials, UserInterface $user): bool`
`885`	`886`	`{`
`886`	`887`	`}`
`887`	`888`
`888`		`- public function createAuthenticatedToken(UserInterface $user, string $providerKey)`
	`889`	`+ public function createAuthenticatedToken(UserInterface $user, string $providerKey): GuardTokenInterface`
`889`	`890`	`{`
`890`	`891`	`}`
`891`	`892`
`892`		`- public function onAuthenticationFailure(Request $request, AuthenticationException $exception)`
	`893`	`+ public function onAuthenticationFailure(Request $request, AuthenticationException $exception): ?Response`
`893`	`894`	`{`
`894`	`895`	`}`
`895`	`896`
`896`		`- public function onAuthenticationSuccess(Request $request, TokenInterface $token, string $providerKey)`
	`897`	`+ public function onAuthenticationSuccess(Request $request, TokenInterface $token, string $providerKey): ?Response`
`897`	`898`	`{`
`898`	`899`	`}`
`899`	`900`
`900`		`- public function supportsRememberMe()`
	`901`	`+ public function supportsRememberMe(): bool`
`901`	`902`	`{`
`902`	`903`	`}`
`903`	`904`	`}`
`@@ -922,20 +923,20 @@ public function createListeners(ContainerBuilder $container, string $firewallNam`
`922`	`923`	`return ['custom_firewall_listener_id'];`
`923`	`924`	`}`
`924`	`925`
`925`		`- public function create(ContainerBuilder $container, string $id, array $config, string $userProvider, ?string $defaultEntryPoint)`
	`926`	`+ public function create(ContainerBuilder $container, string $id, array $config, string $userProvider, ?string $defaultEntryPoint): array`
`926`	`927`	`{`
`927`	`928`	`$container->register('provider_id', \stdClass::class);`
`928`	`929`	`$container->register('listener_id', \stdClass::class);`
`929`	`930`
`930`	`931`	`return ['provider_id', 'listener_id', $defaultEntryPoint];`
`931`	`932`	`}`
`932`	`933`
`933`		`- public function getPosition()`
	`934`	`+ public function getPosition(): string`
`934`	`935`	`{`
`935`	`936`	`return 'form';`
`936`	`937`	`}`
`937`	`938`
`938`		`- public function getKey()`
	`939`	`+ public function getKey(): string`
`939`	`940`	`{`
`940`	`941`	`return 'custom_listener';`
`941`	`942`	`}`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@`
`21`	`21`
`22`	`22`	`class AppCustomAuthenticator extends AbstractGuardAuthenticator`
`23`	`23`	`{`
`24`		`- public function supports(Request $request)`
	`24`	`+ public function supports(Request $request): bool`
`25`	`25`	`{`
`26`	`26`	`return false;`
`27`	`27`	`}`
`@@ -30,28 +30,28 @@ public function getCredentials(Request $request)`
`30`	`30`	`{`
`31`	`31`	`}`
`32`	`32`
`33`		`- public function getUser($credentials, UserProviderInterface $userProvider)`
	`33`	`+ public function getUser($credentials, UserProviderInterface $userProvider): ?UserInterface`
`34`	`34`	`{`
`35`	`35`	`}`
`36`	`36`
`37`		`- public function checkCredentials($credentials, UserInterface $user)`
	`37`	`+ public function checkCredentials($credentials, UserInterface $user): bool`
`38`	`38`	`{`
`39`	`39`	`}`
`40`	`40`
`41`		`- public function onAuthenticationFailure(Request $request, AuthenticationException $exception)`
	`41`	`+ public function onAuthenticationFailure(Request $request, AuthenticationException $exception): ?Response`
`42`	`42`	`{`
`43`	`43`	`}`
`44`	`44`
`45`		`- public function onAuthenticationSuccess(Request $request, TokenInterface $token, $providerKey)`
	`45`	`+ public function onAuthenticationSuccess(Request $request, TokenInterface $token, $providerKey): ?Response`
`46`	`46`	`{`
`47`	`47`	`}`
`48`	`48`
`49`		`- public function start(Request $request, AuthenticationException $authException = null)`
	`49`	`+ public function start(Request $request, AuthenticationException $authException = null): Response`
`50`	`50`	`{`
`51`	`51`	`return new Response($authException->getMessage(), Response::HTTP_UNAUTHORIZED);`
`52`	`52`	`}`
`53`	`53`
`54`		`- public function supportsRememberMe()`
	`54`	`+ public function supportsRememberMe(): bool`
`55`	`55`	`{`
`56`	`56`	`}`
`57`	`57`	`}`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ public function secureAction()`
`54`	`54`	`/**`
`55`	`55`	`* {@inheritdoc}`
`56`	`56`	`*/`
`57`		`- public static function getSubscribedServices()`
	`57`	`+ public static function getSubscribedServices(): array`
`58`	`58`	`{`
`59`	`59`	`return [`
`60`	`60`	`'form.factory' => FormFactoryInterface::class,`
Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ public function homepageAction()`
`71`	`71`	`/**`
`72`	`72`	`* {@inheritdoc}`
`73`	`73`	`*/`
`74`		`- public static function getSubscribedServices()`
	`74`	`+ public static function getSubscribedServices(): array`
`75`	`75`	`{`
`76`	`76`	`return [`
`77`	`77`	`'twig' => Environment::class,`
Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ public function secureAction()`
`63`	`63`	`/**`
`64`	`64`	`* {@inheritdoc}`
`65`	`65`	`*/`
`66`		`- public static function getSubscribedServices()`
	`66`	`+ public static function getSubscribedServices(): array`
`67`	`67`	`{`
`68`	`68`	`return [`
`69`	`69`	`'twig' => Environment::class,`
Original file line number	Diff line number	Diff line change
`@@ -4,12 +4,13 @@`
`4`	`4`
`5`	`5`	`use Symfony\Component\HttpFoundation\JsonResponse;`
`6`	`6`	`use Symfony\Component\HttpFoundation\Request;`
	`7`	`+use Symfony\Component\HttpFoundation\Response;`
`7`	`8`	`use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;`
`8`	`9`	`use Symfony\Component\Security\Http\Authentication\AuthenticationSuccessHandlerInterface;`
`9`	`10`
`10`	`11`	`class TestCustomLoginLinkSuccessHandler implements AuthenticationSuccessHandlerInterface`
`11`	`12`	`{`
`12`		`- public function onAuthenticationSuccess(Request $request, TokenInterface $token)`
	`13`	`+ public function onAuthenticationSuccess(Request $request, TokenInterface $token): Response`
`13`	`14`	`{`
`14`	`15`	`return new JsonResponse(['message' => sprintf('Welcome %s!', $token->getUserIdentifier())]);`
`15`	`16`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public function __construct($kernel)`
`29`	`29`	`}`
`30`	`30`	`}`
`31`	`31`
`32`		`- public function loadTokenBySeries(string $series)`
	`32`	`+ public function loadTokenBySeries(string $series): PersistentTokenInterface`
`33`	`33`	`{`
`34`	`34`	`$token = self::$db[$series] ?? false;`
`35`	`35`	`if (!$token) {`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ public function __construct(InMemoryUserProvider $inner)`
`26`	`26`	`$this->inner = $inner;`
`27`	`27`	`}`
`28`	`28`
`29`		`- public function loadUserByUsername($username)`
	`29`	`+ public function loadUserByUsername($username): UserInterface`
`30`	`30`	`{`
`31`	`31`	`return $this->inner->loadUserByUsername($username);`
`32`	`32`	`}`
`@@ -36,7 +36,7 @@ public function loadUserByIdentifier(string $userIdentifier): UserInterface`
`36`	`36`	`return $this->inner->loadUserByIdentifier($userIdentifier);`
`37`	`37`	`}`
`38`	`38`
`39`		`- public function refreshUser(UserInterface $user)`
	`39`	`+ public function refreshUser(UserInterface $user): UserInterface`
`40`	`40`	`{`
`41`	`41`	`$user = $this->inner->refreshUser($user);`
`42`	`42`
`@@ -46,7 +46,7 @@ public function refreshUser(UserInterface $user)`
`46`	`46`	`return $user;`
`47`	`47`	`}`
`48`	`48`
`49`		`- public function supportsClass($class)`
	`49`	`+ public function supportsClass($class): bool`
`50`	`50`	`{`
`51`	`51`	`return $this->inner->supportsClass($class);`
`52`	`52`	`}`