[SecurityBundle] Simplify LDAP factories

Author: wouterj

DependencyInjection/Security/Factory/FormLoginLdapFactory.php

@@ -67,9 +67,4 @@ public function addConfiguration(NodeDefinition $node)
             ->end()
         ;
     }
-
-    public function getKey()
-    {
-        return 'form-login-ldap';
-    }
 }

DependencyInjection/Security/Factory/HttpBasicLdapFactory.php

@@ -84,9 +84,4 @@ public function addConfiguration(NodeDefinition $node)
             ->end()
         ;
     }
-
-    public function getKey()
-    {
-        return 'http-basic-ldap';
-    }
 }

DependencyInjection/Security/Factory/JsonLoginLdapFactory.php

@@ -26,11 +26,6 @@ class JsonLoginLdapFactory extends JsonLoginFactory
 {
     use LdapFactoryTrait;
 
-    public function getKey()
-    {
-        return 'json-login-ldap';
-    }
-
     protected function createAuthProvider(ContainerBuilder $container, string $id, array $config, string $userProviderId)
     {
         $provider = 'security.authentication.provider.ldap_bind.'.$id;

DependencyInjection/Security/Factory/LdapFactoryTrait.php

@@ -27,6 +27,11 @@
  */
 trait LdapFactoryTrait
 {
+    public function getKey(): string
+    {
+        return parent::getKey().'-ldap';
+    }
+
     public function createAuthenticator(ContainerBuilder $container, string $firewallName, array $config, string $userProviderId): string
     {
         $key = str_replace('-', '_', $this->getKey());