Add some missing return types to internal/final classes

nicolas-grekas · nicolas-grekas · commit bcc89ca0fdbf · 2021-08-24T21:02:39.000+02:00
diff --git a/DataCollector/SecurityDataCollector.php b/DataCollector/SecurityDataCollector.php
@@ -232,20 +232,16 @@ public function lateCollect()
 
     /**
      * Checks if security is enabled.
-     *
-     * @return bool
      */
-    public function isEnabled()
+    public function isEnabled(): bool
     {
         return $this->data['enabled'];
     }
 
     /**
      * Gets the user.
-     *
-     * @return string
      */
-    public function getUser()
+    public function getUser(): string
     {
         return $this->data['user'];
     }
@@ -273,44 +269,31 @@ public function getInheritedRoles()
     /**
      * Checks if the data contains information about inherited roles. Still the inherited
      * roles can be an empty array.
-     *
-     * @return bool
      */
-    public function supportsRoleHierarchy()
+    public function supportsRoleHierarchy(): bool
     {
         return $this->data['supports_role_hierarchy'];
     }
 
     /**
      * Checks if the user is authenticated or not.
-     *
-     * @return bool
      */
-    public function isAuthenticated()
+    public function isAuthenticated(): bool
     {
         return $this->data['authenticated'];
     }
 
-    /**
-     * @return bool
-     */
-    public function isImpersonated()
+    public function isImpersonated(): bool
     {
         return $this->data['impersonated'];
     }
 
-    /**
-     * @return string|null
-     */
-    public function getImpersonatorUser()
+    public function getImpersonatorUser(): ?string
     {
         return $this->data['impersonator_user'];
     }
 
-    /**
-     * @return string|null
-     */
-    public function getImpersonationExitPath()
+    public function getImpersonationExitPath(): ?string
     {
         return $this->data['impersonation_exit_path'];
     }
@@ -327,20 +310,16 @@ public function getTokenClass()
 
     /**
      * Get the full security token class as Data object.
-     *
-     * @return Data|null
      */
-    public function getToken()
+    public function getToken(): ?Data
     {
         return $this->data['token'];
     }
 
     /**
      * Get the logout URL.
-     *
-     * @return string|null
      */
-    public function getLogoutUrl()
+    public function getLogoutUrl(): ?string
     {
         return $this->data['logout_url'];
     }
@@ -357,10 +336,8 @@ public function getVoters()
 
     /**
      * Returns the strategy configured for the security voters.
-     *
-     * @return string
      */
-    public function getVoterStrategy()
+    public function getVoterStrategy(): string
     {
         return $this->data['voter_strategy'];
     }
@@ -396,7 +373,7 @@ public function getListeners()
     /**
      * {@inheritdoc}
      */
-    public function getName()
+    public function getName(): string
     {
         return 'security';
     }
diff --git a/DependencyInjection/Security/Factory/AnonymousFactory.php b/DependencyInjection/Security/Factory/AnonymousFactory.php
@@ -20,8 +20,6 @@
 /**
  * @author Wouter de Jong <wouter@wouterj.nl>
  *
- * @internal
- *
  * @deprecated since Symfony 5.3, use the new authenticator system instead
  */
 class AnonymousFactory implements SecurityFactoryInterface, AuthenticatorFactoryInterface
diff --git a/DependencyInjection/Security/Factory/CustomAuthenticatorFactory.php b/DependencyInjection/Security/Factory/CustomAuthenticatorFactory.php
@@ -22,7 +22,7 @@
  */
 class CustomAuthenticatorFactory implements AuthenticatorFactoryInterface, SecurityFactoryInterface
 {
-    public function create(ContainerBuilder $container, string $id, array $config, string $userProvider, ?string $defaultEntryPoint)
+    public function create(ContainerBuilder $container, string $id, array $config, string $userProvider, ?string $defaultEntryPoint): array
     {
         throw new \LogicException('Custom authenticators are not supported when "security.enable_authenticator_manager" is not set to true.');
     }
diff --git a/DependencyInjection/Security/Factory/FormLoginFactory.php b/DependencyInjection/Security/Factory/FormLoginFactory.php
@@ -44,12 +44,12 @@ public function getPriority(): int
         return self::PRIORITY;
     }
 
-    public function getPosition()
+    public function getPosition(): string
     {
         return 'form';
     }
 
-    public function getKey()
+    public function getKey(): string
     {
         return 'form-login';
     }
@@ -65,12 +65,12 @@ public function addConfiguration(NodeDefinition $node)
         ;
     }
 
-    protected function getListenerId()
+    protected function getListenerId(): string
     {
         return 'security.authentication.listener.form';
     }
 
-    protected function createAuthProvider(ContainerBuilder $container, string $id, array $config, string $userProviderId)
+    protected function createAuthProvider(ContainerBuilder $container, string $id, array $config, string $userProviderId): string
     {
         if ($config['enable_csrf'] ?? false) {
             throw new InvalidConfigurationException('The "enable_csrf" option of "form_login" is only available when "security.enable_authenticator_manager" is set to "true", use "csrf_token_generator" instead.');
@@ -99,7 +99,7 @@ protected function createListener(ContainerBuilder $container, string $id, array
         return $listenerId;
     }
 
-    protected function createEntryPoint(ContainerBuilder $container, string $id, array $config, ?string $defaultEntryPointId)
+    protected function createEntryPoint(ContainerBuilder $container, string $id, array $config, ?string $defaultEntryPointId): ?string
     {
         $entryPointId = 'security.authentication.form_entry_point.'.$id;
         $container
diff --git a/DependencyInjection/Security/Factory/FormLoginLdapFactory.php b/DependencyInjection/Security/Factory/FormLoginLdapFactory.php
@@ -29,7 +29,7 @@ class FormLoginLdapFactory extends FormLoginFactory
 {
     use LdapFactoryTrait;
 
-    protected function createAuthProvider(ContainerBuilder $container, string $id, array $config, string $userProviderId)
+    protected function createAuthProvider(ContainerBuilder $container, string $id, array $config, string $userProviderId): string
     {
         $provider = 'security.authentication.provider.ldap_bind.'.$id;
         $definition = $container
diff --git a/DependencyInjection/Security/Factory/GuardAuthenticationFactory.php b/DependencyInjection/Security/Factory/GuardAuthenticationFactory.php
@@ -29,7 +29,7 @@
  */
 class GuardAuthenticationFactory implements SecurityFactoryInterface, AuthenticatorFactoryInterface
 {
-    public function getPosition()
+    public function getPosition(): string
     {
         return 'pre_auth';
     }
@@ -39,7 +39,7 @@ public function getPriority(): int
         return 0;
     }
 
-    public function getKey()
+    public function getKey(): string
     {
         return 'guard';
     }
@@ -65,7 +65,7 @@ public function addConfiguration(NodeDefinition $node)
         ;
     }
 
-    public function create(ContainerBuilder $container, string $id, array $config, string $userProvider, ?string $defaultEntryPoint)
+    public function create(ContainerBuilder $container, string $id, array $config, string $userProvider, ?string $defaultEntryPoint): array
     {
         $authenticatorIds = $config['authenticators'];
         $authenticatorReferences = [];
diff --git a/DependencyInjection/Security/Factory/HttpBasicFactory.php b/DependencyInjection/Security/Factory/HttpBasicFactory.php
@@ -27,7 +27,7 @@ class HttpBasicFactory implements SecurityFactoryInterface, AuthenticatorFactory
 {
     public const PRIORITY = -50;
 
-    public function create(ContainerBuilder $container, string $id, array $config, string $userProvider, ?string $defaultEntryPoint)
+    public function create(ContainerBuilder $container, string $id, array $config, string $userProvider, ?string $defaultEntryPoint): array
     {
         $provider = 'security.authentication.provider.dao.'.$id;
         $container
@@ -73,12 +73,12 @@ public function getPriority(): int
         return self::PRIORITY;
     }
 
-    public function getPosition()
+    public function getPosition(): string
     {
         return 'http';
     }
 
-    public function getKey()
+    public function getKey(): string
     {
         return 'http-basic';
     }
diff --git a/DependencyInjection/Security/Factory/HttpBasicLdapFactory.php b/DependencyInjection/Security/Factory/HttpBasicLdapFactory.php
@@ -30,7 +30,7 @@ class HttpBasicLdapFactory extends HttpBasicFactory
 {
     use LdapFactoryTrait;
 
-    public function create(ContainerBuilder $container, string $id, array $config, string $userProvider, ?string $defaultEntryPoint)
+    public function create(ContainerBuilder $container, string $id, array $config, string $userProvider, ?string $defaultEntryPoint): array
     {
         $provider = 'security.authentication.provider.ldap_bind.'.$id;
         $definition = $container
diff --git a/DependencyInjection/Security/Factory/JsonLoginFactory.php b/DependencyInjection/Security/Factory/JsonLoginFactory.php
@@ -42,23 +42,23 @@ public function getPriority(): int
     /**
      * {@inheritdoc}
      */
-    public function getPosition()
+    public function getPosition(): string
     {
         return 'form';
     }
 
     /**
      * {@inheritdoc}
      */
-    public function getKey()
+    public function getKey(): string
     {
         return 'json-login';
     }
 
     /**
      * {@inheritdoc}
      */
-    protected function createAuthProvider(ContainerBuilder $container, string $id, array $config, string $userProviderId)
+    protected function createAuthProvider(ContainerBuilder $container, string $id, array $config, string $userProviderId): string
     {
         $provider = 'security.authentication.provider.dao.'.$id;
         $container
@@ -74,15 +74,15 @@ protected function createAuthProvider(ContainerBuilder $container, string $id, a
     /**
      * {@inheritdoc}
      */
-    protected function getListenerId()
+    protected function getListenerId(): string
     {
         return 'security.authentication.listener.json';
     }
 
     /**
      * {@inheritdoc}
      */
-    protected function isRememberMeAware(array $config)
+    protected function isRememberMeAware(array $config): bool
     {
         return false;
     }
diff --git a/DependencyInjection/Security/Factory/JsonLoginLdapFactory.php b/DependencyInjection/Security/Factory/JsonLoginLdapFactory.php
@@ -26,7 +26,7 @@ class JsonLoginLdapFactory extends JsonLoginFactory
 {
     use LdapFactoryTrait;
 
-    protected function createAuthProvider(ContainerBuilder $container, string $id, array $config, string $userProviderId)
+    protected function createAuthProvider(ContainerBuilder $container, string $id, array $config, string $userProviderId): string
     {
         $provider = 'security.authentication.provider.ldap_bind.'.$id;
         $definition = $container
diff --git a/DependencyInjection/Security/Factory/LoginLinkFactory.php b/DependencyInjection/Security/Factory/LoginLinkFactory.php
@@ -81,7 +81,7 @@ public function addConfiguration(NodeDefinition $node)
         }
     }
 
-    public function getKey()
+    public function getKey(): string
     {
         return 'login-link';
     }
@@ -154,17 +154,17 @@ public function getPriority(): int
         return self::PRIORITY;
     }
 
-    public function getPosition()
+    public function getPosition(): string
     {
         return 'form';
     }
 
-    protected function createAuthProvider(ContainerBuilder $container, string $id, array $config, string $userProviderId)
+    protected function createAuthProvider(ContainerBuilder $container, string $id, array $config, string $userProviderId): string
     {
         throw new \Exception('The old authentication system is not supported with login_link.');
     }
 
-    protected function getListenerId()
+    protected function getListenerId(): string
     {
         throw new \Exception('The old authentication system is not supported with login_link.');
     }
@@ -174,7 +174,7 @@ protected function createListener(ContainerBuilder $container, string $id, array
         throw new \Exception('The old authentication system is not supported with login_link.');
     }
 
-    protected function createEntryPoint(ContainerBuilder $container, string $id, array $config, ?string $defaultEntryPointId)
+    protected function createEntryPoint(ContainerBuilder $container, string $id, array $config, ?string $defaultEntryPointId): ?string
     {
         throw new \Exception('The old authentication system is not supported with login_link.');
     }
diff --git a/DependencyInjection/Security/Factory/LoginThrottlingFactory.php b/DependencyInjection/Security/Factory/LoginThrottlingFactory.php
@@ -29,7 +29,7 @@
  */
 class LoginThrottlingFactory implements AuthenticatorFactoryInterface, SecurityFactoryInterface
 {
-    public function create(ContainerBuilder $container, string $id, array $config, string $userProvider, ?string $defaultEntryPoint)
+    public function create(ContainerBuilder $container, string $id, array $config, string $userProvider, ?string $defaultEntryPoint): array
     {
         throw new \LogicException('Login throttling is not supported when "security.enable_authenticator_manager" is not set to true.');
     }
diff --git a/DependencyInjection/Security/Factory/RememberMeFactory.php b/DependencyInjection/Security/Factory/RememberMeFactory.php
@@ -47,7 +47,7 @@ class RememberMeFactory implements SecurityFactoryInterface, AuthenticatorFactor
         'remember_me_parameter' => '_remember_me',
     ];
 
-    public function create(ContainerBuilder $container, string $id, array $config, ?string $userProvider, ?string $defaultEntryPoint)
+    public function create(ContainerBuilder $container, string $id, array $config, ?string $userProvider, ?string $defaultEntryPoint): array
     {
         // authentication provider
         $authProviderId = 'security.authentication.provider.rememberme.'.$id;
@@ -179,7 +179,7 @@ public function createAuthenticator(ContainerBuilder $container, string $firewal
         return $authenticatorId;
     }
 
-    public function getPosition()
+    public function getPosition(): string
     {
         return 'remember_me';
     }
@@ -192,7 +192,7 @@ public function getPriority(): int
         return self::PRIORITY;
     }
 
-    public function getKey()
+    public function getKey(): string
     {
         return 'remember-me';
     }
diff --git a/DependencyInjection/Security/Factory/RemoteUserFactory.php b/DependencyInjection/Security/Factory/RemoteUserFactory.php
@@ -28,7 +28,7 @@ class RemoteUserFactory implements SecurityFactoryInterface, AuthenticatorFactor
 {
     public const PRIORITY = -10;
 
-    public function create(ContainerBuilder $container, string $id, array $config, string $userProvider, ?string $defaultEntryPoint)
+    public function create(ContainerBuilder $container, string $id, array $config, string $userProvider, ?string $defaultEntryPoint): array
     {
         $providerId = 'security.authentication.provider.pre_authenticated.'.$id;
         $container
@@ -65,12 +65,12 @@ public function getPriority(): int
         return self::PRIORITY;
     }
 
-    public function getPosition()
+    public function getPosition(): string
     {
         return 'pre_auth';
     }
 
-    public function getKey()
+    public function getKey(): string
     {
         return 'remote-user';
     }
diff --git a/DependencyInjection/Security/Factory/X509Factory.php b/DependencyInjection/Security/Factory/X509Factory.php

Original file line number	Diff line number	Diff line change
`@@ -232,20 +232,16 @@ public function lateCollect()`
`232`	`232`
`233`	`233`	`/**`
`234`	`234`	`* Checks if security is enabled.`
`235`		`- *`
`236`		`- * @return bool`
`237`	`235`	`*/`
`238`		`- public function isEnabled()`
	`236`	`+ public function isEnabled(): bool`
`239`	`237`	`{`
`240`	`238`	`return $this->data['enabled'];`
`241`	`239`	`}`
`242`	`240`
`243`	`241`	`/**`
`244`	`242`	`* Gets the user.`
`245`		`- *`
`246`		`- * @return string`
`247`	`243`	`*/`
`248`		`- public function getUser()`
	`244`	`+ public function getUser(): string`
`249`	`245`	`{`
`250`	`246`	`return $this->data['user'];`
`251`	`247`	`}`
`@@ -273,44 +269,31 @@ public function getInheritedRoles()`
`273`	`269`	`/**`
`274`	`270`	`* Checks if the data contains information about inherited roles. Still the inherited`
`275`	`271`	`* roles can be an empty array.`
`276`		`- *`
`277`		`- * @return bool`
`278`	`272`	`*/`
`279`		`- public function supportsRoleHierarchy()`
	`273`	`+ public function supportsRoleHierarchy(): bool`
`280`	`274`	`{`
`281`	`275`	`return $this->data['supports_role_hierarchy'];`
`282`	`276`	`}`
`283`	`277`
`284`	`278`	`/**`
`285`	`279`	`* Checks if the user is authenticated or not.`
`286`		`- *`
`287`		`- * @return bool`
`288`	`280`	`*/`
`289`		`- public function isAuthenticated()`
	`281`	`+ public function isAuthenticated(): bool`
`290`	`282`	`{`
`291`	`283`	`return $this->data['authenticated'];`
`292`	`284`	`}`
`293`	`285`
`294`		`- /**`
`295`		`- * @return bool`
`296`		`- */`
`297`		`- public function isImpersonated()`
	`286`	`+ public function isImpersonated(): bool`
`298`	`287`	`{`
`299`	`288`	`return $this->data['impersonated'];`
`300`	`289`	`}`
`301`	`290`
`302`		`- /**`
`303`		`- * @return string\|null`
`304`		`- */`
`305`		`- public function getImpersonatorUser()`
	`291`	`+ public function getImpersonatorUser(): ?string`
`306`	`292`	`{`
`307`	`293`	`return $this->data['impersonator_user'];`
`308`	`294`	`}`
`309`	`295`
`310`		`- /**`
`311`		`- * @return string\|null`
`312`		`- */`
`313`		`- public function getImpersonationExitPath()`
	`296`	`+ public function getImpersonationExitPath(): ?string`
`314`	`297`	`{`
`315`	`298`	`return $this->data['impersonation_exit_path'];`
`316`	`299`	`}`
`@@ -327,20 +310,16 @@ public function getTokenClass()`
`327`	`310`
`328`	`311`	`/**`
`329`	`312`	`* Get the full security token class as Data object.`
`330`		`- *`
`331`		`- * @return Data\|null`
`332`	`313`	`*/`
`333`		`- public function getToken()`
	`314`	`+ public function getToken(): ?Data`
`334`	`315`	`{`
`335`	`316`	`return $this->data['token'];`
`336`	`317`	`}`
`337`	`318`
`338`	`319`	`/**`
`339`	`320`	`* Get the logout URL.`
`340`		`- *`
`341`		`- * @return string\|null`
`342`	`321`	`*/`
`343`		`- public function getLogoutUrl()`
	`322`	`+ public function getLogoutUrl(): ?string`
`344`	`323`	`{`
`345`	`324`	`return $this->data['logout_url'];`
`346`	`325`	`}`
`@@ -357,10 +336,8 @@ public function getVoters()`
`357`	`336`
`358`	`337`	`/**`
`359`	`338`	`* Returns the strategy configured for the security voters.`
`360`		`- *`
`361`		`- * @return string`
`362`	`339`	`*/`
`363`		`- public function getVoterStrategy()`
	`340`	`+ public function getVoterStrategy(): string`
`364`	`341`	`{`
`365`	`342`	`return $this->data['voter_strategy'];`
`366`	`343`	`}`
`@@ -396,7 +373,7 @@ public function getListeners()`
`396`	`373`	`/**`
`397`	`374`	`* {@inheritdoc}`
`398`	`375`	`*/`
`399`		`- public function getName()`
	`376`	`+ public function getName(): string`
`400`	`377`	`{`
`401`	`378`	`return 'security';`
`402`	`379`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,8 +20,6 @@`
`20`	`20`	`/**`
`21`	`21`	`* @author Wouter de Jong <wouter@wouterj.nl>`
`22`	`22`	`*`
`23`		`- * @internal`
`24`		`- *`
`25`	`23`	`* @deprecated since Symfony 5.3, use the new authenticator system instead`
`26`	`24`	`*/`
`27`	`25`	`class AnonymousFactory implements SecurityFactoryInterface, AuthenticatorFactoryInterface`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@`
`22`	`22`	`*/`
`23`	`23`	`class CustomAuthenticatorFactory implements AuthenticatorFactoryInterface, SecurityFactoryInterface`
`24`	`24`	`{`
`25`		`- public function create(ContainerBuilder $container, string $id, array $config, string $userProvider, ?string $defaultEntryPoint)`
	`25`	`+ public function create(ContainerBuilder $container, string $id, array $config, string $userProvider, ?string $defaultEntryPoint): array`
`26`	`26`	`{`
`27`	`27`	`throw new \LogicException('Custom authenticators are not supported when "security.enable_authenticator_manager" is not set to true.');`
`28`	`28`	`}`
Original file line number	Diff line number	Diff line change
`@@ -44,12 +44,12 @@ public function getPriority(): int`
`44`	`44`	`return self::PRIORITY;`
`45`	`45`	`}`
`46`	`46`
`47`		`- public function getPosition()`
	`47`	`+ public function getPosition(): string`
`48`	`48`	`{`
`49`	`49`	`return 'form';`
`50`	`50`	`}`
`51`	`51`
`52`		`- public function getKey()`
	`52`	`+ public function getKey(): string`
`53`	`53`	`{`
`54`	`54`	`return 'form-login';`
`55`	`55`	`}`
`@@ -65,12 +65,12 @@ public function addConfiguration(NodeDefinition $node)`
`65`	`65`	`;`
`66`	`66`	`}`
`67`	`67`
`68`		`- protected function getListenerId()`
	`68`	`+ protected function getListenerId(): string`
`69`	`69`	`{`
`70`	`70`	`return 'security.authentication.listener.form';`
`71`	`71`	`}`
`72`	`72`
`73`		`- protected function createAuthProvider(ContainerBuilder $container, string $id, array $config, string $userProviderId)`
	`73`	`+ protected function createAuthProvider(ContainerBuilder $container, string $id, array $config, string $userProviderId): string`
`74`	`74`	`{`
`75`	`75`	`if ($config['enable_csrf'] ?? false) {`
`76`	`76`	`throw new InvalidConfigurationException('The "enable_csrf" option of "form_login" is only available when "security.enable_authenticator_manager" is set to "true", use "csrf_token_generator" instead.');`
`@@ -99,7 +99,7 @@ protected function createListener(ContainerBuilder $container, string $id, array`
`99`	`99`	`return $listenerId;`
`100`	`100`	`}`
`101`	`101`
`102`		`- protected function createEntryPoint(ContainerBuilder $container, string $id, array $config, ?string $defaultEntryPointId)`
	`102`	`+ protected function createEntryPoint(ContainerBuilder $container, string $id, array $config, ?string $defaultEntryPointId): ?string`
`103`	`103`	`{`
`104`	`104`	`$entryPointId = 'security.authentication.form_entry_point.'.$id;`
`105`	`105`	`$container`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ class FormLoginLdapFactory extends FormLoginFactory`
`29`	`29`	`{`
`30`	`30`	`use LdapFactoryTrait;`
`31`	`31`
`32`		`- protected function createAuthProvider(ContainerBuilder $container, string $id, array $config, string $userProviderId)`
	`32`	`+ protected function createAuthProvider(ContainerBuilder $container, string $id, array $config, string $userProviderId): string`
`33`	`33`	`{`
`34`	`34`	`$provider = 'security.authentication.provider.ldap_bind.'.$id;`
`35`	`35`	`$definition = $container`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@`
`29`	`29`	`*/`
`30`	`30`	`class GuardAuthenticationFactory implements SecurityFactoryInterface, AuthenticatorFactoryInterface`
`31`	`31`	`{`
`32`		`- public function getPosition()`
	`32`	`+ public function getPosition(): string`
`33`	`33`	`{`
`34`	`34`	`return 'pre_auth';`
`35`	`35`	`}`
`@@ -39,7 +39,7 @@ public function getPriority(): int`
`39`	`39`	`return 0;`
`40`	`40`	`}`
`41`	`41`
`42`		`- public function getKey()`
	`42`	`+ public function getKey(): string`
`43`	`43`	`{`
`44`	`44`	`return 'guard';`
`45`	`45`	`}`
`@@ -65,7 +65,7 @@ public function addConfiguration(NodeDefinition $node)`
`65`	`65`	`;`
`66`	`66`	`}`
`67`	`67`
`68`		`- public function create(ContainerBuilder $container, string $id, array $config, string $userProvider, ?string $defaultEntryPoint)`
	`68`	`+ public function create(ContainerBuilder $container, string $id, array $config, string $userProvider, ?string $defaultEntryPoint): array`
`69`	`69`	`{`
`70`	`70`	`$authenticatorIds = $config['authenticators'];`
`71`	`71`	`$authenticatorReferences = [];`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ class HttpBasicFactory implements SecurityFactoryInterface, AuthenticatorFactory`
`27`	`27`	`{`
`28`	`28`	`public const PRIORITY = -50;`
`29`	`29`
`30`		`- public function create(ContainerBuilder $container, string $id, array $config, string $userProvider, ?string $defaultEntryPoint)`
	`30`	`+ public function create(ContainerBuilder $container, string $id, array $config, string $userProvider, ?string $defaultEntryPoint): array`
`31`	`31`	`{`
`32`	`32`	`$provider = 'security.authentication.provider.dao.'.$id;`
`33`	`33`	`$container`
`@@ -73,12 +73,12 @@ public function getPriority(): int`
`73`	`73`	`return self::PRIORITY;`
`74`	`74`	`}`
`75`	`75`
`76`		`- public function getPosition()`
	`76`	`+ public function getPosition(): string`
`77`	`77`	`{`
`78`	`78`	`return 'http';`
`79`	`79`	`}`
`80`	`80`
`81`		`- public function getKey()`
	`81`	`+ public function getKey(): string`
`82`	`82`	`{`
`83`	`83`	`return 'http-basic';`
`84`	`84`	`}`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ class HttpBasicLdapFactory extends HttpBasicFactory`
`30`	`30`	`{`
`31`	`31`	`use LdapFactoryTrait;`
`32`	`32`
`33`		`- public function create(ContainerBuilder $container, string $id, array $config, string $userProvider, ?string $defaultEntryPoint)`
	`33`	`+ public function create(ContainerBuilder $container, string $id, array $config, string $userProvider, ?string $defaultEntryPoint): array`
`34`	`34`	`{`
`35`	`35`	`$provider = 'security.authentication.provider.ldap_bind.'.$id;`
`36`	`36`	`$definition = $container`
Original file line number	Diff line number	Diff line change
`@@ -42,23 +42,23 @@ public function getPriority(): int`
`42`	`42`	`/**`
`43`	`43`	`* {@inheritdoc}`
`44`	`44`	`*/`
`45`		`- public function getPosition()`
	`45`	`+ public function getPosition(): string`
`46`	`46`	`{`
`47`	`47`	`return 'form';`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`/**`
`51`	`51`	`* {@inheritdoc}`
`52`	`52`	`*/`
`53`		`- public function getKey()`
	`53`	`+ public function getKey(): string`
`54`	`54`	`{`
`55`	`55`	`return 'json-login';`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`/**`
`59`	`59`	`* {@inheritdoc}`
`60`	`60`	`*/`
`61`		`- protected function createAuthProvider(ContainerBuilder $container, string $id, array $config, string $userProviderId)`
	`61`	`+ protected function createAuthProvider(ContainerBuilder $container, string $id, array $config, string $userProviderId): string`
`62`	`62`	`{`
`63`	`63`	`$provider = 'security.authentication.provider.dao.'.$id;`
`64`	`64`	`$container`
`@@ -74,15 +74,15 @@ protected function createAuthProvider(ContainerBuilder $container, string $id, a`
`74`	`74`	`/**`
`75`	`75`	`* {@inheritdoc}`
`76`	`76`	`*/`
`77`		`- protected function getListenerId()`
	`77`	`+ protected function getListenerId(): string`
`78`	`78`	`{`
`79`	`79`	`return 'security.authentication.listener.json';`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`/**`
`83`	`83`	`* {@inheritdoc}`
`84`	`84`	`*/`
`85`		`- protected function isRememberMeAware(array $config)`
	`85`	`+ protected function isRememberMeAware(array $config): bool`
`86`	`86`	`{`
`87`	`87`	`return false;`
`88`	`88`	`}`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ class JsonLoginLdapFactory extends JsonLoginFactory`
`26`	`26`	`{`
`27`	`27`	`use LdapFactoryTrait;`
`28`	`28`
`29`		`- protected function createAuthProvider(ContainerBuilder $container, string $id, array $config, string $userProviderId)`
	`29`	`+ protected function createAuthProvider(ContainerBuilder $container, string $id, array $config, string $userProviderId): string`
`30`	`30`	`{`
`31`	`31`	`$provider = 'security.authentication.provider.ldap_bind.'.$id;`
`32`	`32`	`$definition = $container`