[Security] Deprecated build-in authentication entry points

This logic is now included in the authenticators

Author: wouterj

CHANGELOG.md

@@ -4,6 +4,8 @@ CHANGELOG
 5.4
 ---
 
+ * Deprecate `security.authentication.basic_entry_point` and `security.authentication.retry_entry_point` services, the logic is moved into the
+   `HttpBasicAuthenticator` and `ChannelListener` respectively
  * Deprecate `FirewallConfig::allowsAnonymous()` and the `allows_anonymous` from the data collector data, there will be no anonymous concept as of version 6.
  * Deprecate not setting `$authenticatorManagerEnabled` to `true` in `SecurityDataCollector` and `DebugFirewallCommand`
  * Deprecate `SecurityFactoryInterface` and `SecurityExtension::addSecurityListenerFactory()` in favor of

Resources/config/security_listeners.php

@@ -32,19 +32,22 @@
 return static function (ContainerConfigurator $container) {
     $container->services()
 
+        ->set('security.authentication.basic_entry_point', BasicAuthenticationEntryPoint::class)
+            ->deprecate('symfony/security-bundle', '5.4', 'The "%service_id%" service is deprecated, the logic is contained in the authenticators.')
+
         ->set('security.authentication.retry_entry_point', RetryAuthenticationEntryPoint::class)
+            ->deprecate('symfony/security-bundle', '5.4', 'The "%service_id%" service is deprecated, the logic is integrated directly in "security.channel_listener".')
             ->args([
                 inline_service('int')->factory([service('router.request_context'), 'getHttpPort']),
                 inline_service('int')->factory([service('router.request_context'), 'getHttpsPort']),
             ])
 
-        ->set('security.authentication.basic_entry_point', BasicAuthenticationEntryPoint::class)
-
         ->set('security.channel_listener', ChannelListener::class)
             ->args([
                 service('security.access_map'),
-                service('security.authentication.retry_entry_point'),
                 service('logger')->nullOnInvalid(),
+                inline_service('int')->factory([service('router.request_context'), 'getHttpPort']),
+                inline_service('int')->factory([service('router.request_context'), 'getHttpsPort']),
             ])
             ->tag('monolog.logger', ['channel' => 'security'])