Migrate to static data providers using rector/rector

Author: OskarStark

Tests/Annotation/RouteTest.php

@@ -42,7 +42,7 @@ private function getMethodAnnotation(string $method, bool $attributes): Route
         return $route;
     }
 
-    public function provideDeprecationArrayAsFirstArgument()
+    public static function provideDeprecationArrayAsFirstArgument()
     {
         return [
             ['requirements', ['locale' => 'en'], 'getRequirements'],
@@ -89,7 +89,7 @@ public function testLoadFromDoctrineAnnotation(string $methodName, string $gette
         $this->assertEquals($route->$getter(), $expectedReturn);
     }
 
-    public function getValidParameters(): iterable
+    public static function getValidParameters(): iterable
     {
         return [
             ['simplePath', 'getPath', '/Blog'],

Tests/Generator/UrlGeneratorTest.php

@@ -130,7 +130,7 @@ public function testAbsoluteUrlWithExtraParameters(string $expectedQueryString,
         $this->assertSame('http://localhost/app.php/testing'.$expectedQueryString, $url);
     }
 
-    public function valuesProvider(): array
+    public static function valuesProvider(): array
     {
         $stdClass = new \stdClass();
         $stdClass->baz = 'bar';
@@ -862,7 +862,7 @@ public function testGetRelativePath($sourcePath, $targetPath, $expectedPath)
         $this->assertSame($expectedPath, UrlGenerator::getRelativePath($sourcePath, $targetPath));
     }
 
-    public function provideRelativePaths()
+    public static function provideRelativePaths()
     {
         return [
             [
@@ -1004,7 +1004,7 @@ public function testLookRoundRequirementsInPath($expected, $path, $requirement)
         $this->assertSame($expected, $this->getGenerator($routes)->generate('test', ['foo' => 'a/b', 'baz' => 'c/d/e']));
     }
 
-    public function provideLookAroundRequirementsInPath()
+    public static function provideLookAroundRequirementsInPath()
     {
         yield ['/app.php/a/b/b%28ar/c/d/e', '/{foo}/b(ar/{baz}', '.+(?=/b\\(ar/)'];
         yield ['/app.php/a/b/bar/c/d/e', '/{foo}/bar/{baz}', '.+(?!$)'];

Tests/Loader/AnnotationClassLoaderTestCase.php

@@ -30,7 +30,7 @@ public function testSupportsChecksResource($resource, $expectedSupports)
         $this->assertSame($expectedSupports, $this->loader->supports($resource), '->supports() returns true if the resource is loadable');
     }
 
-    public function provideTestSupportsChecksResource()
+    public static function provideTestSupportsChecksResource()
     {
         return [
             ['class', true],

Tests/Loader/ContainerLoaderTest.php

@@ -25,7 +25,7 @@ public function testSupports(bool $expected, string $type = null)
         $this->assertSame($expected, (new ContainerLoader(new Container()))->supports('foo', $type));
     }
 
-    public function supportsProvider()
+    public static function supportsProvider()
     {
         return [
             [true, 'service'],

Tests/Loader/ObjectLoaderTest.php

@@ -50,7 +50,7 @@ public function testExceptionWithoutSyntax(string $resourceString)
         $loader->load($resourceString);
     }
 
-    public function getBadResourceStrings()
+    public static function getBadResourceStrings()
     {
         return [
             ['Foo:Bar:baz'],

Tests/Loader/XmlFileLoaderTest.php

@@ -230,7 +230,7 @@ public function testLoadThrowsExceptionWithInvalidFileEvenWithoutSchemaValidatio
         $loader->load($filePath);
     }
 
-    public function getPathsToInvalidFiles()
+    public static function getPathsToInvalidFiles()
     {
         return [
             ['nonvalidnode.xml'],
@@ -478,7 +478,7 @@ public function testImportRouteWithController($file)
         $this->assertSame('FrameworkBundle:Template:template', $route->getDefault('_controller'));
     }
 
-    public function provideFilesImportingRoutesWithControllers()
+    public static function provideFilesImportingRoutesWithControllers()
     {
         yield ['import_controller.xml'];
         yield ['import__controller.xml'];

Tests/Loader/YamlFileLoaderTest.php

@@ -52,7 +52,7 @@ public function testLoadThrowsExceptionWithInvalidFile($filePath)
         $loader->load($filePath);
     }
 
-    public function getPathsToInvalidFiles()
+    public static function getPathsToInvalidFiles()
     {
         return [
             ['nonvalid.yml'],
@@ -171,7 +171,7 @@ public function testImportRouteWithController($file)
         $this->assertSame('FrameworkBundle:Template:template', $route->getDefault('_controller'));
     }
 
-    public function provideFilesImportingRoutesWithControllers()
+    public static function provideFilesImportingRoutesWithControllers()
     {
         yield ['import_controller.yml'];
         yield ['import__controller.yml'];

Tests/Matcher/Dumper/CompiledUrlMatcherDumperTest.php

@@ -65,7 +65,7 @@ public function testDump(RouteCollection $collection, $fixture)
         $this->assertStringEqualsFile($basePath.$fixture, $dumper->dump());
     }
 
-    public function getRouteCollections()
+    public static function getRouteCollections()
     {
         /* test case 1 */
 

Tests/Matcher/Dumper/StaticPrefixCollectionTest.php

@@ -34,7 +34,7 @@ public function testGrouping(array $routes, $expected)
         $this->assertEquals($expected, $dumped);
     }
 
-    public function routeProvider()
+    public static function routeProvider()
     {
         return [
             'Simple - not nested' => [

Tests/Matcher/ExpressionLanguageProviderTest.php

@@ -59,7 +59,7 @@ public function testCompile(string $expression, string $expected)
         $this->assertSame($expected, $this->expressionLanguage->compile($expression));
     }
 
-    public function compileProvider(): iterable
+    public static function compileProvider(): iterable
     {
         return [
             ['env("APP_ENV")', '($context->getParameter(\'_functions\')->get(\'env\')("APP_ENV"))'],
@@ -76,7 +76,7 @@ public function testEvaluate(string $expression, $expected)
         $this->assertSame($expected, $this->expressionLanguage->evaluate($expression, ['context' => $this->context]));
     }
 
-    public function evaluateProvider(): iterable
+    public static function evaluateProvider(): iterable
     {
         return [
             ['env("APP_ENV")', 'test'],