minor #32786 add parameter type declarations to private methods (xabbuh)

This PR was merged into the 4.4 branch.

Discussion
----------

add parameter type declarations to private methods

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

1b2aaa4a06 add parameter type declarations to private methods

Author: fabpot

Loader/Configurator/CollectionConfigurator.php

@@ -88,7 +88,7 @@ final public function prefix($prefix)
         return $this;
     }
 
-    private function createRoute($path): Route
+    private function createRoute(string $path): Route
     {
         return (clone $this->route)->setPath($path);
     }

Loader/Configurator/Traits/AddTrait.php

@@ -83,7 +83,7 @@ final public function __invoke(string $name, $path): RouteConfigurator
         return $this->add($name, $path);
     }
 
-    private function createRoute($path): Route
+    private function createRoute(string $path): Route
     {
         return new Route($path);
     }

Loader/XmlFileLoader.php

@@ -253,14 +253,11 @@ protected function loadFile($file)
     /**
      * Parses the config elements (default, requirement, option).
      *
-     * @param \DOMElement $node Element to parse that contains the configs
-     * @param string      $path Full path of the XML file being processed
-     *
      * @return array An array with the defaults as first item, requirements as second and options as third
      *
      * @throws \InvalidArgumentException When the XML is invalid
      */
-    private function parseConfigs(\DOMElement $node, $path)
+    private function parseConfigs(\DOMElement $node, string $path)
     {
         $defaults = [];
         $requirements = [];
@@ -329,12 +326,9 @@ private function parseConfigs(\DOMElement $node, $path)
     /**
      * Parses the "default" elements.
      *
-     * @param \DOMElement $element The "default" element to parse
-     * @param string      $path    Full path of the XML file being processed
-     *
      * @return array|bool|float|int|string|null The parsed value of the "default" element
      */
-    private function parseDefaultsConfig(\DOMElement $element, $path)
+    private function parseDefaultsConfig(\DOMElement $element, string $path)
     {
         if ($this->isElementValueNull($element)) {
             return;
@@ -364,14 +358,11 @@ private function parseDefaultsConfig(\DOMElement $element, $path)
     /**
      * Recursively parses the value of a "default" element.
      *
-     * @param \DOMElement $node The node value
-     * @param string      $path Full path of the XML file being processed
-     *
      * @return array|bool|float|int|string The parsed value
      *
      * @throws \InvalidArgumentException when the XML is invalid
      */
-    private function parseDefaultNode(\DOMElement $node, $path)
+    private function parseDefaultNode(\DOMElement $node, string $path)
     {
         if ($this->isElementValueNull($node)) {
             return;

Matcher/Dumper/CompiledUrlMatcherDumper.php

@@ -455,7 +455,7 @@ private function getExpressionLanguage()
         return $this->expressionLanguage;
     }
 
-    private function indent($code, $level = 1)
+    private function indent(string $code, int $level = 1)
     {
         return preg_replace('/^./m', str_repeat('    ', $level).'$0', $code);
     }

Matcher/TraceableUrlMatcher.php

@@ -129,7 +129,7 @@ protected function matchCollection($pathinfo, RouteCollection $routes)
         }
     }
 
-    private function addTrace($log, $level = self::ROUTE_DOES_NOT_MATCH, $name = null, $route = null)
+    private function addTrace(string $log, int $level = self::ROUTE_DOES_NOT_MATCH, string $name = null, Route $route = null)
     {
         $this->traces[] = [
             'log' => $log,

Route.php

@@ -559,7 +559,7 @@ public function compile()
         return $this->compiled = $class::compile($this);
     }
 
-    private function sanitizeRequirement($key, $regex)
+    private function sanitizeRequirement(string $key, $regex)
     {
         if (!\is_string($regex)) {
             throw new \InvalidArgumentException(sprintf('Routing requirement for "%s" must be a string.', $key));

Router.php

@@ -420,7 +420,7 @@ private function getConfigCacheFactory()
         return $this->configCacheFactory;
     }
 
-    private function checkDeprecatedOption($key)
+    private function checkDeprecatedOption(string $key)
     {
         switch ($key) {
             case 'generator_base_class':