Skip to content

Commit 8236313

Browse files
dunglasfabpot
authored andcommitted
don't expose the port by default (security)
1 parent ad93c11 commit 8236313

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

doctrine/doctrine-bundle/1.6/manifest.json

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@
1010
"#1": "Format described at https://www.doctrine-project.org/projects/doctrine-dbal/en/latest/reference/configuration.html#connecting-using-a-url",
1111
"#2": "For an SQLite database, use: \"sqlite:///%kernel.project_dir%/var/data.db\"",
1212
"#3": "For a PostgreSQL database, use: \"postgresql://db_user:db_password@127.0.0.1:5432/db_name?serverVersion=11&charset=utf8\"",
13-
"#4": "For the Docker integration, use: \"mysql://symfony:ChangeMe@db:3306/app?serverVersion=mariadb-10.5\"",
13+
"#4": "For the Docker integration, use: \"mysql://symfony:ChangeMe@db:3306/app?serverVersion=mariadb-10.5.6\"",
1414
"#5": "IMPORTANT: You MUST configure your server version, either here or in config/packages/doctrine.yaml",
1515
"DATABASE_URL": "mysql://db_user:db_password@127.0.0.1:3306/db_name?serverVersion=5.7"
1616
},
1717
"dockerfile": ["RUN docker-php-ext-install pdo_mysql"],
1818
"docker-compose": {
1919
"services": [
2020
"db:",
21-
" image: mariadb:10.4",
21+
" image: mariadb:10.5.6",
2222
" environment:",
2323
" - MYSQL_DATABASE=app",
2424
" # You should definitely change the password in production",
@@ -29,8 +29,9 @@
2929
" - db-data:/var/lib/mysql:rw",
3030
" # You may use a bind-mounted host directory instead, so that it is harder to accidentally remove the volume and lose all your data!",
3131
" # - ./docker/db/data:/var/lib/mysql:rw",
32-
" ports:",
33-
" - \"3306\""
32+
" # To expose the port publicly",
33+
" # ports:",
34+
" # - \"3306\""
3435
],
3536
"volumes": ["db-data: {}"]
3637
}

0 commit comments

Comments
 (0)