Add types to private and internal properties

nicolas-grekas · nicolas-grekas · commit 8b9d11d88b6d · 2023-07-25T17:08:44.000+02:00
diff --git a/Message/PushMessage.php b/Message/PushMessage.php
@@ -18,11 +18,11 @@
  */
 class PushMessage implements MessageInterface, FromNotificationInterface
 {
-    private $transport;
-    private $subject;
-    private $content;
-    private $options;
-    private $notification;
+    private ?string $transport = null;
+    private string $subject;
+    private string $content;
+    private ?MessageOptionsInterface $options;
+    private ?Notification $notification = null;
 
     public function __construct(string $subject, string $content, MessageOptionsInterface $options = null)
     {
diff --git a/Test/Constraint/NotificationCount.php b/Test/Constraint/NotificationCount.php
@@ -19,9 +19,9 @@
  */
 final class NotificationCount extends Constraint
 {
-    private $expectedValue;
-    private $transport;
-    private $queued;
+    private int $expectedValue;
+    private ?string $transport;
+    private bool $queued;
 
     public function __construct(int $expectedValue, string $transport = null, bool $queued = false)
     {
diff --git a/Test/Constraint/NotificationSubjectContains.php b/Test/Constraint/NotificationSubjectContains.php
@@ -19,7 +19,7 @@
  */
 final class NotificationSubjectContains extends Constraint
 {
-    private $expectedText;
+    private string $expectedText;
 
     public function __construct(string $expectedText)
     {
diff --git a/Test/Constraint/NotificationTransportIsEqual.php b/Test/Constraint/NotificationTransportIsEqual.php
@@ -19,7 +19,7 @@
  */
 final class NotificationTransportIsEqual extends Constraint
 {
-    private $expectedText;
+    private string $expectedText;
 
     public function __construct(string $expectedText)
     {

Original file line number	Diff line number	Diff line change
`@@ -19,9 +19,9 @@`
`19`	`19`	`*/`
`20`	`20`	`final class NotificationCount extends Constraint`
`21`	`21`	`{`
`22`		`- private $expectedValue;`
`23`		`- private $transport;`
`24`		`- private $queued;`
	`22`	`+ private int $expectedValue;`
	`23`	`+ private ?string $transport;`
	`24`	`+ private bool $queued;`
`25`	`25`
`26`	`26`	`public function __construct(int $expectedValue, string $transport = null, bool $queued = false)`
`27`	`27`	`{`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@`
`19`	`19`	`*/`
`20`	`20`	`final class NotificationSubjectContains extends Constraint`
`21`	`21`	`{`
`22`		`- private $expectedText;`
	`22`	`+ private string $expectedText;`
`23`	`23`
`24`	`24`	`public function __construct(string $expectedText)`
`25`	`25`	`{`