do not mock the RequestStack class

xabbuh · xabbuh · commit 031ac0a7c264 · 2024-01-11T08:45:01.000+01:00
diff --git a/Tests/Channel/BrowserChannelTest.php b/Tests/Channel/BrowserChannelTest.php
@@ -79,10 +79,10 @@ public static function defaultFlashMessageImportanceDataProvider(): array
 
     private function buildBrowserChannel(Session $session, FlashMessageImportanceMapperInterface $mapper): BrowserChannel
     {
-        $request = $this->createMock(Request::class);
-        $request->method('getSession')->willReturn($session);
-        $requestStack = $this->createStub(RequestStack::class);
-        $requestStack->method('getCurrentRequest')->willReturn($request);
+        $request = new Request();
+        $request->setSession($session);
+        $requestStack = new RequestStack();
+        $requestStack->push($request);
 
         return new BrowserChannel($requestStack, $mapper);
     }

Original file line number	Diff line number	Diff line change
`@@ -79,10 +79,10 @@ public static function defaultFlashMessageImportanceDataProvider(): array`
`79`	`79`
`80`	`80`	`private function buildBrowserChannel(Session $session, FlashMessageImportanceMapperInterface $mapper): BrowserChannel`
`81`	`81`	`{`
`82`		`- $request = $this->createMock(Request::class);`
`83`		`- $request->method('getSession')->willReturn($session);`
`84`		`- $requestStack = $this->createStub(RequestStack::class);`
`85`		`- $requestStack->method('getCurrentRequest')->willReturn($request);`
	`82`	`+ $request = new Request();`
	`83`	`+ $request->setSession($session);`
	`84`	`+ $requestStack = new RequestStack();`
	`85`	`+ $requestStack->push($request);`
`86`	`86`
`87`	`87`	`return new BrowserChannel($requestStack, $mapper);`
`88`	`88`	`}`