feature #387 Use "use_locking" option with rotating file handler as well (HypeMC)

This PR was merged into the 3.x-dev branch.

Discussion
----------

Use "use_locking" option with rotating file handler as well

Fixes #382 .

Commits
-------

1e3a6a0 Use "use_locking" option with rotating fie handler as well

Author: jderusse

DependencyInjection/Configuration.php

@@ -63,6 +63,7 @@
  *   - [level]: level name or int value, defaults to DEBUG
  *   - [bubble]: bool, defaults to true
  *   - [file_permission]: string|null, defaults to null
+ *   - [use_locking]: bool, defaults to false
  *   - [filename_format]: string, defaults to '{filename}-{date}'
  *   - [date_format]: string, defaults to 'Y-m-d'
  *
@@ -397,7 +398,7 @@ public function getConfigTreeBuilder()
                                     })
                                 ->end()
                             ->end()
-                            ->booleanNode('use_locking')->defaultFalse()->end() // stream
+                            ->booleanNode('use_locking')->defaultFalse()->end() // stream and rotating
                             ->scalarNode('filename_format')->defaultValue('{filename}-{date}')->end() //rotating
                             ->scalarNode('date_format')->defaultValue('Y-m-d')->end() //rotating
                             ->scalarNode('ident')->defaultFalse()->end() // syslog and syslogudp

DependencyInjection/MonologExtension.php

@@ -389,6 +389,7 @@ private function buildHandler(ContainerBuilder $container, $name, array $handler
                 $handler['level'],
                 $handler['bubble'],
                 $handler['file_permission'],
+                $handler['use_locking'],
             ]);
             $definition->addMethodCall('setFilenameFormat', [
                 $handler['filename_format'],

Tests/DependencyInjection/ConfigurationTest.php

@@ -334,7 +334,7 @@ public function testWithUseLocking()
                         'use_locking' => false,
                     ],
                     'bar' => [
-                        'type' => 'stream',
+                        'type' => 'rotating_file',
                         'path' => '/bar',
                         'use_locking' => true,
                     ]

Tests/DependencyInjection/FixtureMonologExtensionTest.php

@@ -159,7 +159,7 @@ public function testLoadWithNewAndPriority()
 
         $handler = $container->getDefinition('monolog.handler.first');
         $this->assertDICDefinitionClass($handler, 'Monolog\Handler\RotatingFileHandler');
-        $this->assertDICConstructorArguments($handler, ['/tmp/monolog.log', 0, \Monolog\Logger::ERROR, true, null]);
+        $this->assertDICConstructorArguments($handler, ['/tmp/monolog.log', 0, \Monolog\Logger::ERROR, true, null, false]);
 
         $handler = $container->getDefinition('monolog.handler.last');
         $this->assertDICDefinitionClass($handler, 'Monolog\Handler\StreamHandler');