Skip to content

Commit 3dab8d1

Browse files
committed
Fix up further
1 parent 4937936 commit 3dab8d1

File tree

3 files changed

+12
-24
lines changed

3 files changed

+12
-24
lines changed

Tests/DependencyInjection/Compiler/LoggerChannelPassTest.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,8 +177,7 @@ private function getContainer()
177177
'type' => 'exclusive',
178178
'elements' => ['foo']
179179
]
180-
]
181-
);
180+
]);
182181

183182
$container->getCompilerPassConfig()->setOptimizationPasses([]);
184183
$container->getCompilerPassConfig()->setRemovingPasses([]);

Tests/DependencyInjection/FixtureMonologExtensionTest.php

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,11 @@ public function testLoadWithSeveralHandlers()
4141

4242
$handler = $container->getDefinition('monolog.handler.main');
4343
$this->assertDICDefinitionClass($handler, 'Monolog\Handler\FingersCrossedHandler');
44-
$this->assertDICConstructorArguments($handler, [new Reference('monolog.handler.nested'), \Monolog\Logger::ERROR, 0, true, true, \Monolog\Logger::NOTICE]
45-
);
44+
$this->assertDICConstructorArguments($handler, [new Reference('monolog.handler.nested'), \Monolog\Logger::ERROR, 0, true, true, \Monolog\Logger::NOTICE]);
4645

4746
$handler = $container->getDefinition('monolog.handler.filtered');
4847
$this->assertDICDefinitionClass($handler, 'Monolog\Handler\FilterHandler');
49-
$this->assertDICConstructorArguments($handler, [new Reference('monolog.handler.nested2'), [\Monolog\Logger::WARNING, \Monolog\Logger::ERROR], \Monolog\Logger::EMERGENCY, true]
50-
);
48+
$this->assertDICConstructorArguments($handler, [new Reference('monolog.handler.nested2'), [\Monolog\Logger::WARNING, \Monolog\Logger::ERROR], \Monolog\Logger::EMERGENCY, true]);
5149
}
5250

5351
public function testLoadWithOverwriting()
@@ -67,13 +65,11 @@ public function testLoadWithOverwriting()
6765

6866
$handler = $container->getDefinition('monolog.handler.custom');
6967
$this->assertDICDefinitionClass($handler, 'Monolog\Handler\StreamHandler');
70-
$this->assertDICConstructorArguments($handler, ['/tmp/symfony.log', \Monolog\Logger::WARNING, true, null, false]
71-
);
68+
$this->assertDICConstructorArguments($handler, ['/tmp/symfony.log', \Monolog\Logger::WARNING, true, null, false]);
7269

7370
$handler = $container->getDefinition('monolog.handler.main');
7471
$this->assertDICDefinitionClass($handler, 'Monolog\Handler\FingersCrossedHandler');
75-
$this->assertDICConstructorArguments($handler, [new Reference('monolog.handler.nested'), \Monolog\Logger::ERROR, 0, true, true, null]
76-
);
72+
$this->assertDICConstructorArguments($handler, [new Reference('monolog.handler.nested'), \Monolog\Logger::ERROR, 0, true, true, null]);
7773
}
7874

7975
public function testLoadWithNewAtEnd()
@@ -119,8 +115,7 @@ public function testLoadWithNewAndPriority()
119115

120116
$handler = $container->getDefinition('monolog.handler.main');
121117
$this->assertDICDefinitionClass($handler, 'Monolog\Handler\BufferHandler');
122-
$this->assertDICConstructorArguments($handler, [new Reference('monolog.handler.nested'), 0, \Monolog\Logger::INFO, true, false]
123-
);
118+
$this->assertDICConstructorArguments($handler, [new Reference('monolog.handler.nested'), 0, \Monolog\Logger::INFO, true, false]);
124119

125120
$handler = $container->getDefinition('monolog.handler.first');
126121
$this->assertDICDefinitionClass($handler, 'Monolog\Handler\RotatingFileHandler');

Tests/DependencyInjection/MonologExtensionTest.php

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -232,8 +232,7 @@ public function testRollbarHandlerCreatesNotifier()
232232

233233
$handler = $container->getDefinition('monolog.handler.main');
234234
$this->assertDICDefinitionClass($handler, 'Monolog\Handler\RollbarHandler');
235-
$this->assertDICConstructorArguments($handler, [new Reference('monolog.rollbar.notifier.1c8e6a67728dff6a209f828427128dd8b3c2b746'), \Monolog\Logger::DEBUG, true]
236-
);
235+
$this->assertDICConstructorArguments($handler, [new Reference('monolog.rollbar.notifier.1c8e6a67728dff6a209f828427128dd8b3c2b746'), \Monolog\Logger::DEBUG, true]);
237236
}
238237

239238
public function testRollbarHandlerReusesNotifier()
@@ -456,15 +455,13 @@ public function testLogglyHandler()
456455
$handler = $container->getDefinition('monolog.handler.loggly');
457456
$this->assertDICDefinitionClass($handler, 'Monolog\Handler\LogglyHandler');
458457
$this->assertDICConstructorArguments($handler, [$token, \Monolog\Logger::DEBUG, true]);
459-
$this->assertDICDefinitionMethodCallAt(0, $handler, 'pushProcessor', [new Reference('monolog.processor.psr_log_message')]
460-
);
458+
$this->assertDICDefinitionMethodCallAt(0, $handler, 'pushProcessor', [new Reference('monolog.processor.psr_log_message')]);
461459

462460
$container = $this->getContainer([['handlers' => ['loggly' => [
463461
'type' => 'loggly', 'token' => $token, 'tags' => [' ', 'foo', '', 'bar']
464462
]]]]);
465463
$handler = $container->getDefinition('monolog.handler.loggly');
466-
$this->assertDICDefinitionMethodCallAt(0, $handler, 'pushProcessor', [new Reference('monolog.processor.psr_log_message')]
467-
);
464+
$this->assertDICDefinitionMethodCallAt(0, $handler, 'pushProcessor', [new Reference('monolog.processor.psr_log_message')]);
468465
$this->assertDICDefinitionMethodCallAt(1, $handler, 'setTag', ['foo,bar']);
469466
}
470467

@@ -487,13 +484,11 @@ public function testFingersCrossedHandlerWhenExcluded404sAreSpecified()
487484

488485
$strategy = $container->getDefinition('monolog.handler.main.not_found_strategy');
489486
$this->assertDICDefinitionClass($strategy, 'Symfony\Bridge\Monolog\Handler\FingersCrossed\NotFoundActivationStrategy');
490-
$this->assertDICConstructorArguments($strategy, [new Reference('request_stack'), ['^/foo', '^/bar'], \Monolog\Logger::WARNING]
491-
);
487+
$this->assertDICConstructorArguments($strategy, [new Reference('request_stack'), ['^/foo', '^/bar'], \Monolog\Logger::WARNING]);
492488

493489
$handler = $container->getDefinition('monolog.handler.main');
494490
$this->assertDICDefinitionClass($handler, 'Monolog\Handler\FingersCrossedHandler');
495-
$this->assertDICConstructorArguments($handler, [new Reference('monolog.handler.nested'), new Reference('monolog.handler.main.not_found_strategy'), 0, true, true, null]
496-
);
491+
$this->assertDICConstructorArguments($handler, [new Reference('monolog.handler.nested'), new Reference('monolog.handler.main.not_found_strategy'), 0, true, true, null]);
497492
}
498493

499494
public function testFingersCrossedHandlerWhenExcludedHttpCodesAreSpecified()
@@ -535,8 +530,7 @@ public function testFingersCrossedHandlerWhenExcludedHttpCodesAreSpecified()
535530

536531
$handler = $container->getDefinition('monolog.handler.main');
537532
$this->assertDICDefinitionClass($handler, 'Monolog\Handler\FingersCrossedHandler');
538-
$this->assertDICConstructorArguments($handler, [new Reference('monolog.handler.nested'), new Reference('monolog.handler.main.http_code_strategy'), 0, true, true, null]
539-
);
533+
$this->assertDICConstructorArguments($handler, [new Reference('monolog.handler.nested'), new Reference('monolog.handler.main.http_code_strategy'), 0, true, true, null]);
540534
}
541535

542536
protected function getContainer(array $config = [], array $thirdPartyDefinitions = [])

0 commit comments

Comments
 (0)