SCA: simplify some ifs in favour of null coalescing operator

kalessil · kalessil · commit 0225ecf6e456 · 2018-10-28T19:38:52.000+01:00
diff --git a/Asynchronous/Routing/SenderLocator.php b/Asynchronous/Routing/SenderLocator.php
@@ -57,10 +57,6 @@ public static function getValueFromMessageRouting(array $mapping, $message)
         if ($interfaceMapping = array_intersect_key($mapping, class_implements($message))) {
             return current($interfaceMapping);
         }
-        if (isset($mapping['*'])) {
-            return $mapping['*'];
-        }
-
-        return null;
+        return $mapping['*'] ?? null;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -57,10 +57,6 @@ public static function getValueFromMessageRouting(array $mapping, $message)`
`57`	`57`	`if ($interfaceMapping = array_intersect_key($mapping, class_implements($message))) {`
`58`	`58`	`return current($interfaceMapping);`
`59`	`59`	`}`
`60`		`- if (isset($mapping['*'])) {`
`61`		`- return $mapping['*'];`
`62`		`- }`
`63`		`-`
`64`		`- return null;`
	`60`	`+ return $mapping['*'] ?? null;`
`65`	`61`	`}`
`66`	`62`	`}`