From bc588806a03e173ee39d4bf66e2bb40ea46ff37e Mon Sep 17 00:00:00 2001
From: Jesse Rushlow <jr@rushlow.dev>
Date: Tue, 2 Apr 2024 19:07:45 -0400
Subject: [PATCH 1/2] [make:*] additional type improvements

---
 src/Maker/AbstractMaker.php        | 1 +
 src/Maker/MakeListener.php         | 1 +
 src/Maker/MakeMigration.php        | 1 +
 src/Maker/MakeRegistrationForm.php | 1 +
 src/Maker/MakeTest.php             | 2 ++
 5 files changed, 6 insertions(+)

diff --git a/src/Maker/AbstractMaker.php b/src/Maker/AbstractMaker.php
index 8341fdd6f..530bae0dd 100644
--- a/src/Maker/AbstractMaker.php
+++ b/src/Maker/AbstractMaker.php
@@ -41,6 +41,7 @@ protected function writeSuccessMessage(ConsoleStyle $io)
         $io->newLine();
     }
 
+    /** @param array<class-string, string> $dependencies */
     protected function addDependencies(array $dependencies, ?string $message = null): string
     {
         $dependencyBuilder = new DependencyBuilder();
diff --git a/src/Maker/MakeListener.php b/src/Maker/MakeListener.php
index cd625eb24..df5470c95 100644
--- a/src/Maker/MakeListener.php
+++ b/src/Maker/MakeListener.php
@@ -138,6 +138,7 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
         }
     }
 
+    /** @return void */
     public function configureDependencies(DependencyBuilder $dependencies)
     {
     }
diff --git a/src/Maker/MakeMigration.php b/src/Maker/MakeMigration.php
index 88e2a200e..91ebbef6b 100644
--- a/src/Maker/MakeMigration.php
+++ b/src/Maker/MakeMigration.php
@@ -51,6 +51,7 @@ public static function getCommandDescription(): string
         return 'Create a new migration based on database changes';
     }
 
+    /** @return void */
     public function setApplication(Application $application)
     {
         $this->application = $application;
diff --git a/src/Maker/MakeRegistrationForm.php b/src/Maker/MakeRegistrationForm.php
index ac69a1ff3..78c83107e 100644
--- a/src/Maker/MakeRegistrationForm.php
+++ b/src/Maker/MakeRegistrationForm.php
@@ -182,6 +182,7 @@ public function interact(InputInterface $input, ConsoleStyle $io, Command $comma
         }
     }
 
+    /** @param array<string, mixed> $securityData */
     private function interactAuthenticatorQuestions(ConsoleStyle $io, InteractiveSecurityHelper $interactiveSecurityHelper, array $securityData): void
     {
         // get list of authenticators
diff --git a/src/Maker/MakeTest.php b/src/Maker/MakeTest.php
index a948a1f1e..b30095af3 100644
--- a/src/Maker/MakeTest.php
+++ b/src/Maker/MakeTest.php
@@ -56,6 +56,8 @@ public static function getCommandName(): string
 
     /**
      * @deprecated remove this method when removing make:unit-test and make:functional-test
+     *
+     * @return string[]
      */
     public static function getCommandAliases(): iterable
     {

From bec2fbd9b7611fcaa956aed64fae8a01dd16c3bb Mon Sep 17 00:00:00 2001
From: Jesse Rushlow <jr@rushlow.dev>
Date: Tue, 2 Apr 2024 19:12:51 -0400
Subject: [PATCH 2/2] questionable - fix int return

---
 src/Maker/MakeMigration.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Maker/MakeMigration.php b/src/Maker/MakeMigration.php
index 91ebbef6b..d1043cae0 100644
--- a/src/Maker/MakeMigration.php
+++ b/src/Maker/MakeMigration.php
@@ -78,7 +78,7 @@ public function configureCommand(Command $command, InputConfiguration $inputConf
         ;
     }
 
-    /** @return void */
+    /** @return void|int */
     public function generate(InputInterface $input, ConsoleStyle $io, Generator $generator)
     {
         $options = ['doctrine:migrations:diff'];