Merge branch '5.4' into 6.4

* 5.4:
  [VarDumper] Fix test suite with PHP 8.4
  [DoctrineBridge] Add missing return type
  [Mailer] Fix sendmail transport not handling failure
  [HttpClient] Lazily initialize CurlClientState
  updating missing translations for Greek #53768
  [Validator] Allow BICs’ first four characters to be digits
  [ErrorHandler] Fix exit code when an exception occurs and the exception handler has been unregistered
  [Validator] Review Arabic translations and add correct translations.

Author: nicolas-grekas

Tests/Transport/Fixtures/fake-failing-sendmail.php

@@ -0,0 +1,4 @@
+#!/usr/bin/env php
+<?php
+print "Sending failed";
+exit(42);

Tests/Transport/SendmailTransportTest.php

@@ -13,13 +13,15 @@
 
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Mailer\DelayedEnvelope;
+use Symfony\Component\Mailer\Exception\TransportException;
 use Symfony\Component\Mailer\Transport\SendmailTransport;
 use Symfony\Component\Mime\Address;
 use Symfony\Component\Mime\Email;
 
 class SendmailTransportTest extends TestCase
 {
     private const FAKE_SENDMAIL = __DIR__.'/Fixtures/fake-sendmail.php -t';
+    private const FAKE_FAILING_SENDMAIL = __DIR__.'/Fixtures/fake-failing-sendmail.php -t';
 
     private string $argsPath;
 
@@ -86,4 +88,27 @@ public function testRecipientsAreUsedWhenSet()
 
         $this->assertStringEqualsFile($this->argsPath, __DIR__.'/Fixtures/fake-sendmail.php -ffrom@mail.com recipient@mail.com');
     }
+
+    public function testThrowsTransportExceptionOnFailure()
+    {
+        if ('\\' === \DIRECTORY_SEPARATOR) {
+            $this->markTestSkipped('Windows does not support shebangs nor non-blocking standard streams');
+        }
+
+        $mail = new Email();
+        $mail
+            ->from('from@mail.com')
+            ->to('to@mail.com')
+            ->subject('Subject')
+            ->text('Some text')
+        ;
+
+        $envelope = new DelayedEnvelope($mail);
+        $envelope->setRecipients([new Address('recipient@mail.com')]);
+
+        $sendmailTransport = new SendmailTransport(self::FAKE_FAILING_SENDMAIL);
+        $this->expectException(TransportException::class);
+        $this->expectExceptionMessage('Process failed with exit code 42: Sending failed');
+        $sendmailTransport->send($mail, $envelope);
+    }
 }

Transport/Smtp/Stream/AbstractStream.php

@@ -30,6 +30,7 @@ abstract class AbstractStream
     protected $in;
     /** @var resource|null */
     protected $out;
+    protected $err;
 
     private string $debug = '';
 
@@ -68,7 +69,7 @@ abstract public function initialize(): void;
 
     public function terminate(): void
     {
-        $this->stream = $this->out = $this->in = null;
+        $this->stream = $this->err = $this->out = $this->in = null;
     }
 
     public function readLine(): string

Transport/Smtp/Stream/ProcessStream.php

@@ -45,14 +45,20 @@ public function initialize(): void
         }
         $this->in = &$pipes[0];
         $this->out = &$pipes[1];
+        $this->err = &$pipes[2];
     }
 
     public function terminate(): void
     {
         if (null !== $this->stream) {
             fclose($this->in);
+            $out = stream_get_contents($this->out);
             fclose($this->out);
-            proc_close($this->stream);
+            $err = stream_get_contents($this->err);
+            fclose($this->err);
+            if (0 !== $exitCode = proc_close($this->stream)) {
+                throw new TransportException('Process failed with exit code '.$exitCode.': '.$out.$err);
+            }
         }
 
         parent::terminate();