[BC Break] Make data providers for abstract test cases static

Author: OskarStark

CHANGELOG.md

@@ -1,6 +1,14 @@
 CHANGELOG
 =========
 
+5.4.21
+------
+
+* [BC BREAK] The following data providers for `TransportFactoryTestCase` are now static:
+  `supportsProvider()`, `createProvider()`, `unsupportedSchemeProvider()`and `incompleteDsnProvider()`
+* [BC BREAK] The following data providers for `TransportTestCase` are now static:
+  `toStringProvider()`, `supportedMessagesProvider()` and `unsupportedMessagesProvider()`
+
 5.4
 ---
 

Test/TransportFactoryTestCase.php

@@ -37,16 +37,16 @@ abstract class TransportFactoryTestCase extends TestCase
 
     abstract public function getFactory(): TransportFactoryInterface;
 
-    abstract public function supportsProvider(): iterable;
+    abstract public static function supportsProvider(): iterable;
 
-    abstract public function createProvider(): iterable;
+    abstract public static function createProvider(): iterable;
 
-    public function unsupportedSchemeProvider(): iterable
+    public static function unsupportedSchemeProvider(): iterable
     {
         return [];
     }
 
-    public function incompleteDsnProvider(): iterable
+    public static function incompleteDsnProvider(): iterable
     {
         return [];
     }

Tests/Transport/NullTransportFactoryTest.php

@@ -24,15 +24,15 @@ public function getFactory(): TransportFactoryInterface
         return new NullTransportFactory($this->getDispatcher(), $this->getClient(), $this->getLogger());
     }
 
-    public function supportsProvider(): iterable
+    public static function supportsProvider(): iterable
     {
         yield [
             new Dsn('null', ''),
             true,
         ];
     }
 
-    public function createProvider(): iterable
+    public static function createProvider(): iterable
     {
         yield [
             new Dsn('null', 'null'),

Tests/Transport/SendmailTransportFactoryTest.php

@@ -24,15 +24,15 @@ public function getFactory(): TransportFactoryInterface
         return new SendmailTransportFactory($this->getDispatcher(), $this->getClient(), $this->getLogger());
     }
 
-    public function supportsProvider(): iterable
+    public static function supportsProvider(): iterable
     {
         yield [
             new Dsn('sendmail+smtp', 'default'),
             true,
         ];
     }
 
-    public function createProvider(): iterable
+    public static function createProvider(): iterable
     {
         yield [
             new Dsn('sendmail+smtp', 'default'),
@@ -45,7 +45,7 @@ public function createProvider(): iterable
         ];
     }
 
-    public function unsupportedSchemeProvider(): iterable
+    public static function unsupportedSchemeProvider(): iterable
     {
         yield [
             new Dsn('sendmail+http', 'default'),

Tests/Transport/Smtp/EsmtpTransportFactoryTest.php

@@ -25,7 +25,7 @@ public function getFactory(): TransportFactoryInterface
         return new EsmtpTransportFactory($this->getDispatcher(), $this->getClient(), $this->getLogger());
     }
 
-    public function supportsProvider(): iterable
+    public static function supportsProvider(): iterable
     {
         yield [
             new Dsn('smtp', 'example.com'),
@@ -43,7 +43,7 @@ public function supportsProvider(): iterable
         ];
     }
 
-    public function createProvider(): iterable
+    public static function createProvider(): iterable
     {
         $eventDispatcher = $this->getDispatcher();
         $logger = $this->getLogger();