Skip to content

Commit e184c65

Browse files
Merge branch '6.4' into 7.0
* 6.4: Fix implicitly-required parameters minor #53524 [Messenger] [AmazonSqs] Allow `async-aws/sqs` version 2 (smoench) Fix bad merge List CS fix in .git-blame-ignore-revs Fix implicitly-required parameters List CS fix in .git-blame-ignore-revs Apply php-cs-fixer fix --rules nullable_type_declaration_for_default_null_value [Messenger][AmazonSqs] Allow async-aws/sqs version 2
2 parents 6be9cb3 + 1cabf3c commit e184c65

File tree

6 files changed

+6
-6
lines changed

6 files changed

+6
-6
lines changed

Lock.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ public function acquireRead(bool $blocking = false): bool
175175
}
176176
}
177177

178-
public function refresh(float $ttl = null): void
178+
public function refresh(?float $ttl = null): void
179179
{
180180
if (!$ttl ??= $this->ttl) {
181181
throw new InvalidArgumentException('You have to define an expiration duration.');

LockInterface.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public function acquire(bool $blocking = false): bool;
3939
* @throws LockConflictedException If the lock is acquired by someone else
4040
* @throws LockAcquiringException If the lock cannot be refreshed
4141
*/
42-
public function refresh(float $ttl = null): void;
42+
public function refresh(?float $ttl = null): void;
4343

4444
/**
4545
* Returns whether or not the lock is acquired.

NoLock.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public function acquire(bool $blocking = false): bool
2626
return true;
2727
}
2828

29-
public function refresh(float $ttl = null): void
29+
public function refresh(?float $ttl = null): void
3030
{
3131
}
3232

Store/FlockStore.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class FlockStore implements BlockingStoreInterface, SharedLockStoreInterface
3737
*
3838
* @throws LockStorageException If the lock directory doesn’t exist or is not writable
3939
*/
40-
public function __construct(string $lockPath = null)
40+
public function __construct(?string $lockPath = null)
4141
{
4242
if (!is_dir($lockPath ??= sys_get_temp_dir())) {
4343
if (false === @mkdir($lockPath, 0777, true) && !is_dir($lockPath)) {

Tests/Store/DoctrineDbalStoreTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public function testAbortAfterExpiration()
7272
/**
7373
* @dataProvider provideDsnWithSQLite
7474
*/
75-
public function testDsnWithSQLite(string $dsn, string $file = null)
75+
public function testDsnWithSQLite(string $dsn, ?string $file = null)
7676
{
7777
$key = new Key(uniqid(__METHOD__, true));
7878

Tests/Store/PdoStoreTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public function testInvalidTtlConstruct()
7272
/**
7373
* @dataProvider provideDsnWithSQLite
7474
*/
75-
public function testDsnWithSQLite(string $dsn, string $file = null)
75+
public function testDsnWithSQLite(string $dsn, ?string $file = null)
7676
{
7777
$key = new Key(uniqid(__METHOD__, true));
7878

0 commit comments

Comments
 (0)