Merge branch '4.4' into 5.2

* 4.4:
  [4.4] Add missing `@return` annotations
  Handle lock with long key

Author: nicolas-grekas

Lock.php

@@ -49,6 +49,9 @@ public function __construct(Key $key, PersistingStoreInterface $store, float $tt
         $this->logger = new NullLogger();
     }
 
+    /**
+     * @return array
+     */
     public function __sleep()
     {
         throw new \BadMethodCallException('Cannot serialize '.__CLASS__);

Store/FlockStore.php

@@ -96,7 +96,7 @@ private function lock(Key $key, bool $read, bool $blocking)
         if (!$handle) {
             $fileName = sprintf('%s/sf.%s.%s.lock',
                 $this->lockPath,
-                preg_replace('/[^a-z0-9\._-]+/i', '-', $key),
+                substr(preg_replace('/[^a-z0-9\._-]+/i', '-', $key), 0, 50),
                 strtr(substr(base64_encode(hash('sha256', $key, true)), 0, 7), '/', '_')
             );
 

Tests/Store/FlockStoreTest.php

@@ -75,4 +75,25 @@ public function testSaveSanitizeName()
 
         $store->delete($key);
     }
+
+    public function testSaveSanitizeLongName()
+    {
+        $store = $this->getStore();
+
+        $key = new Key(str_repeat(__CLASS__, 100));
+
+        $file = sprintf(
+            '%s/sf.Symfony-Component-Lock-Tests-Store-FlockStoreTestS.%s.lock',
+            sys_get_temp_dir(),
+            strtr(substr(base64_encode(hash('sha256', $key, true)), 0, 7), '/', '_')
+        );
+        // ensure the file does not exist before the store
+        @unlink($file);
+
+        $store->save($key);
+
+        $this->assertFileExists($file);
+
+        $store->delete($key);
+    }
 }