Skip to content

Commit 274e2f0

Browse files
committed
Don't skip Doctrine tests on php 8.
1 parent 620d064 commit 274e2f0

File tree

2 files changed

+0
-10
lines changed

2 files changed

+0
-10
lines changed

Tests/Store/PdoDbalStoreTest.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
namespace Symfony\Component\Lock\Tests\Store;
1313

1414
use Doctrine\DBAL\DriverManager;
15-
use Doctrine\DBAL\Version;
1615
use Symfony\Component\Lock\PersistingStoreInterface;
1716
use Symfony\Component\Lock\Store\PdoStore;
1817

@@ -31,10 +30,6 @@ public static function setUpBeforeClass(): void
3130
{
3231
self::$dbFile = tempnam(sys_get_temp_dir(), 'sf_sqlite_lock');
3332

34-
if (\PHP_VERSION_ID >= 80000 && class_exists(Version::class)) {
35-
self::markTestSkipped('Doctrine DBAL 2.x is incompatible with PHP 8.');
36-
}
37-
3833
$store = new PdoStore(DriverManager::getConnection(['driver' => 'pdo_sqlite', 'path' => self::$dbFile]));
3934
$store->createTable();
4035
}

Tests/Store/PdoStoreTest.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111

1212
namespace Symfony\Component\Lock\Tests\Store;
1313

14-
use Doctrine\DBAL\Version;
1514
use Symfony\Component\Lock\Key;
1615
use Symfony\Component\Lock\PersistingStoreInterface;
1716
use Symfony\Component\Lock\Store\PdoStore;
@@ -31,10 +30,6 @@ public static function setUpBeforeClass(): void
3130
{
3231
self::$dbFile = tempnam(sys_get_temp_dir(), 'sf_sqlite_lock');
3332

34-
if (\PHP_VERSION_ID >= 80000 && class_exists(Version::class)) {
35-
self::markTestSkipped('Doctrine DBAL 2.x is incompatible with PHP 8.');
36-
}
37-
3833
$store = new PdoStore('sqlite:'.self::$dbFile);
3934
$store->createTable();
4035
}

0 commit comments

Comments
 (0)