Merge branch '5.4' into 6.3

* 5.4:
  Fix implicitly-required parameters
  List CS fix in .git-blame-ignore-revs
  Apply php-cs-fixer fix --rules nullable_type_declaration_for_default_null_value
  [Messenger][AmazonSqs] Allow async-aws/sqs version 2

Author: nicolas-grekas

Adapter/ConnectionInterface.php

@@ -34,5 +34,5 @@ public function isBound(): bool;
      *
      * @return void
      */
-    public function bind(string $dn = null, #[\SensitiveParameter] string $password = null);
+    public function bind(?string $dn = null, #[\SensitiveParameter] ?string $password = null);
 }

Adapter/ExtLdap/Connection.php

@@ -66,7 +66,7 @@ public function isBound(): bool
      *
      * @return void
      */
-    public function bind(string $dn = null, #[\SensitiveParameter] string $password = null)
+    public function bind(?string $dn = null, #[\SensitiveParameter] ?string $password = null)
     {
         if (!$this->connection) {
             $this->connect();

Ldap.php

@@ -29,7 +29,7 @@ public function __construct(AdapterInterface $adapter)
         $this->adapter = $adapter;
     }
 
-    public function bind(string $dn = null, #[\SensitiveParameter] string $password = null): void
+    public function bind(?string $dn = null, #[\SensitiveParameter] ?string $password = null): void
     {
         $this->adapter->getConnection()->bind($dn, $password);
     }

LdapInterface.php

@@ -32,7 +32,7 @@ interface LdapInterface
      *
      * @return void
      */
-    public function bind(string $dn = null, #[\SensitiveParameter] string $password = null);
+    public function bind(?string $dn = null, #[\SensitiveParameter] ?string $password = null);
 
     /**
      * Queries a ldap server for entries matching the given criteria.

Security/LdapAuthenticator.php

@@ -88,7 +88,7 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio
         return $this->authenticator->onAuthenticationFailure($request, $exception);
     }
 
-    public function start(Request $request, AuthenticationException $authException = null): Response
+    public function start(Request $request, ?AuthenticationException $authException = null): Response
     {
         if (!$this->authenticator instanceof AuthenticationEntryPointInterface) {
             throw new NotAnEntryPointException(sprintf('Decorated authenticator "%s" does not implement interface "%s".', get_debug_type($this->authenticator), AuthenticationEntryPointInterface::class));

Security/LdapBadge.php

@@ -31,7 +31,7 @@ class LdapBadge implements BadgeInterface
     private string $searchPassword;
     private ?string $queryString;
 
-    public function __construct(string $ldapServiceId, string $dnString = '{user_identifier}', string $searchDn = '', string $searchPassword = '', string $queryString = null)
+    public function __construct(string $ldapServiceId, string $dnString = '{user_identifier}', string $searchDn = '', string $searchPassword = '', ?string $queryString = null)
     {
         $this->ldapServiceId = $ldapServiceId;
         $dnString = str_replace('{username}', '{user_identifier}', $dnString, $replaceCount);

Security/LdapUserProvider.php

@@ -43,7 +43,7 @@ class LdapUserProvider implements UserProviderInterface, PasswordUpgraderInterfa
     private ?string $passwordAttribute;
     private array $extraFields;
 
-    public function __construct(LdapInterface $ldap, string $baseDn, string $searchDn = null, #[\SensitiveParameter] string $searchPassword = null, array $defaultRoles = [], string $uidKey = null, string $filter = null, string $passwordAttribute = null, array $extraFields = [])
+    public function __construct(LdapInterface $ldap, string $baseDn, ?string $searchDn = null, #[\SensitiveParameter] ?string $searchPassword = null, array $defaultRoles = [], ?string $uidKey = null, ?string $filter = null, ?string $passwordAttribute = null, array $extraFields = [])
     {
         $uidKey ??= 'sAMAccountName';
         $filter ??= '({uid_key}={user_identifier})';