More short closures + isset instead of null checks + etc.

nicolas-grekas · nicolas-grekas · commit f2ae42b44b04 · 2023-07-27T08:52:43.000+02:00
diff --git a/Adapter/ExtLdap/Query.php b/Adapter/ExtLdap/Query.php
@@ -46,7 +46,6 @@ public function __wakeup()
     public function __destruct()
     {
         $con = $this->connection->getResource();
-        $this->connection = null;
 
         if (!isset($this->results)) {
             return;
@@ -60,7 +59,6 @@ public function __destruct()
                 throw new LdapException('Could not free results: '.ldap_error($con));
             }
         }
-        unset($this->results);
     }
 
     public function execute(): CollectionInterface

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,6 @@ public function __wakeup()`
`46`	`46`	`public function __destruct()`
`47`	`47`	`{`
`48`	`48`	`$con = $this->connection->getResource();`
`49`		`- $this->connection = null;`
`50`	`49`
`51`	`50`	`if (!isset($this->results)) {`
`52`	`51`	`return;`
`@@ -60,7 +59,6 @@ public function __destruct()`
`60`	`59`	`throw new LdapException('Could not free results: '.ldap_error($con));`
`61`	`60`	`}`
`62`	`61`	`}`
`63`		`- unset($this->results);`
`64`	`62`	`}`
`65`	`63`
`66`	`64`	`public function execute(): CollectionInterface`