Skip to content

Commit e204da5

Browse files
committed
Remove check for unsupported PHP version
1 parent 1d6853d commit e204da5

File tree

1 file changed

+11
-13
lines changed

1 file changed

+11
-13
lines changed

Tests/Adapter/ExtLdap/AdapterTest.php

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -148,19 +148,17 @@ public function testLdapPagination()
148148
$this->assertEquals(\count($fully_paged_query->getResources()), 1);
149149
$this->assertEquals(\count($paged_query->getResources()), 5);
150150

151-
if (\PHP_VERSION_ID >= 70200) {
152-
// This last query is to ensure that we haven't botched the state of our connection
153-
// by not resetting pagination properly. extldap <= PHP 7.1 do not implement the necessary
154-
// bits to work around an implementation flaw, so we simply can't guarantee this to work there.
155-
$final_query = $ldap->createQuery('dc=symfony,dc=com', '(&(objectClass=applicationProcess)(cn=user*))', [
156-
'scope' => Query::SCOPE_ONE,
157-
]);
158-
159-
$final_results = $final_query->execute();
160-
161-
$this->assertEquals($final_results->count(), 25);
162-
$this->assertEquals(\count($final_query->getResources()), 1);
163-
}
151+
// This last query is to ensure that we haven't botched the state of our connection
152+
// by not resetting pagination properly. extldap <= PHP 7.1 do not implement the necessary
153+
// bits to work around an implementation flaw, so we simply can't guarantee this to work there.
154+
$final_query = $ldap->createQuery('dc=symfony,dc=com', '(&(objectClass=applicationProcess)(cn=user*))', [
155+
'scope' => Query::SCOPE_ONE,
156+
]);
157+
158+
$final_results = $final_query->execute();
159+
160+
$this->assertEquals($final_results->count(), 25);
161+
$this->assertEquals(\count($final_query->getResources()), 1);
164162
} catch (LdapException $exc) {
165163
$this->markTestSkipped('Test LDAP server does not support pagination');
166164
}

0 commit comments

Comments
 (0)