Skip to content

Commit d405d19

Browse files
committed
Merge branch '5.4' into 6.0
* 5.4: [Console] Restore psr/log >= 3.0 conflict [Security] Make the abstract Voter class implement CacheableVoterInterface Add generic types to traversable implementations [Security] Fix TypeError message [Security] Fix deprecation layer [FrameworkBundle] Add completion for workflow:dump Fix cancel button Fix misleading error on missing provider with authenticator manager Don't limit retries of toolbar loading
2 parents af17f83 + d6a474c commit d405d19

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

Adapter/CollectionInterface.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,14 @@
1515

1616
/**
1717
* @author Charles Sarrazin <charles@sarraz.in>
18+
*
19+
* @extends \ArrayAccess<int, Entry>
20+
* @extends \IteratorAggregate<int, Entry>
1821
*/
1922
interface CollectionInterface extends \Countable, \IteratorAggregate, \ArrayAccess
2023
{
2124
/**
22-
* @return Entry[]
25+
* @return array<int, Entry>
2326
*/
2427
public function toArray(): array;
2528
}

Adapter/ExtLdap/Collection.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ public function offsetExists(mixed $offset): bool
8484
return isset($this->entries[$offset]);
8585
}
8686

87-
public function offsetGet(mixed $offset): mixed
87+
public function offsetGet(mixed $offset): ?Entry
8888
{
8989
$this->toArray();
9090

Adapter/ExtLdap/EntryManager.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ private function getConnectionResource()
140140
}
141141

142142
/**
143-
* @param iterable|UpdateOperation[] $operations An array or iterable of UpdateOperation instances
143+
* @param iterable<int, UpdateOperation> $operations An array or iterable of UpdateOperation instances
144144
*
145145
* @throws UpdateOperationException in case of an error
146146
*/

Tests/Adapter/ExtLdap/LdapManagerTest.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
namespace Symfony\Component\Ldap\Tests\Adapter\ExtLdap;
1313

14+
use Symfony\Component\Ldap\Adapter\CollectionInterface;
1415
use Symfony\Component\Ldap\Adapter\ExtLdap\Adapter;
1516
use Symfony\Component\Ldap\Adapter\ExtLdap\Collection;
1617
use Symfony\Component\Ldap\Adapter\ExtLdap\UpdateOperation;
@@ -160,10 +161,7 @@ public function testLdapUnboundUpdate()
160161
$em->update(new Entry(''));
161162
}
162163

163-
/**
164-
* @return Collection|Entry[]
165-
*/
166-
private function executeSearchQuery($expectedResults = 1): Collection|array
164+
private function executeSearchQuery($expectedResults = 1): CollectionInterface
167165
{
168166
$results = $this
169167
->adapter

0 commit comments

Comments
 (0)