Add return types to tests and final|internal|private methods

Author: nicolas-grekas

Ldap.php

@@ -12,6 +12,8 @@
 namespace Symfony\Component\Ldap;
 
 use Symfony\Component\Ldap\Adapter\AdapterInterface;
+use Symfony\Component\Ldap\Adapter\EntryManagerInterface;
+use Symfony\Component\Ldap\Adapter\QueryInterface;
 use Symfony\Component\Ldap\Exception\DriverNotFoundException;
 
 /**
@@ -41,23 +43,23 @@ public function bind($dn = null, $password = null)
     /**
      * {@inheritdoc}
      */
-    public function query($dn, $query, array $options = [])
+    public function query($dn, $query, array $options = []): QueryInterface
     {
         return $this->adapter->createQuery($dn, $query, $options);
     }
 
     /**
      * {@inheritdoc}
      */
-    public function getEntryManager()
+    public function getEntryManager(): EntryManagerInterface
     {
         return $this->adapter->getEntryManager();
     }
 
     /**
      * {@inheritdoc}
      */
-    public function escape($subject, $ignore = '', $flags = 0)
+    public function escape($subject, $ignore = '', $flags = 0): string
     {
         return $this->adapter->escape($subject, $ignore, $flags);
     }

Tests/LdapTest.php

@@ -15,6 +15,7 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Ldap\Adapter\AdapterInterface;
 use Symfony\Component\Ldap\Adapter\ConnectionInterface;
+use Symfony\Component\Ldap\Adapter\QueryInterface;
 use Symfony\Component\Ldap\Exception\DriverNotFoundException;
 use Symfony\Component\Ldap\Ldap;
 
@@ -54,6 +55,7 @@ public function testLdapEscape()
             ->expects($this->once())
             ->method('escape')
             ->with('foo', 'bar', 'baz')
+            ->willReturn('');
         ;
         $this->ldap->escape('foo', 'bar', 'baz');
     }
@@ -64,6 +66,7 @@ public function testLdapQuery()
             ->expects($this->once())
             ->method('createQuery')
             ->with('foo', 'bar', ['baz'])
+            ->willReturn($this->createMock(QueryInterface::class))
         ;
         $this->ldap->query('foo', 'bar', ['baz']);
     }