Skip to content

Commit a673976

Browse files
committed
Remove < PHP 8 dead code
1 parent 5732249 commit a673976

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

Adapter/ExtLdap/Query.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,7 @@
2424
*/
2525
class Query extends AbstractQuery
2626
{
27-
// As of PHP 7.2, we can use LDAP_CONTROL_PAGEDRESULTS instead of this
28-
public const PAGINATION_OID = '1.2.840.113556.1.4.319';
27+
public const PAGINATION_OID = \LDAP_CONTROL_PAGEDRESULTS;
2928

3029
/** @var Connection */
3130
protected $connection;

Tests/Adapter/ExtLdap/AdapterTest.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,7 @@ public function testLdapPagination()
149149
$this->assertEquals(\count($paged_query->getResources()), 5);
150150

151151
// This last query is to ensure that we haven't botched the state of our connection
152-
// by not resetting pagination properly. extldap <= PHP 7.1 do not implement the necessary
153-
// bits to work around an implementation flaw, so we simply can't guarantee this to work there.
152+
// by not resetting pagination properly.
154153
$final_query = $ldap->createQuery('dc=symfony,dc=com', '(&(objectClass=applicationProcess)(cn=user*))', [
155154
'scope' => Query::SCOPE_ONE,
156155
]);

0 commit comments

Comments
 (0)