Merge remote-tracking branch 'origin/4.4' into 5.1

nicolas-grekas · nicolas-grekas · commit 875d85b5efaf · 2020-09-02T18:21:51.000+02:00
* origin/4.4:
  Fix CS
  Add a warning comment on ldap empty password
  Bump Symfony version to 4.4.14
  Update VERSION for 4.4.13
  Update CHANGELOG for 4.4.13
  [PhpunitBridge] Fix deprecation type detection
diff --git a/Adapter/ExtLdap/Connection.php b/Adapter/ExtLdap/Connection.php
@@ -50,6 +50,8 @@ public function isBound()
 
     /**
      * {@inheritdoc}
+     *
+     * @param string $password WARNING: When the LDAP server allows unauthenticated binds, a blank $password will always be valid
      */
     public function bind(string $dn = null, string $password = null)
     {

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,8 @@ public function isBound()`
`50`	`50`
`51`	`51`	`/**`
`52`	`52`	`* {@inheritdoc}`
	`53`	`+ *`
	`54`	`+ * @param string $password WARNING: When the LDAP server allows unauthenticated binds, a blank $password will always be valid`
`53`	`55`	`*/`
`54`	`56`	`public function bind(string $dn = null, string $password = null)`
`55`	`57`	`{`