Use typed properties in tests as much as possible

nicolas-grekas · nicolas-grekas · commit 485dd1f006cc · 2023-07-25T10:53:33.000+02:00
diff --git a/Tests/Adapter/ExtLdap/LdapManagerTest.php b/Tests/Adapter/ExtLdap/LdapManagerTest.php
@@ -27,8 +27,7 @@
  */
 class LdapManagerTest extends LdapTestCase
 {
-    /** @var Adapter */
-    private $adapter;
+    private Adapter $adapter;
 
     protected function setUp(): void
     {
diff --git a/Tests/LdapTest.php b/Tests/LdapTest.php
@@ -21,11 +21,8 @@
 
 class LdapTest extends TestCase
 {
-    /** @var MockObject&AdapterInterface */
-    private $adapter;
-
-    /** @var Ldap */
-    private $ldap;
+    private MockObject&AdapterInterface $adapter;
+    private Ldap $ldap;
 
     protected function setUp(): void
     {
diff --git a/Tests/Security/CheckLdapCredentialsListenerTest.php b/Tests/Security/CheckLdapCredentialsListenerTest.php
@@ -11,6 +11,7 @@
 
 namespace Symfony\Component\Ldap\Tests\Security;
 
+use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 use Psr\Container\ContainerInterface;
 use Symfony\Component\HttpFoundation\Request;
@@ -37,7 +38,7 @@
 
 class CheckLdapCredentialsListenerTest extends TestCase
 {
-    private $ldap;
+    private MockObject&LdapInterface $ldap;
 
     protected function setUp(): void
     {

Original file line number	Diff line number	Diff line change
`@@ -27,8 +27,7 @@`
`27`	`27`	`*/`
`28`	`28`	`class LdapManagerTest extends LdapTestCase`
`29`	`29`	`{`
`30`		`- /** @var Adapter */`
`31`		`- private $adapter;`
	`30`	`+ private Adapter $adapter;`
`32`	`31`
`33`	`32`	`protected function setUp(): void`
`34`	`33`	`{`
Original file line number	Diff line number	Diff line change
`@@ -21,11 +21,8 @@`
`21`	`21`
`22`	`22`	`class LdapTest extends TestCase`
`23`	`23`	`{`
`24`		`- /** @var MockObject&AdapterInterface */`
`25`		`- private $adapter;`
`26`		`-`
`27`		`- /** @var Ldap */`
`28`		`- private $ldap;`
	`24`	`+ private MockObject&AdapterInterface $adapter;`
	`25`	`+ private Ldap $ldap;`
`29`	`26`
`30`	`27`	`protected function setUp(): void`
`31`	`28`	`{`
Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@`
`11`	`11`
`12`	`12`	`namespace Symfony\Component\Ldap\Tests\Security;`
`13`	`13`
	`14`	`+use PHPUnit\Framework\MockObject\MockObject;`
`14`	`15`	`use PHPUnit\Framework\TestCase;`
`15`	`16`	`use Psr\Container\ContainerInterface;`
`16`	`17`	`use Symfony\Component\HttpFoundation\Request;`
`@@ -37,7 +38,7 @@`
`37`	`38`
`38`	`39`	`class CheckLdapCredentialsListenerTest extends TestCase`
`39`	`40`	`{`
`40`		`- private $ldap;`
	`41`	`+ private MockObject&LdapInterface $ldap;`
`41`	`42`
`42`	`43`	`protected function setUp(): void`
`43`	`44`	`{`