Add missing PHPdoc return types

Author: wouterj

Adapter/EntryManagerInterface.php

@@ -25,6 +25,8 @@ interface EntryManagerInterface
     /**
      * Adds a new entry in the Ldap server.
      *
+     * @return $this
+     *
      * @throws NotBoundException
      * @throws LdapException
      */
@@ -33,6 +35,8 @@ public function add(Entry $entry);
     /**
      * Updates an entry from the Ldap server.
      *
+     * @return $this
+     *
      * @throws NotBoundException
      * @throws LdapException
      */
@@ -41,6 +45,8 @@ public function update(Entry $entry);
     /**
      * Moves an entry on the Ldap server.
      *
+     * @return $this
+     *
      * @throws NotBoundException
      * @throws LdapException
      */
@@ -49,6 +55,8 @@ public function move(Entry $entry, string $newParent);
     /**
      * Renames an entry on the Ldap server.
      *
+     * @return $this
+     *
      * @throws NotBoundException
      * @throws LdapException
      */
@@ -57,6 +65,8 @@ public function rename(Entry $entry, string $newRdn, bool $removeOldRdn = true);
     /**
      * Removes an entry from the Ldap server.
      *
+     * @return $this
+     *
      * @throws NotBoundException
      * @throws LdapException
      */

Adapter/ExtLdap/EntryManager.php

@@ -11,6 +11,7 @@
 
 namespace Symfony\Component\Ldap\Adapter\ExtLdap;
 
+use LDAP\Connection as LDAPConnection;
 use Symfony\Component\Ldap\Adapter\EntryManagerInterface;
 use Symfony\Component\Ldap\Entry;
 use Symfony\Component\Ldap\Exception\LdapException;
@@ -30,6 +31,9 @@ public function __construct(Connection $connection)
         $this->connection = $connection;
     }
 
+    /**
+     * @return $this
+     */
     public function add(Entry $entry)
     {
         $con = $this->getConnectionResource();
@@ -41,27 +45,39 @@ public function add(Entry $entry)
         return $this;
     }
 
+    /**
+     * @return $this
+     */
     public function update(Entry $entry)
     {
         $con = $this->getConnectionResource();
 
         if (!@ldap_modify($con, $entry->getDn(), $entry->getAttributes())) {
             throw new LdapException(sprintf('Could not update entry "%s": ', $entry->getDn()).ldap_error($con), ldap_errno($con));
         }
+
+        return $this;
     }
 
+    /**
+     * @return $this
+     */
     public function remove(Entry $entry)
     {
         $con = $this->getConnectionResource();
 
         if (!@ldap_delete($con, $entry->getDn())) {
             throw new LdapException(sprintf('Could not remove entry "%s": ', $entry->getDn()).ldap_error($con), ldap_errno($con));
         }
+
+        return $this;
     }
 
     /**
      * Adds values to an entry's multi-valued attribute from the LDAP server.
      *
+     * @return $this
+     *
      * @throws NotBoundException
      * @throws LdapException
      */
@@ -72,11 +88,15 @@ public function addAttributeValues(Entry $entry, string $attribute, array $value
         if (!@ldap_mod_add($con, $entry->getDn(), [$attribute => $values])) {
             throw new LdapException(sprintf('Could not add values to entry "%s", attribute "%s": ', $entry->getDn(), $attribute).ldap_error($con), ldap_errno($con));
         }
+
+        return $this;
     }
 
     /**
      * Removes values from an entry's multi-valued attribute from the LDAP server.
      *
+     * @return $this
+     *
      * @throws NotBoundException
      * @throws LdapException
      */
@@ -87,6 +107,8 @@ public function removeAttributeValues(Entry $entry, string $attribute, array $va
         if (!@ldap_mod_del($con, $entry->getDn(), [$attribute => $values])) {
             throw new LdapException(sprintf('Could not remove values from entry "%s", attribute "%s": ', $entry->getDn(), $attribute).ldap_error($con), ldap_errno($con));
         }
+
+        return $this;
     }
 
     public function rename(Entry $entry, string $newRdn, bool $removeOldRdn = true)
@@ -96,11 +118,15 @@ public function rename(Entry $entry, string $newRdn, bool $removeOldRdn = true)
         if (!@ldap_rename($con, $entry->getDn(), $newRdn, '', $removeOldRdn)) {
             throw new LdapException(sprintf('Could not rename entry "%s" to "%s": ', $entry->getDn(), $newRdn).ldap_error($con), ldap_errno($con));
         }
+
+        return $this;
     }
 
     /**
      * Moves an entry on the Ldap server.
      *
+     * @return $this
+     *
      * @throws NotBoundException if the connection has not been previously bound
      * @throws LdapException     if an error is thrown during the rename operation
      */
@@ -112,10 +138,14 @@ public function move(Entry $entry, string $newParent)
         if (!@ldap_rename($con, $entry->getDn(), $rdn, $newParent, true)) {
             throw new LdapException(sprintf('Could not move entry "%s" to "%s": ', $entry->getDn(), $newParent).ldap_error($con), ldap_errno($con));
         }
+
+        return $this;
     }
 
     /**
      * Get the connection resource, but first check if the connection is bound.
+     *
+     * @return resource|LDAPConnection
      */
     private function getConnectionResource()
     {
@@ -130,9 +160,11 @@ private function getConnectionResource()
     /**
      * @param iterable<int, UpdateOperation> $operations An array or iterable of UpdateOperation instances
      *
+     * @return $this
+     *
      * @throws UpdateOperationException in case of an error
      */
-    public function applyOperations(string $dn, iterable $operations): void
+    public function applyOperations(string $dn, iterable $operations)
     {
         $operationsMapped = [];
         foreach ($operations as $modification) {
@@ -143,6 +175,8 @@ public function applyOperations(string $dn, iterable $operations): void
         if (!@ldap_modify_batch($con, $dn, $operationsMapped)) {
             throw new UpdateOperationException(sprintf('Error executing UpdateOperation on "%s": ', $dn).ldap_error($con), ldap_errno($con));
         }
+
+        return $this;
     }
 
     private function parseRdnFromEntry(Entry $entry): string